[libvirt] [PATCH v4 0/4] qemu: Add support for -device hda-output (disable line-in)

Filip Alac posted 4 patches 5 years, 11 months ago
Failed in applying to current master (apply log)
Test syntax-check passed
docs/formatdomain.html.in                         | 15 ++++++++++++---
docs/news.xml                                     |  8 ++++++++
docs/schemas/domaincommon.rng                     |  1 +
src/conf/domain_conf.c                            |  3 ++-
src/conf/domain_conf.h                            |  1 +
src/qemu/qemu_capabilities.c                      |  2 ++
src/qemu/qemu_capabilities.h                      |  1 +
src/qemu/qemu_command.c                           |  5 ++++-
tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml  |  1 +
tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml  |  1 +
tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml  |  1 +
tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml  |  1 +
.../qemucapabilitiesdata/caps_2.10.0.aarch64.xml  |  1 +
tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml  |  1 +
tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml |  1 +
.../qemucapabilitiesdata/caps_2.12.0.aarch64.xml  |  1 +
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml  |  1 +
tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml |  1 +
tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml  |  1 +
tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml  |  1 +
tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml |  1 +
tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml   |  1 +
tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml  |  1 +
tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml  |  1 +
tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml  |  1 +
tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml   |  1 +
tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml  |  1 +
.../migration-in-params-in.xml                    |  1 +
.../migration-out-nbd-in.xml                      |  1 +
.../migration-out-nbd-out.xml                     |  1 +
.../migration-out-params-in.xml                   |  1 +
tests/qemustatusxml2xmldata/modern-in.xml         |  1 +
tests/qemuxml2argvdata/sound-device.args          |  2 ++
tests/qemuxml2argvdata/sound-device.xml           |  2 ++
tests/qemuxml2argvtest.c                          |  1 +
tests/qemuxml2xmloutdata/sound-device.xml         |  2 ++
36 files changed, 62 insertions(+), 5 deletions(-)
[libvirt] [PATCH v4 0/4] qemu: Add support for -device hda-output (disable line-in)
Posted by Filip Alac 5 years, 11 months ago
Add support for hda 'output' codec for ich6 and ich9 sound devices,
which allow us to disable line-in for guest.
'hda-output' codec is available since 0.14 version of qemu.

Fixes:
 https://bugzilla.redhat.com/show_bug.cgi?id=1126641

v1:
 https://www.redhat.com/archives/libvir-list/2018-May/msg01311.html

v2:
 https://www.redhat.com/archives/libvir-list/2018-May/msg01450.html
 - Split patch into series of patches
 - Add description of feature in docs/news.xml
 - Improve the documentation in docs/formatdomain.html.in
 - Fixes coding standard errors/inconsistencies

v3:
 https://www.redhat.com/archives/libvir-list/2018-May/msg01506.html
 - Moved all tests to third patch
 - Made possible to compile every patch by alone except fourth which
 depends on the first and on the second patch.

v4:
 - Moved some qemu_command and qemu_capabilities hunks from the first
 patch into second patch.

Filip Alac (4):
  conf: Introduce codec type 'output'
  tests: Extend qemu_capabilities with 'hda-output' codec
  tests: qemu: Extends tests for 'output' codec
  docs: news: Describe 'output' codec

 docs/formatdomain.html.in                         | 15 ++++++++++++---
 docs/news.xml                                     |  8 ++++++++
 docs/schemas/domaincommon.rng                     |  1 +
 src/conf/domain_conf.c                            |  3 ++-
 src/conf/domain_conf.h                            |  1 +
 src/qemu/qemu_capabilities.c                      |  2 ++
 src/qemu/qemu_capabilities.h                      |  1 +
 src/qemu/qemu_command.c                           |  5 ++++-
 tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml  |  1 +
 .../qemucapabilitiesdata/caps_2.10.0.aarch64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml |  1 +
 .../qemucapabilitiesdata/caps_2.12.0.aarch64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml |  1 +
 tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml |  1 +
 tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml   |  1 +
 tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml   |  1 +
 tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml  |  1 +
 .../migration-in-params-in.xml                    |  1 +
 .../migration-out-nbd-in.xml                      |  1 +
 .../migration-out-nbd-out.xml                     |  1 +
 .../migration-out-params-in.xml                   |  1 +
 tests/qemustatusxml2xmldata/modern-in.xml         |  1 +
 tests/qemuxml2argvdata/sound-device.args          |  2 ++
 tests/qemuxml2argvdata/sound-device.xml           |  2 ++
 tests/qemuxml2argvtest.c                          |  1 +
 tests/qemuxml2xmloutdata/sound-device.xml         |  2 ++
 36 files changed, 62 insertions(+), 5 deletions(-)

-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v4 0/4] qemu: Add support for -device hda-output (disable line-in)
Posted by Erik Skultety 5 years, 11 months ago
On Tue, May 22, 2018 at 01:12:31PM +0200, Filip Alac wrote:
> Add support for hda 'output' codec for ich6 and ich9 sound devices,
> which allow us to disable line-in for guest.
> 'hda-output' codec is available since 0.14 version of qemu.
>
> Fixes:
>  https://bugzilla.redhat.com/show_bug.cgi?id=1126641
>
> v1:
>  https://www.redhat.com/archives/libvir-list/2018-May/msg01311.html
>
> v2:
>  https://www.redhat.com/archives/libvir-list/2018-May/msg01450.html
>  - Split patch into series of patches
>  - Add description of feature in docs/news.xml
>  - Improve the documentation in docs/formatdomain.html.in
>  - Fixes coding standard errors/inconsistencies
>
> v3:
>  https://www.redhat.com/archives/libvir-list/2018-May/msg01506.html
>  - Moved all tests to third patch
>  - Made possible to compile every patch by alone except fourth which
>  depends on the first and on the second patch.
>
> v4:
>  - Moved some qemu_command and qemu_capabilities hunks from the first
>  patch into second patch.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

I tweaked the commit messages a tiny bit as well as the news feature
description and pushed the series.

Thanks,
Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list