From nobody Sat May 4 22:43:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526906461333968.8417704850918; Mon, 21 May 2018 05:41:01 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C204530BA1C3; Mon, 21 May 2018 12:40:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 71E8C1057FA2; Mon, 21 May 2018 12:40:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 229924BB78; Mon, 21 May 2018 12:40:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4LCepTK027982 for ; Mon, 21 May 2018 08:40:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id 958BB5C261; Mon, 21 May 2018 12:40:51 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-225.phx2.redhat.com [10.3.116.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id 540605C1A1 for ; Mon, 21 May 2018 12:40:51 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 21 May 2018 08:40:38 -0400 Message-Id: <20180521124045.4130-2-jferlan@redhat.com> In-Reply-To: <20180521124045.4130-1-jferlan@redhat.com> References: <20180521124045.4130-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 1/8] schema: Add physical sizing grammer for storagevol grammar X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 21 May 2018 12:41:00 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" https://bugzilla.redhat.com/show_bug.cgi?id=3D1572491 Commit id '78661cb' added a physical output, but failed to update the schema resulting in a failure from virt-xml-validate. While at it - update the storagevolschemadata for the output. Signed-off-by: John Ferlan --- docs/schemas/storagevol.rng | 5 +++++ tests/storagevolschemadata/qcow2-no-source.xml | 1 + 2 files changed, 6 insertions(+) diff --git a/docs/schemas/storagevol.rng b/docs/schemas/storagevol.rng index 7450547ffa..96d6b3e6d0 100644 --- a/docs/schemas/storagevol.rng +++ b/docs/schemas/storagevol.rng @@ -56,6 +56,11 @@ + + + + + =20 diff --git a/tests/storagevolschemadata/qcow2-no-source.xml b/tests/storage= volschemadata/qcow2-no-source.xml index 777294ec14..4958845594 100644 --- a/tests/storagevolschemadata/qcow2-no-source.xml +++ b/tests/storagevolschemadata/qcow2-no-source.xml @@ -3,6 +3,7 @@ /var/lib/libvirt/images/OtherDemo.img 5 294912 + 5 /var/lib/libvirt/images/OtherDemo.img --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 22:43:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526906457528627.4784598842454; Mon, 21 May 2018 05:40:57 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1EAD41C8FAC; Mon, 21 May 2018 12:40:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E4706277CD; Mon, 21 May 2018 12:40:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 88270180B5AA; Mon, 21 May 2018 12:40:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4LCeqls027990 for ; Mon, 21 May 2018 08:40:52 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0B81E5C261; Mon, 21 May 2018 12:40:52 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-225.phx2.redhat.com [10.3.116.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id BEC8C5C1A1 for ; Mon, 21 May 2018 12:40:51 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 21 May 2018 08:40:39 -0400 Message-Id: <20180521124045.4130-3-jferlan@redhat.com> In-Reply-To: <20180521124045.4130-1-jferlan@redhat.com> References: <20180521124045.4130-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 2/8] schema: Remove xenmigr from host migrate transport capability X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 21 May 2018 12:40:56 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Commit id '1dac5fbb' removed xenmigr as a capability option for virCapabilitiesAddHostMigrateTransport but didn't update the schema resulting in possible failure for virt-xml-validate. Signed-off-by: John Ferlan --- docs/schemas/capability.rng | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index e1ab5c2240..e11dd51150 100644 --- a/docs/schemas/capability.rng +++ b/docs/schemas/capability.rng @@ -162,7 +162,6 @@ esx tcp - xenmigr --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 22:43:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526906457469708.3529576475253; Mon, 21 May 2018 05:40:57 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2A1DF3002C99; Mon, 21 May 2018 12:40:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E20D52010CE6; Mon, 21 May 2018 12:40:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 86F411801242; Mon, 21 May 2018 12:40:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4LCeqxg027995 for ; Mon, 21 May 2018 08:40:52 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7597E5C261; Mon, 21 May 2018 12:40:52 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-225.phx2.redhat.com [10.3.116.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id 332DE5C1A1 for ; Mon, 21 May 2018 12:40:52 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 21 May 2018 08:40:40 -0400 Message-Id: <20180521124045.4130-4-jferlan@redhat.com> In-Reply-To: <20180521124045.4130-1-jferlan@redhat.com> References: <20180521124045.4130-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 3/8] schema, tests: Use vpxmigr for host migrate transport capability X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 21 May 2018 12:40:56 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Commit id 'e4938ce2f' changed the esx_driver to use 'vpxmigr' instead of esx for virCapabilitiesAddHostMigrateTransport, so update the capabilities to allow virt-xml-validate to pass and update the test to use the newer name. Signed-off-by: John Ferlan --- docs/schemas/capability.rng | 2 +- tests/vmx2xmltest.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index e11dd51150..b8e1a0e930 100644 --- a/docs/schemas/capability.rng +++ b/docs/schemas/capability.rng @@ -160,7 +160,7 @@ - esx + vpxmigr tcp diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c index 60913b6b11..7289dc91e3 100644 --- a/tests/vmx2xmltest.c +++ b/tests/vmx2xmltest.c @@ -30,7 +30,7 @@ testCapsInit(void) if (caps =3D=3D NULL) return; =20 - virCapabilitiesAddHostMigrateTransport(caps, "esx"); + virCapabilitiesAddHostMigrateTransport(caps, "vpxmigr"); =20 /* i686 guest */ guest =3D --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 22:43:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526906463078589.1779668210354; Mon, 21 May 2018 05:41:03 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9169830C1E22; Mon, 21 May 2018 12:41:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 496305D9CD; Mon, 21 May 2018 12:41:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E6EC43D381; Mon, 21 May 2018 12:41:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4LCeqDb028002 for ; Mon, 21 May 2018 08:40:52 -0400 Received: by smtp.corp.redhat.com (Postfix) id DAD615C261; Mon, 21 May 2018 12:40:52 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-225.phx2.redhat.com [10.3.116.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9CBF65C1A1 for ; Mon, 21 May 2018 12:40:52 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 21 May 2018 08:40:41 -0400 Message-Id: <20180521124045.4130-5-jferlan@redhat.com> In-Reply-To: <20180521124045.4130-1-jferlan@redhat.com> References: <20180521124045.4130-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 4/8] schema: Add rdma for host migrate transport capability X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 21 May 2018 12:41:02 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" https://bugzilla.redhat.com/show_bug.cgi?id=3D1572491 Commit id 'b3fd95e36' added rdma as a valid option for virCapabilitiesAddHostMigrateTransport, but didn't update the capabilities schema resulting in possible virt-xml-validate failure. While at it, update the capabilityschemadata for caps-qemu-kvm Signed-off-by: John Ferlan --- docs/schemas/capability.rng | 1 + tests/capabilityschemadata/caps-qemu-kvm.xml | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index b8e1a0e930..aa4823f869 100644 --- a/docs/schemas/capability.rng +++ b/docs/schemas/capability.rng @@ -162,6 +162,7 @@ vpxmigr tcp + rdma diff --git a/tests/capabilityschemadata/caps-qemu-kvm.xml b/tests/capabilit= yschemadata/caps-qemu-kvm.xml index 652061b606..88ec89e733 100644 --- a/tests/capabilityschemadata/caps-qemu-kvm.xml +++ b/tests/capabilityschemadata/caps-qemu-kvm.xml @@ -8,6 +8,7 @@ tcp + rdma --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 22:43:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526906462962247.58506729926557; Mon, 21 May 2018 05:41:02 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6F8D4C0AD404; Mon, 21 May 2018 12:41:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A37A1057FA2; Mon, 21 May 2018 12:41:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D6787180B536; Mon, 21 May 2018 12:41:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4LCerNO028007 for ; Mon, 21 May 2018 08:40:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5297A5C261; Mon, 21 May 2018 12:40:53 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-225.phx2.redhat.com [10.3.116.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id 113C35C1A1 for ; Mon, 21 May 2018 12:40:52 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 21 May 2018 08:40:42 -0400 Message-Id: <20180521124045.4130-6-jferlan@redhat.com> In-Reply-To: <20180521124045.4130-1-jferlan@redhat.com> References: <20180521124045.4130-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 5/8] schema: Add vzmigr for host migrate transport capability X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 21 May 2018 12:41:02 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Commit id '0eced74f3' added vzmigr as a valid option for virCapabilitiesAddHostMigrateTransport, but didn't update the capabilities schema resulting in possible virt-xml-validate failure. Signed-off-by: John Ferlan --- docs/schemas/capability.rng | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index aa4823f869..c532f5dcc7 100644 --- a/docs/schemas/capability.rng +++ b/docs/schemas/capability.rng @@ -163,6 +163,7 @@ vpxmigr tcp rdma + vzmigr --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 22:43:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526906469505752.3582527984992; Mon, 21 May 2018 05:41:09 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2026830BF19F; Mon, 21 May 2018 12:41:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D981E30B7791; Mon, 21 May 2018 12:41:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 81F43180B5B5; Mon, 21 May 2018 12:41:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4LCerGW028012 for ; Mon, 21 May 2018 08:40:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id BD38C5C261; Mon, 21 May 2018 12:40:53 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-225.phx2.redhat.com [10.3.116.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7D5245C1A1 for ; Mon, 21 May 2018 12:40:53 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 21 May 2018 08:40:43 -0400 Message-Id: <20180521124045.4130-7-jferlan@redhat.com> In-Reply-To: <20180521124045.4130-1-jferlan@redhat.com> References: <20180521124045.4130-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 6/8] schema: Add microcode to capability grammar X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 21 May 2018 12:41:08 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" https://bugzilla.redhat.com/show_bug.cgi?id=3D1572491 Commit id 'd2440f3b5' added printing the for the capabilities, but didn't update the capabilities schema. While at it, update capabilityschemadata for caps-test2 and caps-test3 to output some value for validation. Signed-off-by: John Ferlan --- docs/schemas/capability.rng | 7 +++++++ tests/capabilityschemadata/caps-test2.xml | 1 + tests/capabilityschemadata/caps-test3.xml | 1 + 3 files changed, 9 insertions(+) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index c532f5dcc7..e1b7858540 100644 --- a/docs/schemas/capability.rng +++ b/docs/schemas/capability.rng @@ -102,6 +102,13 @@ + + + + + + + diff --git a/tests/capabilityschemadata/caps-test2.xml b/tests/capabilitysc= hemadata/caps-test2.xml index 6a45e4569b..652fc71e0b 100644 --- a/tests/capabilityschemadata/caps-test2.xml +++ b/tests/capabilityschemadata/caps-test2.xml @@ -5,6 +5,7 @@ x86_64 SandyBridge Intel + diff --git a/tests/capabilityschemadata/caps-test3.xml b/tests/capabilitysc= hemadata/caps-test3.xml index 7e21f85048..479db30612 100644 --- a/tests/capabilityschemadata/caps-test3.xml +++ b/tests/capabilityschemadata/caps-test3.xml @@ -6,6 +6,7 @@ x86_64 Westmere Intel + --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 22:43:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15269064681213.1561770522566803; Mon, 21 May 2018 05:41:08 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 88B9514E107; Mon, 21 May 2018 12:41:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43C2D20075AC; Mon, 21 May 2018 12:41:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DA46D4BB78; Mon, 21 May 2018 12:41:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4LCesFX028017 for ; Mon, 21 May 2018 08:40:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id 31BEE5C261; Mon, 21 May 2018 12:40:54 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-225.phx2.redhat.com [10.3.116.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id E34315C1A1 for ; Mon, 21 May 2018 12:40:53 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 21 May 2018 08:40:44 -0400 Message-Id: <20180521124045.4130-8-jferlan@redhat.com> In-Reply-To: <20180521124045.4130-1-jferlan@redhat.com> References: <20180521124045.4130-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 7/8] schema: Fix capability grammar for pagesElem X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 21 May 2018 12:41:06 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" https://bugzilla.redhat.com/show_bug.cgi?id=3D1572491 Commit id '02129b7c0' added a single pagesElem for slightly different purposes. One usage was an output for host page size listing and the other for NUMA supported page sizes. For the former, only the pages unit and size are formatted, while for the latter the pages unit, size, and availability data is formatted. The virt-xml-validate would fail because it expected something extra in the host page size output. So split up pagesElem a bit and create pagesHost and pagesNuma for the differences. Modify some capabilityschemadata output to have the output - even though the results may not be realistic with respect to the original incarnation of the data. Signed-off-by: John Ferlan --- docs/schemas/capability.rng | 30 +++++++++++++++++++--------= --- tests/capabilityschemadata/caps-test2.xml | 3 +++ tests/capabilityschemadata/caps-test3.xml | 6 ++++++ 3 files changed, 28 insertions(+), 11 deletions(-) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index e1b7858540..66c5de62e5 100644 --- a/docs/schemas/capability.rng +++ b/docs/schemas/capability.rng @@ -129,7 +129,7 @@ - + =20 @@ -203,7 +203,7 @@ =20 - + =20 @@ -484,17 +484,25 @@ =20 - + - - - - - - - - + + + + + + + + + + + + + + + + diff --git a/tests/capabilityschemadata/caps-test2.xml b/tests/capabilitysc= hemadata/caps-test2.xml index 652fc71e0b..125a322998 100644 --- a/tests/capabilityschemadata/caps-test2.xml +++ b/tests/capabilityschemadata/caps-test2.xml @@ -24,6 +24,9 @@ + + + diff --git a/tests/capabilityschemadata/caps-test3.xml b/tests/capabilitysc= hemadata/caps-test3.xml index 479db30612..8294f44425 100644 --- a/tests/capabilityschemadata/caps-test3.xml +++ b/tests/capabilityschemadata/caps-test3.xml @@ -28,6 +28,9 @@ + + + @@ -42,6 +45,9 @@ 12572412 + 4011249 + 0 + 0 --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 22:43:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526906478578587.5133017577767; Mon, 21 May 2018 05:41:18 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1460919D236; Mon, 21 May 2018 12:41:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B9615600CC; Mon, 21 May 2018 12:41:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4820A3D380; Mon, 21 May 2018 12:41:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4LCesiH028022 for ; Mon, 21 May 2018 08:40:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9FBE25C261; Mon, 21 May 2018 12:40:54 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-225.phx2.redhat.com [10.3.116.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B1525C1A1 for ; Mon, 21 May 2018 12:40:54 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 21 May 2018 08:40:45 -0400 Message-Id: <20180521124045.4130-9-jferlan@redhat.com> In-Reply-To: <20180521124045.4130-1-jferlan@redhat.com> References: <20180521124045.4130-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 8/8] schema: Add missing block data for nodedev X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 21 May 2018 12:41:17 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" https://bugzilla.redhat.com/show_bug.cgi?id=3D1566416 Commit id 'fe2af45b' added output for logical_block_size and num_blocks for both removeable and fixed storage, but did not update the nodedev capability causing virt-xml-validate to fail. It's listed as optional only because it only prints if the sizes are > 0. For a CDROM drive the values won't be formatted. Update the nodedevxml2xmltest in order to output the values for storage based on the logic from udevProcessRemoveableMedia and udevProcessSD with respect to the logical_blocksize and num_blocks calculations. Signed-off-by: John Ferlan --- docs/schemas/nodedev.rng | 13 +++++++++++++ tests/nodedevschemadata/DVD_with_media.xml | 2 ++ ...ge_serial_3600c0ff000d7a2a5d463ff4902000000.xml | 2 ++ ..._serial_SATA_HTS721010G9SA00_MPCZ12Y0GNGWSE.xml | 2 ++ tests/nodedevxml2xmltest.c | 22 ++++++++++++++++++= ++++ 5 files changed, 41 insertions(+) diff --git a/docs/schemas/nodedev.rng b/docs/schemas/nodedev.rng index 6b063cc225..0498489cfd 100644 --- a/docs/schemas/nodedev.rng +++ b/docs/schemas/nodedev.rng @@ -578,6 +578,7 @@ + =20 @@ -585,6 +586,18 @@ + + + + + + + + + + + + =20 diff --git a/tests/nodedevschemadata/DVD_with_media.xml b/tests/nodedevsche= madata/DVD_with_media.xml index 673e88fd0a..f169885eb1 100644 --- a/tests/nodedevschemadata/DVD_with_media.xml +++ b/tests/nodedevschemadata/DVD_with_media.xml @@ -11,6 +11,8 @@ 1 12345678 Windows_XP_Label + 2048 + 6028 diff --git a/tests/nodedevschemadata/storage_serial_3600c0ff000d7a2a5d463ff= 4902000000.xml b/tests/nodedevschemadata/storage_serial_3600c0ff000d7a2a5d4= 63ff4902000000.xml index d225dca8fa..5bdbb8ac95 100644 --- a/tests/nodedevschemadata/storage_serial_3600c0ff000d7a2a5d463ff4902000= 000.xml +++ b/tests/nodedevschemadata/storage_serial_3600c0ff000d7a2a5d463ff4902000= 000.xml @@ -13,5 +13,7 @@ HP 3600c0ff000d7a2a5d463ff4902000000 15626928128 + 512 + 30521344 diff --git a/tests/nodedevschemadata/storage_serial_SATA_HTS721010G9SA00_MP= CZ12Y0GNGWSE.xml b/tests/nodedevschemadata/storage_serial_SATA_HTS721010G9S= A00_MPCZ12Y0GNGWSE.xml index 3595a0baaa..68dbf0be96 100644 --- a/tests/nodedevschemadata/storage_serial_SATA_HTS721010G9SA00_MPCZ12Y0G= NGWSE.xml +++ b/tests/nodedevschemadata/storage_serial_SATA_HTS721010G9SA00_MPCZ12Y0G= NGWSE.xml @@ -8,5 +8,7 @@ HTS721010G9SA00 ATA 100030242816 + 512 + 195371568 diff --git a/tests/nodedevxml2xmltest.c b/tests/nodedevxml2xmltest.c index 41ed5c01c2..207d97483e 100644 --- a/tests/nodedevxml2xmltest.c +++ b/tests/nodedevxml2xmltest.c @@ -23,6 +23,7 @@ testCompareXMLToXMLFiles(const char *xml) char *actual =3D NULL; int ret =3D -1; virNodeDeviceDefPtr dev =3D NULL; + virNodeDevCapsDefPtr caps; =20 if (virTestLoadFile(xml, &xmlData) < 0) goto fail; @@ -30,6 +31,27 @@ testCompareXMLToXMLFiles(const char *xml) if (!(dev =3D virNodeDeviceDefParseString(xmlData, EXISTING_DEVICE, NU= LL))) goto fail; =20 + /* Calculate some things that are not read in */ + for (caps =3D dev->caps; caps; caps =3D caps->next) { + virNodeDevCapDataPtr data =3D &caps->data; + + if (caps->data.type =3D=3D VIR_NODE_DEV_CAP_STORAGE) { + if (data->storage.flags & VIR_NODE_DEV_CAP_STORAGE_REMOVABLE) { + if (data->storage.flags & + VIR_NODE_DEV_CAP_STORAGE_REMOVABLE_MEDIA_AVAILABLE) { + data->storage.logical_block_size =3D 2048; + data->storage.num_blocks =3D + data->storage.removable_media_size / + data->storage.logical_block_size; + } + } else { + data->storage.logical_block_size =3D 512; + data->storage.num_blocks =3D data->storage.size / + data->storage.logical_block_siz= e; + } + } + } + if (!(actual =3D virNodeDeviceDefFormat(dev))) goto fail; =20 --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list