Add support for hda 'output' codec for ich6 and ich9 sound devices,
which allow us to disable line-in for guest.

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1126641

v1:
https://www.redhat.com/archives/libvir-list/2018-May/msg01311.html

v2:
 - Split patch into series of patches
 - Add description of feature in docs/news.xml
 - Improve the documentation in docs/formatdomain.html.in
 - Fixes coding standard errors/inconsistencies

Filip Alac (4):
  Add 'output' codec in docs, conf and xml2xmltest
  qemu: Extend qemu_capabilities with 'hda-output'
  qemu: Extend qemu_command with 'hda-output'
  docs: news: Describe the 'output' codec


 docs/formatdomain.html.in                         | 15 ++++++++++++---
 docs/news.xml                                     |  8 ++++++++
 docs/schemas/domaincommon.rng                     |  1 +
 src/conf/domain_conf.c                            |  3 ++-
 src/conf/domain_conf.h                            |  1 +
 src/qemu/qemu_capabilities.c                      |  2 ++
 src/qemu/qemu_capabilities.h                      |  1 +
 src/qemu/qemu_command.c                           |  5 ++++-
 tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml  |  1 +
 .../qemucapabilitiesdata/caps_2.10.0.aarch64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml |  1 +
 .../qemucapabilitiesdata/caps_2.12.0.aarch64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml |  1 +
 tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml |  1 +
 tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml   |  1 +
 tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml   |  1 +
 tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml  |  1 +
 .../migration-in-params-in.xml                    |  1 +
 .../migration-out-nbd-in.xml                      |  1 +
 .../migration-out-nbd-out.xml                     |  1 +
 .../migration-out-params-in.xml                   |  1 +
 tests/qemustatusxml2xmldata/modern-in.xml         |  1 +
 tests/qemuxml2argvdata/sound-device.args          |  2 ++
 tests/qemuxml2argvdata/sound-device.xml           |  2 ++
 tests/qemuxml2argvtest.c                          |  1 +
 tests/qemuxml2xmloutdata/sound-device.xml         |  2 ++
 36 files changed, 62 insertions(+), 5 deletions(-)

-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Sat, May 19, 2018 at 01:01:47PM +0200, Filip Alac wrote:
> Add support for hda 'output' codec for ich6 and ich9 sound devices,
> which allow us to disable line-in for guest.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1126641
>
> v1:
> https://www.redhat.com/archives/libvir-list/2018-May/msg01311.html
>
> v2:
>  - Split patch into series of patches

Although I agree with John, that splitting the patch added readability and
logical order since v1, you need to make sure that make check and make
syntax-check pass after every single patch, so the split with the tests he
originally suggested couldn't have worked sadly because of how our test suite
works, see my responses to individual patches.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list