projects: set TEST_MAINTAINER for libvirt-perl build job too

[libvirt] [jenkins-ci PATCH] projects: set TEST_MAINTAINER for libvirt-perl build job too

Posted by Daniel P. Berrangé 5 years, 11 months ago

The TEST_MAINTAINER=1 env variable will effect running of Build.PL,
causing it to turn on many more GCC warning flags to validate the
build. So we need to set it for build job as well as test job.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 projects/libvirt-perl.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/projects/libvirt-perl.yaml b/projects/libvirt-perl.yaml
index 5cbe04c..28288e8 100644
--- a/projects/libvirt-perl.yaml
+++ b/projects/libvirt-perl.yaml
@@ -6,6 +6,8 @@
     jobs:
       - perl-modulebuild-build-job:
           parent_jobs: 'libvirt-master-build'
+          local_env: |
+            export TEST_MAINTAINER=1
       - perl-modulebuild-check-job:
           parent_jobs: 'libvirt-perl-master-build'
           local_env: |
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] projects: set TEST_MAINTAINER for libvirt-perl build job too

Posted by Andrea Bolognani 5 years, 11 months ago

On Thu, 2018-05-17 at 12:46 +0100, Daniel P. Berrangé wrote:
> The TEST_MAINTAINER=1 env variable will effect running of Build.PL,
> causing it to turn on many more GCC warning flags to validate the
> build. So we need to set it for build job as well as test job.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  projects/libvirt-perl.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/projects/libvirt-perl.yaml b/projects/libvirt-perl.yaml
> index 5cbe04c..28288e8 100644
> --- a/projects/libvirt-perl.yaml
> +++ b/projects/libvirt-perl.yaml
> @@ -6,6 +6,8 @@
>      jobs:
>        - perl-modulebuild-build-job:
>            parent_jobs: 'libvirt-master-build'
> +          local_env: |
> +            export TEST_MAINTAINER=1
>        - perl-modulebuild-check-job:
>            parent_jobs: 'libvirt-perl-master-build'
>            local_env: |

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list