[v2] Enable out-of-the-box parallel make

[libvirt] [jenkins-ci PATCH v2 0/3] Enable out-of-the-box parallel make

Posted by Andrea Bolognani 5 years, 11 months ago

Changes from [v1]:

* turns out some versions of ExtUtils::MakeMaker output Makefiles
  that are not entirely compatible with parallel make, which forces
  us to introduce an exception in the relevant template and shuffle
  patches around.

[v1] https://www.redhat.com/archives/libvir-list/2018-May/msg00732.html

Andrea Bolognani (3):
  jobs: Enable parallel make everywhere
  jobs: Drop explicit parallel make usage
  guests: Set MAKEFLAGS for out-of-the-box parallel make

 guests/templates/bashrc  |  2 ++
 jobs/autotools.yaml      | 10 +++++-----
 jobs/defaults.yaml       |  1 -
 jobs/perl-makemaker.yaml | 12 +++++++-----
 projects/libvirt.yaml    |  4 ++--
 projects/osinfo-db.yaml  |  4 ++--
 6 files changed, 18 insertions(+), 15 deletions(-)

-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH v2 0/3] Enable out-of-the-box parallel make

Posted by Daniel P. Berrangé 5 years, 11 months ago

On Tue, May 15, 2018 at 03:23:21PM +0200, Andrea Bolognani wrote:
> Changes from [v1]:
> 
> * turns out some versions of ExtUtils::MakeMaker output Makefiles
>   that are not entirely compatible with parallel make, which forces
>   us to introduce an exception in the relevant template and shuffle
>   patches around.

Oh, if that's a problem I'll happily drop use of MakeMaker in favour
of Module::Build. Looks like it is only the core libvirt perl binding
that actually still uses MakeMaker.

> 
> [v1] https://www.redhat.com/archives/libvir-list/2018-May/msg00732.html
> 
> Andrea Bolognani (3):
>   jobs: Enable parallel make everywhere
>   jobs: Drop explicit parallel make usage
>   guests: Set MAKEFLAGS for out-of-the-box parallel make
> 
>  guests/templates/bashrc  |  2 ++
>  jobs/autotools.yaml      | 10 +++++-----
>  jobs/defaults.yaml       |  1 -
>  jobs/perl-makemaker.yaml | 12 +++++++-----
>  projects/libvirt.yaml    |  4 ++--
>  projects/osinfo-db.yaml  |  4 ++--
>  6 files changed, 18 insertions(+), 15 deletions(-)
> 
> -- 
> 2.17.0
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH v2 0/3] Enable out-of-the-box parallel make

Posted by Andrea Bolognani 5 years, 11 months ago

On Tue, 2018-05-15 at 14:31 +0100, Daniel P. Berrangé wrote:
> On Tue, May 15, 2018 at 03:23:21PM +0200, Andrea Bolognani wrote:
> > Changes from [v1]:
> > 
> > * turns out some versions of ExtUtils::MakeMaker output Makefiles
> >   that are not entirely compatible with parallel make, which forces
> >   us to introduce an exception in the relevant template and shuffle
> >   patches around.
> 
> Oh, if that's a problem I'll happily drop use of MakeMaker in favour
> of Module::Build. Looks like it is only the core libvirt perl binding
> that actually still uses MakeMaker.

Standardizing on a single build system for Perl sounds great :)

Once you've done that, we can use v1 unchanged; or we can push v2
now and remove the tiny hack after you've switched libvirt-perl to
Module::Build. Either one is fine with me.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list