util: fix misleading command for virObjectLock

[libvirt] [PATCH] util: fix misleading command for virObjectLock

Daniel P. Berrangé posted 1 patch 5 years, 11 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180515111349.30679-1-berrange@redhat.com

Test syntax-check passed

src/util/virobject.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] util: fix misleading command for virObjectLock

Posted by Daniel P. Berrangé 5 years, 11 months ago

It only accepts a virObjecLockable, not a virObjecRWLockable

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/util/virobject.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virobject.c b/src/util/virobject.c
index 9fb0328d58..a597ff4f54 100644
--- a/src/util/virobject.c
+++ b/src/util/virobject.c
@@ -408,7 +408,7 @@ virObjectGetRWLockableObj(void *anyobj)
 
 /**
  * virObjectLock:
- * @anyobj: any instance of virObjectLockable or virObjectRWLockable
+ * @anyobj: any instance of virObjectLockable
  *
  * Acquire a lock on @anyobj. The lock must be released by
  * virObjectUnlock.
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util: fix misleading command for virObjectLock

Posted by Jiri Denemark 5 years, 11 months ago

On Tue, May 15, 2018 at 12:13:49 +0100, Daniel P. Berrangé wrote:
> It only accepts a virObjecLockable, not a virObjecRWLockable
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/util/virobject.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

After s/command/comment/ in Subject

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list