connect: Remove unused variable

[libvirt] [dbus PATCH] connect: Remove unused variable

Posted by Andrea Bolognani 5 years, 11 months ago

Clang catches the issue:

  ../../src/connect.c:532:26: error: unused variable 'domain' [-Werror,-Wunused-variable]
      g_autoptr(virDomain) domain = NULL;
                           ^

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/connect.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/connect.c b/src/connect.c
index 6719e21..14a60dc 100644
--- a/src/connect.c
+++ b/src/connect.c
@@ -529,7 +529,6 @@ virtDBusConnectDomainSaveImageGetXMLDesc(GVariant *inArgs,
                                          GError **error)
 {
     virtDBusConnect *connect = userData;
-    g_autoptr(virDomain) domain = NULL;
     const gchar *file;
     guint flags;
     g_autofree gchar *xml = NULL;
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH] connect: Remove unused variable

Posted by Ján Tomko 5 years, 11 months ago

On Mon, May 14, 2018 at 09:13:19AM +0200, Andrea Bolognani wrote:
>Clang catches the issue:
>
>  ../../src/connect.c:532:26: error: unused variable 'domain' [-Werror,-Wunused-variable]
>      g_autoptr(virDomain) domain = NULL;
>                           ^
>
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
> src/connect.c | 1 -
> 1 file changed, 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list