Finish replacements for virDomainObjCheckActive

[libvirt] [PATCH 0/3] Finish replacements for virDomainObjCheckActive

clem@lse.epita.fr posted 3 patches 5 years, 11 months ago

Download series mbox

Failed in applying to current master (apply log)

Test syntax-check passed

src/bhyve/bhyve_driver.c  |  15 +--
src/lxc/lxc_driver.c      |  65 ++-------
src/qemu/qemu_domain.c    |   5 +-
src/qemu/qemu_driver.c    | 271 ++++++++------------------------------
src/qemu/qemu_migration.c |  10 +-
5 files changed, 74 insertions(+), 292 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/3] Finish replacements for virDomainObjCheckActive

Posted by clem@lse.epita.fr 5 years, 11 months ago

From: Clementine Hayat <clem@lse.epita.fr>

Follow-up of https://www.redhat.com/archives/libvir-list/2018-April/msg01591.html

Here is the changes asked by Ján Tomko:
* Refactor also checks when the error message is close to "domain is not
  running"
* Add forgotten checks in qemu_migration.c
* Revert one incorrect change in lxc_driver.c

Clementine Hayat (3):
  qemu: start using virDomainObjCheckActive
  lxc: start using virDomainObjCheckActive
  bhyve: start using virDomainObjCheckActive

 src/bhyve/bhyve_driver.c  |  15 +--
 src/lxc/lxc_driver.c      |  65 ++-------
 src/qemu/qemu_domain.c    |   5 +-
 src/qemu/qemu_driver.c    | 271 ++++++++------------------------------
 src/qemu/qemu_migration.c |  10 +-
 5 files changed, 74 insertions(+), 292 deletions(-)

-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] Finish replacements for virDomainObjCheckActive

Posted by Ján Tomko 5 years, 11 months ago

On Mon, May 14, 2018 at 12:32:12AM +0200, clem@lse.epita.fr wrote:
>From: Clementine Hayat <clem@lse.epita.fr>
>
>Follow-up of https://www.redhat.com/archives/libvir-list/2018-April/msg01591.html
>
>Here is the changes asked by Ján Tomko:
>* Refactor also checks when the error message is close to "domain is not
>  running"
>* Add forgotten checks in qemu_migration.c
>* Revert one incorrect change in lxc_driver.c
>
>Clementine Hayat (3):
>  qemu: start using virDomainObjCheckActive
>  lxc: start using virDomainObjCheckActive
>  bhyve: start using virDomainObjCheckActive
>
> src/bhyve/bhyve_driver.c  |  15 +--
> src/lxc/lxc_driver.c      |  65 ++-------
> src/qemu/qemu_domain.c    |   5 +-
> src/qemu/qemu_driver.c    | 271 ++++++++------------------------------
> src/qemu/qemu_migration.c |  10 +-
> 5 files changed, 74 insertions(+), 292 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com>

And pushed.

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list