[libvirt] [PATCH v2 00/12] Some fixes and improvement for virsh completion in non interactive mode

Lin Ma posted 12 patches 5 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180508142040.18593-1-lma@suse.com
Test syntax-check passed
tools/virsh-completer.c      |  37 ++++++++++++
tools/virsh-completer.h      |   3 +
tools/virsh-domain-monitor.c |   9 +--
tools/virsh-domain.c         | 135 ++++++++++++++++++++-----------------------
tools/virsh-snapshot.c       |   3 -
tools/virsh-util.c           |  60 +++++++++++++++++++
tools/virsh-util.h           |   3 +
tools/virsh.h                |  26 +++++++++
tools/vsh.c                  |  12 +++-
9 files changed, 203 insertions(+), 85 deletions(-)
[libvirt] [PATCH v2 00/12] Some fixes and improvement for virsh completion in non interactive mode
Posted by Lin Ma 5 years, 10 months ago
This patch series is about some fixes and improvement for virsh completion
in non interactive mode.

Some of them probably don't make sense, I sent them out for suggestions.

v2->v1:
* Add a new patch for centralize the definition of macro VIRSH_COMMON_OPT_DOMAIN_FULL to virsh.h

* rename the helper function from virDomainEventGetName virshDomainEventGetName
Follow Peter Krempa's suggestion:

* Drop the original patch#10 which about introduce some VIR_DOMAIN_EVENT_* macros

* code formatting fix

* centralize the definition of macro VIRSH_COMMON_OPT_DOMAIN_OT_STRING_FULL

* centralize the definition of macro VIRSH_COMMON_OPT_DOMAIN_OT_ARGV_FULL

* refactor some code in patch#10 for using same array, handle the case when
'--event' and '--all' are provided together through command line.

* Due to the helper function is only used for virsh, unnecessary to be publiced,
I move it from src/conf/domain_event.c to tools/virsh-util.c



Lin Ma (12):
  virsh: Move the definition of macro VIRSH_COMMON_OPT_DOMAIN_FULL to
    virsh.h
  virsh: Add domain name completion to 'migrate-postcopy' command
  virsh: Conditionally Ignore the first entry in list of completions
  virsh: Create macros for VSH_OT_STRING "domain" option
  virsh: Apply macro for current VSH_OT_STRING "domain" options
  vshReadlineParse: Ignore vshReadlineOptionsGenerator for VSH_OT_ARGV
    options
  virsh: Create macros for VSH_OT_ARGV "domain" option
  virsh: Apply macro for current VSH_OT_ARGV "domain" options
  vshReadlineOptionsGenerator: Add already provided VSH_OT_ARGV options
    to list
  virsh: Enable multiple --event flags to 'event' command
  virsh: add helper for returning event name string
  virsh: Add event name completion to 'event' command

 tools/virsh-completer.c      |  37 ++++++++++++
 tools/virsh-completer.h      |   3 +
 tools/virsh-domain-monitor.c |   9 +--
 tools/virsh-domain.c         | 135 ++++++++++++++++++++-----------------------
 tools/virsh-snapshot.c       |   3 -
 tools/virsh-util.c           |  60 +++++++++++++++++++
 tools/virsh-util.h           |   3 +
 tools/virsh.h                |  26 +++++++++
 tools/vsh.c                  |  12 +++-
 9 files changed, 203 insertions(+), 85 deletions(-)

-- 
2.15.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 00/12] Some fixes and improvement for virsh completion in non interactive mode
Posted by Michal Privoznik 5 years, 10 months ago
On 05/08/2018 04:20 PM, Lin Ma wrote:
> This patch series is about some fixes and improvement for virsh completion
> in non interactive mode.

I've ACKed patches 01-09/12 (after fixing some of them), and pushed
them. Patch 10/12 is no go I fear, patch 11/12 needs some rework and
finally patch 12/12 is okay, but relies on previous patch, so I can't
push it.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list