[libvirt] [dbus PATCH] "foo* [bar]" should be "foo *[bar]"

Katerina Koukiou posted 1 patch 5 years, 11 months ago
Failed in applying to current master (apply log)
src/connect.c | 6 +++---
src/domain.c  | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
[libvirt] [dbus PATCH] "foo* [bar]" should be "foo *[bar]"
Posted by Katerina Koukiou 5 years, 11 months ago
Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
---
We forgot to include this in the last code style fixes.

 src/connect.c | 6 +++---
 src/domain.c  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/connect.c b/src/connect.c
index fd335e3..1c87bf2 100644
--- a/src/connect.c
+++ b/src/connect.c
@@ -227,7 +227,7 @@ virtDBusConnectBaselineCPU(GVariant *inArgs,
 
     ncpus = g_variant_iter_n_children(iter);
     if (ncpus > 0) {
-        xmlCPUs = g_new0(const gchar*, ncpus);
+        xmlCPUs = g_new0(const gchar *, ncpus);
         tmp = xmlCPUs;
         while (g_variant_iter_next(iter, "&s", tmp))
             tmp++;
@@ -517,7 +517,7 @@ virtDBusConnectGetAllDomainStats(GVariant *inArgs,
     g_variant_builder_init(&builder, G_VARIANT_TYPE("a(sa{sv})"));
 
     for (gint i = 0; i < nstats; i++) {
-        const gchar* name;
+        const gchar *name;
         GVariant *grecords;
 
         g_variant_builder_open(&builder, G_VARIANT_TYPE("(sa{sv})"));
@@ -582,7 +582,7 @@ virtDBusConnectGetDomainCapabilities(GVariant *inArgs,
     const gchar *machine;
     const gchar *virttype;
     guint flags;
-    g_autofree gchar* domCapabilities = NULL;
+    g_autofree gchar *domCapabilities = NULL;
 
     g_variant_get(inArgs, "(&s&s&s&su)", &emulatorbin, &arch, &machine,
                   &virttype, &flags);
diff --git a/src/domain.c b/src/domain.c
index 2ba58e0..3127f6c 100644
--- a/src/domain.c
+++ b/src/domain.c
@@ -118,7 +118,7 @@ virtDBusDomainGVariantToMountpoints(GVariantIter *iter,
 
     *nmountpoints = g_variant_iter_n_children(iter);
     if (*nmountpoints > 0) {
-        *mountpoints = g_new0(const gchar*, *nmountpoints);
+        *mountpoints = g_new0(const gchar *, *nmountpoints);
         tmp = *mountpoints;
         while (g_variant_iter_next(iter, "&s", tmp))
             tmp++;
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH] "foo* [bar]" should be "foo *[bar]"
Posted by Pavel Hrdina 5 years, 11 months ago
On Mon, May 07, 2018 at 04:00:12PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
> ---
> We forgot to include this in the last code style fixes.
> 
>  src/connect.c | 6 +++---
>  src/domain.c  | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list