projects: Run libvirt's 'make check' on all machines

[libvirt] [jenkins-ci PATCH] projects: Run libvirt's 'make check' on all machines

Posted by Andrea Bolognani 5 years, 11 months ago

Up until now, we had to skip it on FreeBSD due to some
portability issues in the test suite, but as of libvirt
commit 0b86e23d2569 they've all been fixed.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 projects/libvirt.yaml | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/projects/libvirt.yaml b/projects/libvirt.yaml
index 9b9b0b4..6f5464b 100644
--- a/projects/libvirt.yaml
+++ b/projects/libvirt.yaml
@@ -18,13 +18,6 @@
             - libvirt-fedora-rawhide
       - autotools-check-job:
           parent_jobs: 'libvirt-master-syntax-check'
-          machines:
-            - libvirt-centos-7
-            - libvirt-debian-8
-            - libvirt-debian-9
-            - libvirt-fedora-27
-            - libvirt-fedora-28
-            - libvirt-fedora-rawhide
           local_env: |
             export VIR_TEST_EXPENSIVE=1
             export VIR_TEST_DEBUG=2
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] projects: Run libvirt's 'make check' on all machines

Posted by Daniel P. Berrangé 5 years, 11 months ago

On Thu, May 03, 2018 at 06:25:19PM +0200, Andrea Bolognani wrote:
> Up until now, we had to skip it on FreeBSD due to some
> portability issues in the test suite, but as of libvirt
> commit 0b86e23d2569 they've all been fixed.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  projects/libvirt.yaml | 7 -------
>  1 file changed, 7 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] projects: Run libvirt's 'make check' on all machines

Posted by Daniel P. Berrangé 5 years, 11 months ago

On Thu, May 03, 2018 at 06:25:19PM +0200, Andrea Bolognani wrote:
> Up until now, we had to skip it on FreeBSD due to some
> portability issues in the test suite, but as of libvirt
> commit 0b86e23d2569 they've all been fixed.

Unfortunately it appears that gnulib has a non-deterministic failure
in test-poll that hits on FreeBSD 10 and 11 :-(

> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  projects/libvirt.yaml | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/projects/libvirt.yaml b/projects/libvirt.yaml
> index 9b9b0b4..6f5464b 100644
> --- a/projects/libvirt.yaml
> +++ b/projects/libvirt.yaml
> @@ -18,13 +18,6 @@
>              - libvirt-fedora-rawhide
>        - autotools-check-job:
>            parent_jobs: 'libvirt-master-syntax-check'
> -          machines:
> -            - libvirt-centos-7
> -            - libvirt-debian-8
> -            - libvirt-debian-9
> -            - libvirt-fedora-27
> -            - libvirt-fedora-28
> -            - libvirt-fedora-rawhide
>            local_env: |
>              export VIR_TEST_EXPENSIVE=1
>              export VIR_TEST_DEBUG=2
> -- 
> 2.14.3
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] projects: Run libvirt's 'make check' on all machines

Posted by Andrea Bolognani 5 years, 11 months ago

On Tue, 2018-05-08 at 16:15 +0100, Daniel P. Berrangé wrote:
> On Thu, May 03, 2018 at 06:25:19PM +0200, Andrea Bolognani wrote:
> > Up until now, we had to skip it on FreeBSD due to some
> > portability issues in the test suite, but as of libvirt
> > commit 0b86e23d2569 they've all been fixed.
> 
> Unfortunately it appears that gnulib has a non-deterministic failure
> in test-poll that hits on FreeBSD 10 and 11 :-(

Yeah, I have already notified upstream[1]... And I see now you
have as well[2] :)

Hopefully a fix will be available soon.


[1] http://lists.gnu.org/archive/html/bug-gnulib/2018-05/msg00045.html
[2] http://lists.gnu.org/archive/html/bug-gnulib/2018-05/msg00059.html
-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list