[v1] maint: Drop autobuild.sh

[libvirt] [tck PATCH] maint: Drop autobuild.sh

Posted by Andrea Bolognani 5 years, 11 months ago

The Test-AutoBuild project, that this script is supposed
to be used with, hasn't seen any activity in ~7 years;
these days, libvirt-tck CI builds are happening on the
Jenkins-based CentOS CI environment under the libvirt
umbrella[1], and in that context the script is not used
at all.

[1] https://ci.centos.org/view/libvirt/

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 autobuild.sh | 59 -----------------------------------------------------------
 1 file changed, 59 deletions(-)
 delete mode 100755 autobuild.sh

diff --git a/autobuild.sh b/autobuild.sh
deleted file mode 100755
index 005993d..0000000
--- a/autobuild.sh
+++ /dev/null
@@ -1,59 +0,0 @@
-#!/bin/sh
-#
-# This script is used to Test::AutoBuild (http://www.autobuild.org)
-# to perform automated builds of the Sys-Virt module
-#
-# Copyright (C) 2009 Red Hat, Inc.
-# Copyright (C) 2009 Daniel P. Berrange
-#
-# This program is free software; You can redistribute it and/or modify
-# it under the GNU General Public License as published by the Free
-# Software Foundation; either version 2, or (at your option) any
-# later version
-#
-# The file "LICENSE" distributed along with this file provides full
-# details of the terms and conditions
-#
-
-NAME=Sys-Virt-TCK
-
-set -e
-
-rm -rf MANIFEST blib _build Build
-
-test -z "$AUTOBUILD_INSTALL_ROOT" && AUTOBUILD_INSTALL_ROOT=$HOME/builder
-
-perl Build.PL install_base=$AUTOBUILD_INSTALL_ROOT
-
-./Build
-./Build manifest
-
-
-if [ -z "$USE_COVER" ]; then
-  perl -MDevel::Cover -e '' 1>/dev/null 2>&1 && USE_COVER=1 || USE_COVER=0
-fi
-
-if [ -z "$SKIP_TESTS" -o "$SKIP_TESTS" = "0" ]; then
-  if [ "$USE_COVER" = "1" ]; then
-    ./Build test
-  else
-    ./Build test
-  fi
-fi
-
-./Build install
-
-rm -f $NAME-*.tar.gz
-./Build dist
-
-if [ -f /usr/bin/rpmbuild ]; then
-  if [ -n "$AUTOBUILD_COUNTER" ]; then
-    EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER"
-  else
-    NOW=`date +"%s"`
-    EXTRA_RELEASE=".$USER$NOW"
-  fi
-  rpmbuild -ta --define "extra_release $EXTRA_RELEASE" --clean $NAME-*.tar.gz
-fi
-
-exit 0
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [tck PATCH] maint: Drop autobuild.sh

Posted by Daniel P. Berrangé 5 years, 11 months ago

On Thu, May 03, 2018 at 05:42:27PM +0200, Andrea Bolognani wrote:
> The Test-AutoBuild project, that this script is supposed
> to be used with, hasn't seen any activity in ~7 years;
> these days, libvirt-tck CI builds are happening on the
> Jenkins-based CentOS CI environment under the libvirt
> umbrella[1], and in that context the script is not used
> at all.
> 
> [1] https://ci.centos.org/view/libvirt/
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  autobuild.sh | 59 -----------------------------------------------------------
>  1 file changed, 59 deletions(-)
>  delete mode 100755 autobuild.sh

I used this one for cutting releases too.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [tck PATCH] maint: Drop autobuild.sh

Posted by Laine Stump 5 years, 11 months ago

On 05/03/2018 11:47 AM, Daniel P. Berrangé wrote:
> On Thu, May 03, 2018 at 05:42:27PM +0200, Andrea Bolognani wrote:
>> The Test-AutoBuild project, that this script is supposed
>> to be used with, hasn't seen any activity in ~7 years;
>> these days, libvirt-tck CI builds are happening on the
>> Jenkins-based CentOS CI environment under the libvirt
>> umbrella[1], and in that context the script is not used
>> at all.
>>
>> [1] https://ci.centos.org/view/libvirt/
>>
>> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>> ---
>>  autobuild.sh | 59 -----------------------------------------------------------
>>  1 file changed, 59 deletions(-)
>>  delete mode 100755 autobuild.sh
> I used this one for cutting releases too.

And it's the only way I know how to build it for testing. Please don't
move my cheese! :-)

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [tck PATCH] maint: Drop autobuild.sh

Posted by Andrea Bolognani 5 years, 11 months ago

On Mon, 2018-05-07 at 10:25 -0400, Laine Stump wrote:
> On 05/03/2018 11:47 AM, Daniel P. Berrangé wrote:
> > On Thu, May 03, 2018 at 05:42:27PM +0200, Andrea Bolognani wrote:
> > > The Test-AutoBuild project, that this script is supposed
> > > to be used with, hasn't seen any activity in ~7 years;
> > > these days, libvirt-tck CI builds are happening on the
> > > Jenkins-based CentOS CI environment under the libvirt
> > > umbrella[1], and in that context the script is not used
> > > at all.
> > > 
> > > [1] https://ci.centos.org/view/libvirt/
> > > 
> > > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> > > ---
> > >  autobuild.sh | 59 -----------------------------------------------------------
> > >  1 file changed, 59 deletions(-)
> > >  delete mode 100755 autobuild.sh
> > 
> > I used this one for cutting releases too.
> 
> And it's the only way I know how to build it for testing. Please don't
> move my cheese! :-)

I posted a [v2] that renames the script rather than dropping it:
patches that implement the same approach in libvirt-perl have
already been merged, while patches for virt-viewer, libvirt-tck,
libvirt-sandbox, libosinfo and osinfo-db are on the respective
mailing lists waiting for review.


[v2] https://www.redhat.com/archives/libvir-list/2018-May/msg00341.html
-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list