[libvirt] [PATCH] remote: remove obsolete & incorrect comment from libvirtd.conf

Daniel P. Berrangé posted 1 patch 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180420113419.6227-1-berrange@redhat.com
Test syntax-check passed
src/remote/libvirtd.conf | 5 -----
1 file changed, 5 deletions(-)
[libvirt] [PATCH] remote: remove obsolete & incorrect comment from libvirtd.conf
Posted by Daniel P. Berrangé 6 years ago
The libvirtd.conf file has a comment pointing people to format.html
which has nothing todo with the configuration file format.

It also has a comment about tests/daemon-conf which no longer exists,
and even if it did exist such comment is not relevant to end users
when this file is installed in /etc/.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/remote/libvirtd.conf | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/remote/libvirtd.conf b/src/remote/libvirtd.conf
index 7d823cf1ad..28df4021aa 100644
--- a/src/remote/libvirtd.conf
+++ b/src/remote/libvirtd.conf
@@ -1,10 +1,5 @@
 # Master libvirt daemon configuration file
 #
-# For further information consult https://libvirt.org/format.html
-#
-# NOTE: the tests/daemon-conf regression test script requires
-# that each "PARAMETER = VALUE" line in this file have the parameter
-# name just after a leading "#".
 
 #################################################################
 #
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] remote: remove obsolete & incorrect comment from libvirtd.conf
Posted by Andrea Bolognani 6 years ago
On Fri, 2018-04-20 at 12:34 +0100, Daniel P. Berrangé wrote:
> The libvirtd.conf file has a comment pointing people to format.html
> which has nothing todo with the configuration file format.

s/todo/to do/

> It also has a comment about tests/daemon-conf which no longer exists,
> and even if it did exist such comment is not relevant to end users
> when this file is installed in /etc/.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/remote/libvirtd.conf | 5 -----

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list