tests: Fix incorrect check for virNetServerClientClose call

[libvirt] [PATCH] tests: Fix incorrect check for virNetServerClientClose call

John Ferlan posted 1 patch 6 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180419191115.16047-1-jferlan@redhat.com

Test syntax-check passed

tests/virnetserverclienttest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] tests: Fix incorrect check for virNetServerClientClose call

Posted by John Ferlan 6 years ago

Commit id '6df5d777' somehow during the move from one branch to
another added an erroneous '!'...

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

 Pushing under the trivial rule.

  Not quite sure how a git am from my Coverity tree added the not in the
  condition.
  
 tests/virnetserverclienttest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/virnetserverclienttest.c b/tests/virnetserverclienttest.c
index aa3f0bcf9b..1759d76630 100644
--- a/tests/virnetserverclienttest.c
+++ b/tests/virnetserverclienttest.c
@@ -152,7 +152,7 @@ static int testIdentity(const void *opaque ATTRIBUTE_UNUSED)
     ret = 0;
  cleanup:
     virObjectUnref(sock);
-    if (!client)
+    if (client)
         virNetServerClientClose(client);
     virObjectUnref(client);
     virObjectUnref(ident);
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list