vmx: start reading/writing CPU topology

[libvirt] [PATCH 0/2] vmx: start reading/writing CPU topology

Pino Toscano posted 2 patches 6 years ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180419130338.10314-1-ptoscano@redhat.com

Test syntax-check passed

src/vmx/vmx.c                                   | 57 ++++++++++++++++++++
tests/vmx2xmldata/vmx2xml-esx-in-the-wild-8.xml |  3 ++
tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.vmx | 72 +++++++++++++++++++++++++
tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.xml | 37 +++++++++++++
tests/vmx2xmltest.c                             |  1 +
tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.vmx | 39 ++++++++++++++
tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.xml | 37 +++++++++++++
tests/xml2vmxtest.c                             |  1 +
8 files changed, 247 insertions(+)
create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.vmx
create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.xml
create mode 100644 tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.vmx
create mode 100644 tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.xml

Expand all Fold all

[libvirt] [PATCH 0/2] vmx: start reading/writing CPU topology

Posted by Pino Toscano 6 years ago

Read/write only cpuid.coresPerSocket for now.

Pino Toscano (2):
  vmx: convert cpuid.coresPerSocket for CPU topology
  vmx: write cpuid.coresPerSocket back from CPU topology

 src/vmx/vmx.c                                   | 57 ++++++++++++++++++++
 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-8.xml |  3 ++
 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.vmx | 72 +++++++++++++++++++++++++
 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.xml | 37 +++++++++++++
 tests/vmx2xmltest.c                             |  1 +
 tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.vmx | 39 ++++++++++++++
 tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.xml | 37 +++++++++++++
 tests/xml2vmxtest.c                             |  1 +
 8 files changed, 247 insertions(+)
 create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.vmx
 create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.xml
 create mode 100644 tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.vmx
 create mode 100644 tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.xml

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] vmx: start reading/writing CPU topology

Posted by Richard W.M. Jones 6 years ago

On Thu, Apr 19, 2018 at 03:03:36PM +0200, Pino Toscano wrote:
> Read/write only cpuid.coresPerSocket for now.
> 
> Pino Toscano (2):
>   vmx: convert cpuid.coresPerSocket for CPU topology
>   vmx: write cpuid.coresPerSocket back from CPU topology
> 
>  src/vmx/vmx.c                                   | 57 ++++++++++++++++++++
>  tests/vmx2xmldata/vmx2xml-esx-in-the-wild-8.xml |  3 ++
>  tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.vmx | 72 +++++++++++++++++++++++++
>  tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.xml | 37 +++++++++++++
>  tests/vmx2xmltest.c                             |  1 +
>  tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.vmx | 39 ++++++++++++++
>  tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.xml | 37 +++++++++++++
>  tests/xml2vmxtest.c                             |  1 +
>  8 files changed, 247 insertions(+)
>  create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.vmx
>  create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.xml
>  create mode 100644 tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.vmx
>  create mode 100644 tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.xml

The code and tests look fine to me, so ACK here.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] vmx: start reading/writing CPU topology

Posted by Ján Tomko 6 years ago

On Thu, Apr 19, 2018 at 03:03:36PM +0200, Pino Toscano wrote:
>Read/write only cpuid.coresPerSocket for now.
>
>Pino Toscano (2):
>  vmx: convert cpuid.coresPerSocket for CPU topology
>  vmx: write cpuid.coresPerSocket back from CPU topology
>
> src/vmx/vmx.c                                   | 57 ++++++++++++++++++++
> tests/vmx2xmldata/vmx2xml-esx-in-the-wild-8.xml |  3 ++
> tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.vmx | 72 +++++++++++++++++++++++++
> tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.xml | 37 +++++++++++++
> tests/vmx2xmltest.c                             |  1 +
> tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.vmx | 39 ++++++++++++++
> tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.xml | 37 +++++++++++++
> tests/xml2vmxtest.c                             |  1 +
> 8 files changed, 247 insertions(+)
> create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.vmx
> create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-9.xml
> create mode 100644 tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.vmx
> create mode 100644 tests/xml2vmxdata/xml2vmx-esx-in-the-wild-9.xml
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

and pushed

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list