From nobody Sat Apr 27 15:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1523863236383929.8950575055338; Mon, 16 Apr 2018 00:20:36 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A02D81FF118; Mon, 16 Apr 2018 07:20:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6F0FB6090B; Mon, 16 Apr 2018 07:20:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 190F0180215E; Mon, 16 Apr 2018 07:20:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3G7KXsP027410 for ; Mon, 16 Apr 2018 03:20:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id 242C4215CDCB; Mon, 16 Apr 2018 07:20:33 +0000 (UTC) Received: from katerina.brq.redhat.com (unknown [10.43.2.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id BC047215CDC8 for ; Mon, 16 Apr 2018 07:20:32 +0000 (UTC) From: Katerina Koukiou To: libvir-list@redhat.com Date: Mon, 16 Apr 2018 09:20:30 +0200 Message-Id: <20180416072030.24497-1-kkoukiou@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH] tests: Avoid hidding TimeoutError in main loop X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 16 Apr 2018 07:20:35 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Currently the error was not propagated from the timeout handler properly, and we had PASSED tests even with timeouts. Signed-off-by: Katerina Koukiou Reviewed-by: J=EF=BF=BDn Tomko --- test/libvirttest.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/libvirttest.py b/test/libvirttest.py index 7168e66..d1b71cc 100644 --- a/test/libvirttest.py +++ b/test/libvirttest.py @@ -60,11 +60,14 @@ class BaseTestClass(): def timeout(): self.loop.quit() del self.loop - raise TimeoutError() + self.timeout =3D True =20 + self.timeout =3D False self.loop =3D GLib.MainLoop() GLib.timeout_add(2000, timeout) self.loop.run() + if self.timeout: + raise TimeoutError() =20 def domain(self): path =3D self.connect.ListDomains(0)[0] --=20 2.15.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list