From nobody Thu Apr 25 10:23:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 152380624983760.30825138595708; Sun, 15 Apr 2018 08:30:49 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1431E312FF6E; Sun, 15 Apr 2018 15:30:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 600785C1A1; Sun, 15 Apr 2018 15:30:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F3C5F4CA99; Sun, 15 Apr 2018 15:30:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3FFUZuL012540 for ; Sun, 15 Apr 2018 11:30:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2C80878DD7; Sun, 15 Apr 2018 15:30:35 +0000 (UTC) Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 24CC680F9C for ; Sun, 15 Apr 2018 15:30:32 +0000 (UTC) Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C97ED5F798 for ; Sun, 15 Apr 2018 15:30:21 +0000 (UTC) Received: by mail-wr0-f194.google.com with SMTP id l49so19378278wrl.4 for ; Sun, 15 Apr 2018 08:30:21 -0700 (PDT) Received: from rst.Home ([2a02:c7d:692a:c500:1ebc:73f3:5f60:b131]) by smtp.gmail.com with ESMTPSA id 1sm5294149wml.28.2018.04.15.08.30.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 15 Apr 2018 08:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fnK33dTZxO+Nty9MhWVFRv4eCCazZ9T25xaKmjqd21Q=; b=Q+1fSfptfCbUx+UyciK37eMvj0/SAvKJbd0JY0PEAXPMoBmult6kvQInMXZw5CeiTo 4eq7/RYZkcbsYwbXDZDL55GorEtGiDQqVrfCVxwsMOU2yytB9hVXEsNecPrzebBVqIU5 RJs7n33kf/Osg5qchlH7AR1dYdJBV4ncMgKUF1i3bF+whlv567VQF+HWOl74GonheSRL kEkfZzjY4xtr1suFc4moDq2Prc8wogasIwA4nus/M+dC/RsXnBdf6Fki7orHBbGPXXj1 4yIApYD88fQ15b2n1y6FzWAeWMITQiT0RlR7mHB2WnZ84WPRCurwsULnq+03SDiBmf2g cLtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fnK33dTZxO+Nty9MhWVFRv4eCCazZ9T25xaKmjqd21Q=; b=tC5IUwqZSLUJI1WvwIwMULv5vLP+Gar1xJgSkjXrLhFYHGdYY5kMbzC+12/0JDoTeB 3izyjwwkbMj/IDZiiZ/kDHcpsv31RQpN0L/6gq4RlMTylZcy55zTY3GUNon0vMqHlQNj aa9x5y980+lekS6DcPlvWOCKxTcJfmo8w+3qfaTsjxfbVjeOQpwE0Al2F6QpZGB1lV2b o2RM1uDAPLn8qL09UOzzQM1X05q8r02dkp3n8k4pqpB4tTZqqWGFEwGuTfCx1FL9PfEW CQqiwf5XeZl+tgtFRdzM1QR8Qqvb/sCj+P/VoGeqTE+2oKYdBtmz5hjDfetvg1fWPIVi LLZQ== X-Gm-Message-State: ALQs6tCw/rfp5agRLEqLTVNAXiecDIocsPD23dphmKeu2+CHcHKHRRn8 0S3PWpEVdTY15/qCtI2IzyouTReF X-Google-Smtp-Source: AIpwx49vHQRJynHHF/jnaJnONjHbF/W2+XpNM1OjRl46HsTL2GCxH1XcdDtjzZBSMMpkH842FSdSKA== X-Received: by 10.28.140.82 with SMTP id o79mr8675801wmd.82.1523806220191; Sun, 15 Apr 2018 08:30:20 -0700 (PDT) From: Radostin Stoyanov To: libvir-list@redhat.com Date: Sun, 15 Apr 2018 16:30:10 +0100 Message-Id: <20180415153011.822-2-rstoyanov1@gmail.com> In-Reply-To: <20180415153011.822-1-rstoyanov1@gmail.com> References: <20180415153011.822-1-rstoyanov1@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sun, 15 Apr 2018 15:30:22 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sun, 15 Apr 2018 15:30:22 +0000 (UTC) for IP:'209.85.128.194' DOMAIN:'mail-wr0-f194.google.com' HELO:'mail-wr0-f194.google.com' FROM:'rstoyanov1@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.55 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS, T_DKIM_INVALID) 209.85.128.194 mail-wr0-f194.google.com 209.85.128.194 mail-wr0-f194.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Radostin Stoyanov Subject: [libvirt] [PATCH 1/2] lxc: s/subtreee/subtree/ X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Sun, 15 Apr 2018 15:30:48 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Radostin Stoyanov Reviewed-by: J=EF=BF=BDn Tomko --- src/lxc/lxc_container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 532fd0be0..665b93a0a 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -574,7 +574,7 @@ static int lxcContainerUnmountSubtree(const char *prefi= x, const char *failedUmount =3D NULL; int ret =3D -1; =20 - VIR_DEBUG("Unmount subtreee from %s", prefix); + VIR_DEBUG("Unmount subtree from %s", prefix); =20 if (virFileGetMountReverseSubtree("/proc/mounts", prefix, &mounts, &nmounts) < 0) --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 10:23:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1523806249838648.4812049283252; Sun, 15 Apr 2018 08:30:49 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E3AF81DE1; Sun, 15 Apr 2018 15:30:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C075560F8D; Sun, 15 Apr 2018 15:30:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B31C84CA9D; Sun, 15 Apr 2018 15:30:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3FFUa0K012553 for ; Sun, 15 Apr 2018 11:30:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id 88FF95D76A; Sun, 15 Apr 2018 15:30:36 +0000 (UTC) Received: from mx1.redhat.com (ext-mx09.extmail.prod.ext.phx2.redhat.com [10.5.110.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7FD4662660 for ; Sun, 15 Apr 2018 15:30:33 +0000 (UTC) Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F5234E906 for ; Sun, 15 Apr 2018 15:30:23 +0000 (UTC) Received: by mail-wr0-f195.google.com with SMTP id v60so15481056wrc.7 for ; Sun, 15 Apr 2018 08:30:22 -0700 (PDT) Received: from rst.Home ([2a02:c7d:692a:c500:1ebc:73f3:5f60:b131]) by smtp.gmail.com with ESMTPSA id 1sm5294149wml.28.2018.04.15.08.30.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 15 Apr 2018 08:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9RI9Um2/yQvQz64kHPzcuvTDJJ+Uwa/q4pPQtaEliq8=; b=LIMgiY2RBygXAPU+J5vpF2nhSZG/EbyE7x+nT+A8R2wRRWEHeWSfCLTwdvXFnEKOJ/ 2JxQSSlQgNzhXb5KF2OBeHOkaRJBergmXpca0ujlRqG0FjKjSxflg3q8LcSKu5pPl0Ju w3aTC7bBOcNB1+Qrw/zEhEdZUtM2LvOrfzwgMlzGZ60GPLezvKgaZ7nfKRs6L1NnM4p2 CarO69bqlHw7d/i+2znfCTyAC88hRiTvbaL9BaZNPfhlIm6U9w6rThK6McqeBIIHzisg svJANMIy/R9Mx34X4s0f3xRYG2rYmspSUt8zSK7RZJP0gmRyi4kCzchedo3jx+ZhkXl8 VqCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9RI9Um2/yQvQz64kHPzcuvTDJJ+Uwa/q4pPQtaEliq8=; b=FYkLebhWHW7qmHnC7FNF+l3nmGkcsVSrMewxtOphJyoOlWDdcKHgj8WFlYxUGWcOe7 Wbp6XU9J1z+Ier0GUdeWWy/DQRVFsaM1zpBaFV6IEDTsyQVnDsxgsDXsNcTer4OwHtn7 UsRy+8my1rIYNaD2NXvvkw5dCYNhJYS3ry8yYSnQX1V30gA46cjjdFrrzptdeqsoSJgq KRvLTkk2Rg8GBv9REq9BpIpNeyecscl8VXMhJtcoV/ivuG9hQdVsaOw90i8kbHSnRILW H0w5T8f08KyEso3csi5lH2hzqJQ9H7V63EKLLcztn4LDBg7hzJIlkQo+wYr0H6udPjbf 6TIQ== X-Gm-Message-State: ALQs6tDhPKwjpbEJ7CrrWMis8IzJkbbCPEUPy8fEJpbovloR/oCSNDgA FH5j0YPY+r6/47V9IQ5roCVsjSvT X-Google-Smtp-Source: AIpwx491Q1fzVow8Gu0P0NJ66S7gsH+rF1aObTCZvLyR1DAse0PhX5Me1OzDvLSXzeCAE7fFclooZw== X-Received: by 10.28.35.205 with SMTP id j196mr7803609wmj.108.1523806221394; Sun, 15 Apr 2018 08:30:21 -0700 (PDT) From: Radostin Stoyanov To: libvir-list@redhat.com Date: Sun, 15 Apr 2018 16:30:11 +0100 Message-Id: <20180415153011.822-3-rstoyanov1@gmail.com> In-Reply-To: <20180415153011.822-1-rstoyanov1@gmail.com> References: <20180415153011.822-1-rstoyanov1@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 15 Apr 2018 15:30:23 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 15 Apr 2018 15:30:23 +0000 (UTC) for IP:'209.85.128.195' DOMAIN:'mail-wr0-f195.google.com' HELO:'mail-wr0-f195.google.com' FROM:'rstoyanov1@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.55 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS, T_DKIM_INVALID) 209.85.128.195 mail-wr0-f195.google.com 209.85.128.195 mail-wr0-f195.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.38 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Radostin Stoyanov Subject: [libvirt] [PATCH 2/2] lxc: Clean up /.oldroot X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sun, 15 Apr 2018 15:30:48 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Remove the /.oldroot directory after it has been unmounted (at the end of lxcContainerSetupPivotRoot). Ignore errors silently. Signed-off-by: Radostin Stoyanov --- src/lxc/lxc_container.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 665b93a0a..dd4e38703 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -1811,6 +1811,9 @@ static int lxcContainerSetupPivotRoot(virDomainDefPtr= vmDef, if (lxcContainerUnmountSubtree("/.oldroot", true) < 0) goto cleanup; =20 + if (virFileRemove("/.oldroot", 0, 0) < 0) + VIR_DEBUG("Failed to remove /.oldroot after start"); + ret =3D 0; =20 cleanup: --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list