[libvirt] [jenkins-ci PATCH] guests: Add icoutils dependency to virt-viewer project

Andrea Bolognani posted 1 patch 6 years ago
Failed in applying to current master (apply log)
guests/vars/mappings.yml             | 4 ++++
guests/vars/projects/virt-viewer.yml | 1 +
2 files changed, 5 insertions(+)
[libvirt] [jenkins-ci PATCH] guests: Add icoutils dependency to virt-viewer project
Posted by Andrea Bolognani 6 years ago
The icotool command is used to manipulate Windows icon files.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/vars/mappings.yml             | 4 ++++
 guests/vars/projects/virt-viewer.yml | 1 +
 2 files changed, 5 insertions(+)

diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index e074648..6af5065 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -173,6 +173,10 @@ mappings:
   hal:
     FreeBSD: hal
 
+  icoutils:
+    default: icoutils
+    CentOS6:
+
   intltool:
     default: intltool
 
diff --git a/guests/vars/projects/virt-viewer.yml b/guests/vars/projects/virt-viewer.yml
index 6f3dbf9..54c96fe 100644
--- a/guests/vars/projects/virt-viewer.yml
+++ b/guests/vars/projects/virt-viewer.yml
@@ -3,6 +3,7 @@ packages:
   - glib2
   - gtk-vnc
   - gtk3
+  - icoutils
   - intltool
   - libgovirt
   - libxml2
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] guests: Add icoutils dependency to virt-viewer project
Posted by Pavel Hrdina 6 years ago
On Fri, Apr 13, 2018 at 02:10:08PM +0200, Andrea Bolognani wrote:
> The icotool command is used to manipulate Windows icon files.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/vars/mappings.yml             | 4 ++++
>  guests/vars/projects/virt-viewer.yml | 1 +
>  2 files changed, 5 insertions(+)

Isn't this required only for mingw build?  If so, we might want to
introduce virt-viewer+mingw project.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] guests: Add icoutils dependency to virt-viewer project
Posted by Andrea Bolognani 6 years ago
On Mon, 2018-04-16 at 10:31 +0200, Pavel Hrdina wrote:
> On Fri, Apr 13, 2018 at 02:10:08PM +0200, Andrea Bolognani wrote:
> > The icotool command is used to manipulate Windows icon files.
> > 
> > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> > ---
> >  guests/vars/mappings.yml             | 4 ++++
> >  guests/vars/projects/virt-viewer.yml | 1 +
> >  2 files changed, 5 insertions(+)
> 
> Isn't this required only for mingw build?

Yeah, you're right.

> If so, we might want to
> introduce virt-viewer+mingw project.

That was the plan all along :)

I'll wait for Dan to push his patches and then post a series that
splits off the +mingw part and also adds the icotool dependency.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list