Changeset
src/qemu/qemu_monitor.c | 31 -------------------------------
src/qemu/qemu_monitor.h |  4 ----
2 files changed, 35 deletions(-)
Git apply log
Switched to a new branch '20180412101034.25421-1-berrange@redhat.com'
Applying: qemu: remove obsolete qemuMonitorMigrateToCommand
To https://github.com/patchew-project/libvirt
 + efce608...4f44383 patchew/20180412101034.25421-1-berrange@redhat.com -> patchew/20180412101034.25421-1-berrange@redhat.com (forced update)
Test passed: syntax-check

loading

[libvirt] [PATCH] qemu: remove obsolete qemuMonitorMigrateToCommand
Posted by Daniel P. Berrangé, 14 weeks ago
The last use of qemuMonitorMigrateToCommand was removed years back in

  commit 2e90c9daf9eabe15d826a48c06607acb9d18fda6
  Author: Daniel P. Berrange <berrange@redhat.com>
  Date:   Fri Nov 6 16:50:26 2015 +0000

    qemu: assume support for all migration protocols except rdma

Prior to that commit, 'exec:' to used to replicate the 'unix:' protocol
by spawning 'nc'.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/qemu/qemu_monitor.c | 31 -------------------------------
 src/qemu/qemu_monitor.h |  4 ----
 2 files changed, 35 deletions(-)

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 7b647525b3..22f05222db 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -2730,37 +2730,6 @@ qemuMonitorMigrateToHost(qemuMonitorPtr mon,
 }
 
 
-int
-qemuMonitorMigrateToCommand(qemuMonitorPtr mon,
-                            unsigned int flags,
-                            const char * const *argv)
-{
-    char *argstr;
-    char *dest = NULL;
-    int ret = -1;
-    VIR_DEBUG("argv=%p flags=0x%x", argv, flags);
-
-    QEMU_CHECK_MONITOR(mon);
-
-    argstr = virArgvToString(argv);
-    if (!argstr)
-        goto cleanup;
-
-    if (virAsprintf(&dest, "exec:%s", argstr) < 0)
-        goto cleanup;
-
-    if (mon->json)
-        ret = qemuMonitorJSONMigrate(mon, flags, dest);
-    else
-        ret = qemuMonitorTextMigrate(mon, flags, dest);
-
- cleanup:
-    VIR_FREE(argstr);
-    VIR_FREE(dest);
-    return ret;
-}
-
-
 int
 qemuMonitorMigrateCancel(qemuMonitorPtr mon)
 {
diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h
index d04148e568..9556a51341 100644
--- a/src/qemu/qemu_monitor.h
+++ b/src/qemu/qemu_monitor.h
@@ -784,10 +784,6 @@ int qemuMonitorMigrateToHost(qemuMonitorPtr mon,
                              const char *hostname,
                              int port);
 
-int qemuMonitorMigrateToCommand(qemuMonitorPtr mon,
-                                unsigned int flags,
-                                const char * const *argv);
-
 int qemuMonitorMigrateCancel(qemuMonitorPtr mon);
 
 int qemuMonitorGetDumpGuestMemoryCapability(qemuMonitorPtr mon,
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: remove obsolete qemuMonitorMigrateToCommand
Posted by Ján Tomko, 13 weeks ago
On Thu, Apr 12, 2018 at 11:10:34AM +0100, Daniel P. Berrang� wrote:
>The last use of qemuMonitorMigrateToCommand was removed years back in
>
>  commit 2e90c9daf9eabe15d826a48c06607acb9d18fda6
>  Author: Daniel P. Berrange <berrange@redhat.com>
>  Date:   Fri Nov 6 16:50:26 2015 +0000
>
>    qemu: assume support for all migration protocols except rdma
>
>Prior to that commit, 'exec:' to used to replicate the 'unix:' protocol
>by spawning 'nc'.
>
>Signed-off-by: Daniel P. Berrang� <berrange@redhat.com>
>---
> src/qemu/qemu_monitor.c | 31 -------------------------------
> src/qemu/qemu_monitor.h |  4 ----
> 2 files changed, 35 deletions(-)
;

Reviewed-by: J�n Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list