[libvirt] [PATCH] news: announce dropping of legacy Xen driver

Jim Fehlig posted 1 patch 5 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180409210007.14238-1-jfehlig@suse.com
Test syntax-check passed
docs/news.xml | 10 ++++++++++
1 file changed, 10 insertions(+)
[libvirt] [PATCH] news: announce dropping of legacy Xen driver
Posted by Jim Fehlig 5 years, 11 months ago
Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---

Not sure if removal of a feature is a feature, but this seems better
placed under "New features" than "Improvements" or "Bug fixes".

 docs/news.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 798ab6da4..106979cc1 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -44,6 +44,16 @@
           add this controller when traditional PCI devices are in use.
         </description>
       </change>
+      <change>
+        <summary>
+          Xen: Drop the legacy xend-based driver
+        </summary>
+        <description>
+          The xm/xend toolstack was deprecated in Xen 4.2 and removed
+          from the Xen sources in the 4.5 development cycle. The libvirt
+          driver based on xend is now removed from the libvirt sources.
+        </description>
+      </change>
     </section>
     <section title="Improvements">
       <change>
-- 
2.16.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] news: announce dropping of legacy Xen driver
Posted by Andrea Bolognani 5 years, 11 months ago
On Mon, 2018-04-09 at 15:00 -0600, Jim Fehlig wrote:
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
> ---
> 
> Not sure if removal of a feature is a feature, but this seems better
> placed under "New features" than "Improvements" or "Bug fixes".

It definitely counts as an improvement for those of us working on
the codebase ;)

I think it would make sense to have a "Removed features" section
in between "New features" and "Improvements", at least for this
release: the old Xen driver is not the only chunk of legacy code
being dropped...

>  docs/news.xml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 798ab6da4..106979cc1 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -44,6 +44,16 @@
>            add this controller when traditional PCI devices are in use.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          Xen: Drop the legacy xend-based driver
> +        </summary>
> +        <description>
> +          The xm/xend toolstack was deprecated in Xen 4.2 and removed
> +          from the Xen sources in the 4.5 development cycle. The libvirt
> +          driver based on xend is now removed from the libvirt sources.
> +        </description>
> +      </change>
>      </section>
>      <section title="Improvements">
>        <change>

With a "Removed features" section introduced and the entry moved
to it,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

but maybe don't push right away to give other people a chance to
chime in.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] news: announce dropping of legacy Xen driver
Posted by Jim Fehlig 5 years, 11 months ago
On 04/10/2018 02:17 AM, Andrea Bolognani wrote:
> On Mon, 2018-04-09 at 15:00 -0600, Jim Fehlig wrote:
>> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
>> ---
>>
>> Not sure if removal of a feature is a feature, but this seems better
>> placed under "New features" than "Improvements" or "Bug fixes".
> 
> It definitely counts as an improvement for those of us working on
> the codebase ;)
> 
> I think it would make sense to have a "Removed features" section
> in between "New features" and "Improvements", at least for this
> release: the old Xen driver is not the only chunk of legacy code
> being dropped...
> 
>>   docs/news.xml | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/docs/news.xml b/docs/news.xml
>> index 798ab6da4..106979cc1 100644
>> --- a/docs/news.xml
>> +++ b/docs/news.xml
>> @@ -44,6 +44,16 @@
>>             add this controller when traditional PCI devices are in use.
>>           </description>
>>         </change>
>> +      <change>
>> +        <summary>
>> +          Xen: Drop the legacy xend-based driver
>> +        </summary>
>> +        <description>
>> +          The xm/xend toolstack was deprecated in Xen 4.2 and removed
>> +          from the Xen sources in the 4.5 development cycle. The libvirt
>> +          driver based on xend is now removed from the libvirt sources.
>> +        </description>
>> +      </change>
>>       </section>
>>       <section title="Improvements">
>>         <change>
> 
> With a "Removed features" section introduced and the entry moved
> to it,
> 
>    Reviewed-by: Andrea Bolognani <abologna@redhat.com>
> 
> but maybe don't push right away to give other people a chance to
> chime in.

Crickets...

Pushed now.

Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list