[libvirt] [dbus PATCH v3 0/4] Introduce Network Interface

Katerina Koukiou posted 4 patches 6 years ago
Failed in applying to current master (apply log)
data/Makefile.am             |   3 +-
data/org.libvirt.Connect.xml |  12 +++++
data/org.libvirt.Network.xml |  11 +++++
src/Makefile.am              |   3 +-
src/connect.c                |  76 ++++++++++++++++++++++++++++++
src/connect.h                |   1 +
src/network.c                | 107 +++++++++++++++++++++++++++++++++++++++++++
src/network.h                |   9 ++++
src/util.c                   |  33 +++++++++++++
src/util.h                   |  15 ++++++
test/Makefile.am             |   3 +-
test/libvirttest.py          |  12 +++++
test/test_connect.py         |  23 ++++++++++
test/test_network.py         |  19 ++++++++
14 files changed, 324 insertions(+), 3 deletions(-)
create mode 100644 data/org.libvirt.Network.xml
create mode 100644 src/network.c
create mode 100644 src/network.h
create mode 100755 test/test_network.py
[libvirt] [dbus PATCH v3 0/4] Introduce Network Interface
Posted by Katerina Koukiou 6 years ago
This patchset introduces also some basic methods and properties for
Network interface.
More functionality will be added in following patchsets.
New functions are covered by the test suite.

Changes from v2:
* Added test_list_networks test.
* xml files should group methods/signals/properties together.
* Some other minor fixes.

Katerina Koukiou (4):
  Introduce Network Interface
  Implement ListNetworks method for Connect interface
  Implement Name property for Network interface
  Implement NetworkLookupByName method for Connect interface

 data/Makefile.am             |   3 +-
 data/org.libvirt.Connect.xml |  12 +++++
 data/org.libvirt.Network.xml |  11 +++++
 src/Makefile.am              |   3 +-
 src/connect.c                |  76 ++++++++++++++++++++++++++++++
 src/connect.h                |   1 +
 src/network.c                | 107 +++++++++++++++++++++++++++++++++++++++++++
 src/network.h                |   9 ++++
 src/util.c                   |  33 +++++++++++++
 src/util.h                   |  15 ++++++
 test/Makefile.am             |   3 +-
 test/libvirttest.py          |  12 +++++
 test/test_connect.py         |  23 ++++++++++
 test/test_network.py         |  19 ++++++++
 14 files changed, 324 insertions(+), 3 deletions(-)
 create mode 100644 data/org.libvirt.Network.xml
 create mode 100644 src/network.c
 create mode 100644 src/network.h
 create mode 100755 test/test_network.py

-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH v3 0/4] Introduce Network Interface
Posted by Pavel Hrdina 6 years ago
On Thu, Apr 05, 2018 at 12:40:16PM +0200, Katerina Koukiou wrote:
> This patchset introduces also some basic methods and properties for
> Network interface.
> More functionality will be added in following patchsets.
> New functions are covered by the test suite.
> 
> Changes from v2:
> * Added test_list_networks test.
> * xml files should group methods/signals/properties together.
> * Some other minor fixes.
> 
> Katerina Koukiou (4):
>   Introduce Network Interface
>   Implement ListNetworks method for Connect interface
>   Implement Name property for Network interface
>   Implement NetworkLookupByName method for Connect interface

With the indentation fixed

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH v3 0/4] Introduce Network Interface
Posted by Katerina Koukiou 6 years ago
On Thu, 2018-04-05 at 12:51 +0200, Pavel Hrdina wrote:
> On Thu, Apr 05, 2018 at 12:40:16PM +0200, Katerina Koukiou wrote:
> > This patchset introduces also some basic methods and properties for
> > Network interface.
> > More functionality will be added in following patchsets.
> > New functions are covered by the test suite.
> > 
> > Changes from v2:
> > * Added test_list_networks test.
> > * xml files should group methods/signals/properties together.
> > * Some other minor fixes.
> > 
> > Katerina Koukiou (4):
> >   Introduce Network Interface
> >   Implement ListNetworks method for Connect interface
> >   Implement Name property for Network interface
> >   Implement NetworkLookupByName method for Connect interface
> 
> With the indentation fixed

Fixed and pushed.
Thanks for review.

> 
> Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list