[libvirt] [PATCH] docs: Update the format of the generate metadata example

John Ferlan posted 1 patch 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180404202354.10535-1-jferlan@redhat.com
Test syntax-check passed
docs/formatdomain.html.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[libvirt] [PATCH] docs: Update the format of the generate metadata example
Posted by John Ferlan 6 years ago
Initially, update the UUID field to have the proper format, but
then also changed the type, id, and name fields.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

 While beginning to think more about the vmgenid RFC and creating a <genid/>
 element under the <uuid>, I noted that the existing name and uuid fields
 were a bit out of date. 

 docs/formatdomain.html.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 82e7d7ce66..984563379e 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -31,9 +31,9 @@
     <h3><a id="elementsMetadata">General metadata</a></h3>
 
 <pre>
-&lt;domain type='xen' id='3'&gt;
-  &lt;name&gt;fv0&lt;/name&gt;
-  &lt;uuid&gt;4dea22b31d52d8f32516782e98ab3fa0&lt;/uuid&gt;
+&lt;domain type='kvm' id='1'&gt;
+  &lt;name&gt;MyFirstGuest&lt;/name&gt;
+  &lt;uuid&gt;4dea22b3-1d52-d8f3-2516-782e98ab3fa0&lt;/uuid&gt;
   &lt;title&gt;A short description - title - of the domain&lt;/title&gt;
   &lt;description&gt;Some human readable description&lt;/description&gt;
   &lt;metadata&gt;
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] docs: Update the format of the generate metadata example
Posted by Erik Skultety 6 years ago
On Wed, Apr 04, 2018 at 04:23:54PM -0400, John Ferlan wrote:
> Initially, update the UUID field to have the proper format, but
> then also changed the type, id, and name fields.
>
> Signed-off-by: John Ferlan <jferlan@redhat.com>
> ---
>
>  While beginning to think more about the vmgenid RFC and creating a <genid/>
>  element under the <uuid>, I noted that the existing name and uuid fields
>  were a bit out of date.
>
>  docs/formatdomain.html.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 82e7d7ce66..984563379e 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -31,9 +31,9 @@
>      <h3><a id="elementsMetadata">General metadata</a></h3>
>
>  <pre>
> -&lt;domain type='xen' id='3'&gt;
> -  &lt;name&gt;fv0&lt;/name&gt;
> -  &lt;uuid&gt;4dea22b31d52d8f32516782e98ab3fa0&lt;/uuid&gt;
> +&lt;domain type='kvm' id='1'&gt;
> +  &lt;name&gt;MyFirstGuest&lt;/name&gt;

MyGuest is probably better...

> +  &lt;uuid&gt;4dea22b3-1d52-d8f3-2516-782e98ab3fa0&lt;/uuid&gt;
>    &lt;title&gt;A short description - title - of the domain&lt;/title&gt;
>    &lt;description&gt;Some human readable description&lt;/description&gt;
>    &lt;metadata&gt;

trivial...
Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list