[libvirt] [PATCH] rpm: add deps on rpcgen/libtirpc-devel

Daniel P. Berrangé posted 1 patch 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180403124237.9145-1-berrange@redhat.com
Test syntax-check passed
libvirt.spec.in | 5 +++++
1 file changed, 5 insertions(+)
[libvirt] [PATCH] rpm: add deps on rpcgen/libtirpc-devel
Posted by Daniel P. Berrangé 6 years ago
Since RPC support moved out of glibc we need to have explicit deps on
the new packages providing this functionality

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 libvirt.spec.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index b55a947ec9..97143c68ae 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -464,6 +464,11 @@ BuildRequires: wireshark-devel >= 2.1.0
 BuildRequires: libssh-devel >= 0.7.0
 %endif
 
+%if 0%{?fedora} > 27 || 0%{?rhel} > 7
+BuildRequires: rpcgen
+BuildRequires: libtirpc-devel
+%endif
+
 Provides: bundled(gnulib)
 
 %description
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] rpm: add deps on rpcgen/libtirpc-devel
Posted by Andrea Bolognani 6 years ago
On Tue, 2018-04-03 at 13:42 +0100, Daniel P. Berrangé wrote:
> Since RPC support moved out of glibc we need to have explicit deps on
> the new packages providing this functionality
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  libvirt.spec.in | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index b55a947ec9..97143c68ae 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -464,6 +464,11 @@ BuildRequires: wireshark-devel >= 2.1.0
>  BuildRequires: libssh-devel >= 0.7.0
>  %endif
>  
> +%if 0%{?fedora} > 27 || 0%{?rhel} > 7
> +BuildRequires: rpcgen
> +BuildRequires: libtirpc-devel
> +%endif
> +
>  Provides: bundled(gnulib)
>  
>  %description

FWIW, we're already installing the packages listed above on our
CI builders.

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list