[v4] New APIs and Domain Lifecycle signal change

[libvirt] [dbus PATCH v4 0/5] New APIs and Domain Lifecycle signal change

Katerina Koukiou posted 5 patches 6 years ago

Diff against v1 v2 v3
Download series mbox

Failed in applying to current master (apply log)

data/org.libvirt.Connect.xml | 54 +++-------------------------------------
data/org.libvirt.Domain.xml  |  8 ++++++
src/domain.c                 | 42 +++++++++++++++++++++++++++++++
src/events.c                 | 59 +++++++++++++++++---------------------------
src/util.c                   | 27 ++++++++++++++++++++
src/util.h                   | 28 +++++++++++++++++++++
test/test_connect.py         | 10 +++-----
test/test_domain.py          | 40 +++++++++++++++++++++++++-----
8 files changed, 168 insertions(+), 100 deletions(-)

Expand all Fold all

[libvirt] [dbus PATCH v4 0/5] New APIs and Domain Lifecycle signal change

Posted by Katerina Koukiou 6 years ago

* Implemented Suspend and Resume APIs.
* Reused virsh functions for taking the Event Strings names from ENUM.
* Merged all Domain Lifecycle events signals into one signal.

Changes from v3:
* s/arg2/arg1/ since Event Type is the second argument of the signal.

Katerina Koukiou (5):
  Implement Suspend method for Domain interface.
  Implement Resume method for Domain interface.
  utils: Introduce functions and macros for translating ENUMs to strings
  events: Introduce virtDBusEventsDomainEventToString function
  Merge all Domain lifecycle signals into one signal called Domain.

 data/org.libvirt.Connect.xml | 54 +++-------------------------------------
 data/org.libvirt.Domain.xml  |  8 ++++++
 src/domain.c                 | 42 +++++++++++++++++++++++++++++++
 src/events.c                 | 59 +++++++++++++++++---------------------------
 src/util.c                   | 27 ++++++++++++++++++++
 src/util.h                   | 28 +++++++++++++++++++++
 test/test_connect.py         | 10 +++-----
 test/test_domain.py          | 40 +++++++++++++++++++++++++-----
 8 files changed, 168 insertions(+), 100 deletions(-)

-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH v4 0/5] New APIs and Domain Lifecycle signal change

Posted by Pavel Hrdina 6 years ago

On Tue, Apr 03, 2018 at 10:29:55AM +0200, Katerina Koukiou wrote:
> * Implemented Suspend and Resume APIs.
> * Reused virsh functions for taking the Event Strings names from ENUM.
> * Merged all Domain Lifecycle events signals into one signal.
> 
> Changes from v3:
> * s/arg2/arg1/ since Event Type is the second argument of the signal.
> 
> Katerina Koukiou (5):
>   Implement Suspend method for Domain interface.
>   Implement Resume method for Domain interface.
>   utils: Introduce functions and macros for translating ENUMs to strings
>   events: Introduce virtDBusEventsDomainEventToString function
>   Merge all Domain lifecycle signals into one signal called Domain.

If you fix the small issues pointed out in the last two patches

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list