vmware - Clean/fix test driver usage of FindBy{UUID|ID}

[libvirt] [PATCH v2 0/4] vmware - Clean/fix test driver usage of FindBy{UUID|ID}

Posted by John Ferlan 6 years ago

Patches 12-15 of the formerly larger series:

https://www.redhat.com/archives/libvir-list/2018-March/msg00489.html

Changes since v1:

 * In patch 4, call virObjectLock after virDomainObjListRemove in
   vmwareDomainShutdownFlags and vmwareDomainUndefineFlags because
   both would return a reffed/locked @vm object and we need to
   relock before falling in the cleanup call to virDomainObjEndAPI

John Ferlan (4):
  vmware: Properly clean up in vmwareDomainLookupByName
  vmware: Create accessors to virDomainObjListFindByUUID
  vmware: Add more descriptive error message on Find failure
  vmware: Use virDomainObjListFindBy{UUID|ID}Ref

 src/vmware/vmware_driver.c | 240 ++++++++++++++++-----------------------------
 1 file changed, 84 insertions(+), 156 deletions(-)

-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/4] vmware - Clean/fix test driver usage of FindBy{UUID|ID}

Posted by John Ferlan 6 years ago

ping? This is less about vmware specifically and more about domain
object manipulation coordination...

Tks,

John

On 04/02/2018 09:16 AM, John Ferlan wrote:
> Patches 12-15 of the formerly larger series:
> 
> https://www.redhat.com/archives/libvir-list/2018-March/msg00489.html
> 
> Changes since v1:
> 
>  * In patch 4, call virObjectLock after virDomainObjListRemove in
>    vmwareDomainShutdownFlags and vmwareDomainUndefineFlags because
>    both would return a reffed/locked @vm object and we need to
>    relock before falling in the cleanup call to virDomainObjEndAPI
> 
> John Ferlan (4):
>   vmware: Properly clean up in vmwareDomainLookupByName
>   vmware: Create accessors to virDomainObjListFindByUUID
>   vmware: Add more descriptive error message on Find failure
>   vmware: Use virDomainObjListFindBy{UUID|ID}Ref
> 
>  src/vmware/vmware_driver.c | 240 ++++++++++++++++-----------------------------
>  1 file changed, 84 insertions(+), 156 deletions(-)
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/4] vmware - Clean/fix test driver usage of FindBy{UUID|ID}

Posted by John Ferlan 5 years, 12 months ago

ping^2

Getting closer to being able to fix Add/Remove, but still need a few
more baby steps...

Tks,

John

On 04/11/2018 11:41 AM, John Ferlan wrote:
> 
> ping? This is less about vmware specifically and more about domain
> object manipulation coordination...
> 
> Tks,
> 
> John
> 
> On 04/02/2018 09:16 AM, John Ferlan wrote:
>> Patches 12-15 of the formerly larger series:
>>
>> https://www.redhat.com/archives/libvir-list/2018-March/msg00489.html
>>
>> Changes since v1:
>>
>>  * In patch 4, call virObjectLock after virDomainObjListRemove in
>>    vmwareDomainShutdownFlags and vmwareDomainUndefineFlags because
>>    both would return a reffed/locked @vm object and we need to
>>    relock before falling in the cleanup call to virDomainObjEndAPI
>>
>> John Ferlan (4):
>>   vmware: Properly clean up in vmwareDomainLookupByName
>>   vmware: Create accessors to virDomainObjListFindByUUID
>>   vmware: Add more descriptive error message on Find failure
>>   vmware: Use virDomainObjListFindBy{UUID|ID}Ref
>>
>>  src/vmware/vmware_driver.c | 240 ++++++++++++++++-----------------------------
>>  1 file changed, 84 insertions(+), 156 deletions(-)
>>
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list