Change virCloseCallback typedef to return void

[libvirt] [PATCH 0/2] Change virCloseCallback typedef to return void

John Ferlan posted 2 patches 6 years ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180329124817.4524-1-jferlan@redhat.com

Test syntax-check passed

src/bhyve/bhyve_process.c    |  8 ++------
src/lxc/lxc_process.c        |  8 ++------
src/qemu/qemu_migration.c    |  7 ++-----
src/qemu/qemu_process.c      | 10 ++--------
src/util/virclosecallbacks.c |  5 ++---
src/util/virclosecallbacks.h |  6 +++---
6 files changed, 13 insertions(+), 31 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] Change virCloseCallback typedef to return void

Posted by John Ferlan 6 years ago

Slightly related to some current work to clean up the Add/Remove
domain object list processing - as it turns out the close callbacks
run code didn't even pay attention to what was returned and it
really didn't need to - so let's just call it what it is a void
function and let the virCloseCallbacksRun code handle the object
manipulation (lock/ref and unlock/unref).

John Ferlan (2):
  qemu: Fix qemuProcessAutoDestroy
  util: Alter virCloseCallback typedef to return void

 src/bhyve/bhyve_process.c    |  8 ++------
 src/lxc/lxc_process.c        |  8 ++------
 src/qemu/qemu_migration.c    |  7 ++-----
 src/qemu/qemu_process.c      | 10 ++--------
 src/util/virclosecallbacks.c |  5 ++---
 src/util/virclosecallbacks.h |  6 +++---
 6 files changed, 13 insertions(+), 31 deletions(-)

-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] Change virCloseCallback typedef to return void

Posted by John Ferlan 6 years ago

ping?

Tks -

John

On 03/29/2018 08:48 AM, John Ferlan wrote:
> Slightly related to some current work to clean up the Add/Remove
> domain object list processing - as it turns out the close callbacks
> run code didn't even pay attention to what was returned and it
> really didn't need to - so let's just call it what it is a void
> function and let the virCloseCallbacksRun code handle the object
> manipulation (lock/ref and unlock/unref).
> 
> John Ferlan (2):
>   qemu: Fix qemuProcessAutoDestroy
>   util: Alter virCloseCallback typedef to return void
> 
>  src/bhyve/bhyve_process.c    |  8 ++------
>  src/lxc/lxc_process.c        |  8 ++------
>  src/qemu/qemu_migration.c    |  7 ++-----
>  src/qemu/qemu_process.c      | 10 ++--------
>  src/util/virclosecallbacks.c |  5 ++---
>  src/util/virclosecallbacks.h |  6 +++---
>  6 files changed, 13 insertions(+), 31 deletions(-)
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list