vmx: allow more than 4 NICs (RHBZ#1560917)

[libvirt] [PATCH 0/4] vmx: allow more than 4 NICs (RHBZ#1560917)

Posted by Pino Toscano 6 years ago

Hi,

the VMX parser, used in the esx driver, has currently hardcoded 4 NICs
possible, ignoring extra more than that. The following series removes
this limitation, allowing to parse all the 10 NICs in the VMX of
RHBZ#1560917.

Thanks,

Pino Toscano (4):
  vmx: check for present/enabled devices earlier
  vmx: allocate space for network interfaces if needed
  internal: add STRCASEPREFIX
  vmx: convert any amount of NICs

 src/internal.h                                  |   1 +
 src/vmx/vmx.c                                   | 150 +++++++++++-----------
 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-8.vmx | 163 ++++++++++++++++++++++++
 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-8.xml |  89 +++++++++++++
 tests/vmx2xmltest.c                             |   1 +
 5 files changed, 325 insertions(+), 79 deletions(-)
 create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-8.vmx
 create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-8.xml

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] vmx: allow more than 4 NICs (RHBZ#1560917)

Posted by Ján Tomko 6 years ago

On Wed, Mar 28, 2018 at 01:40:17PM +0200, Pino Toscano wrote:
>Hi,
>
>the VMX parser, used in the esx driver, has currently hardcoded 4 NICs
>possible, ignoring extra more than that. The following series removes
>this limitation, allowing to parse all the 10 NICs in the VMX of
>RHBZ#1560917.
>
>Thanks,
>
>Pino Toscano (4):
>  vmx: check for present/enabled devices earlier
>  vmx: allocate space for network interfaces if needed
>  internal: add STRCASEPREFIX
>  vmx: convert any amount of NICs
>

ACK series

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] vmx: allow more than 4 NICs (RHBZ#1560917)

Posted by Michal Privoznik 6 years ago

On 03/28/2018 01:56 PM, Ján Tomko wrote:
> On Wed, Mar 28, 2018 at 01:40:17PM +0200, Pino Toscano wrote:
>> Hi,
>>
>> the VMX parser, used in the esx driver, has currently hardcoded 4 NICs
>> possible, ignoring extra more than that. The following series removes
>> this limitation, allowing to parse all the 10 NICs in the VMX of
>> RHBZ#1560917.
>>
>> Thanks,
>>
>> Pino Toscano (4):
>>  vmx: check for present/enabled devices earlier
>>  vmx: allocate space for network interfaces if needed
>>  internal: add STRCASEPREFIX
>>  vmx: convert any amount of NICs
>>
> 
> ACK series
> 

Pushed now.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] vmx: allow more than 4 NICs (RHBZ#1560917)

Posted by Ján Tomko 6 years ago

On Sun, Apr 01, 2018 at 12:48:13PM +0200, Michal Privoznik wrote:
>On 03/28/2018 01:56 PM, Ján Tomko wrote:
>> On Wed, Mar 28, 2018 at 01:40:17PM +0200, Pino Toscano wrote:
>>> Hi,
>>>
>>> the VMX parser, used in the esx driver, has currently hardcoded 4 NICs
>>> possible, ignoring extra more than that. The following series removes
>>> this limitation, allowing to parse all the 10 NICs in the VMX of
>>> RHBZ#1560917.
>>>
>>> Thanks,
>>>
>>> Pino Toscano (4):
>>>  vmx: check for present/enabled devices earlier
>>>  vmx: allocate space for network interfaces if needed
>>>  internal: add STRCASEPREFIX
>>>  vmx: convert any amount of NICs
>>>
>>
>> ACK series
>>
>
>Pushed now.
>

Thanks, I was AFK on a Sunday and did not notice the release.

Jano

>Michal
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list