[libvirt] [tck PATCH] require libguestfs-tool package

Laine Stump posted 1 patch 6 years, 1 month ago
Failed in applying to current master (apply log)
perl-Sys-Virt-TCK.spec.PL | 1 +
1 file changed, 1 insertion(+)
[libvirt] [tck PATCH] require libguestfs-tool package
Posted by Laine Stump 6 years, 1 month ago
The nwfilter tests use virt-builder to download and configure a guest
appliance, but we don't require the libguestfs-tools package. Up until
now it's just happened that it was always already installed on the
test systems, so it wasn't a problem, but it's annoying to have to
type the one extra install command when setting up a new machine to
run the tests.

Signed-off-by: Laine Stump <laine@laine.org>
---
 perl-Sys-Virt-TCK.spec.PL | 1 +
 1 file changed, 1 insertion(+)

diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index 7c83be9..9694227 100644
--- a/perl-Sys-Virt-TCK.spec.PL
+++ b/perl-Sys-Virt-TCK.spec.PL
@@ -75,6 +75,7 @@ Requires: perl(TAP::Formatter::JUnit)
 Requires: perl(TAP::Harness::Archive)
 Requires: perl(Net::OpenSSH)
 Requires: perl(IO::Pty)
+Requires: libguestfs-tools
 Requires: /usr/bin/mkisofs
 BuildArchitectures: noarch
 
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [tck PATCH] require libguestfs-tool package
Posted by Erik Skultety 6 years, 1 month ago
On Sun, Mar 25, 2018 at 06:47:14PM -0400, Laine Stump wrote:
> The nwfilter tests use virt-builder to download and configure a guest
> appliance, but we don't require the libguestfs-tools package. Up until
> now it's just happened that it was always already installed on the
> test systems, so it wasn't a problem, but it's annoying to have to
> type the one extra install command when setting up a new machine to
> run the tests.
>
> Signed-off-by: Laine Stump <laine@laine.org>
> ---
>  perl-Sys-Virt-TCK.spec.PL | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
> index 7c83be9..9694227 100644
> --- a/perl-Sys-Virt-TCK.spec.PL
> +++ b/perl-Sys-Virt-TCK.spec.PL
> @@ -75,6 +75,7 @@ Requires: perl(TAP::Formatter::JUnit)
>  Requires: perl(TAP::Harness::Archive)
>  Requires: perl(Net::OpenSSH)
>  Requires: perl(IO::Pty)
> +Requires: libguestfs-tools
>  Requires: /usr/bin/mkisofs
>  vuildArchitectures: noarch

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list