[libvirt] [PATCH] qemu: Fix virQEMUCapsCommands formatting

John Ferlan posted 1 patch 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180322152210.28901-1-jferlan@redhat.com
Test syntax-check passed
src/qemu/qemu_capabilities.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[libvirt] [PATCH] qemu: Fix virQEMUCapsCommands formatting
Posted by John Ferlan 6 years ago
Starting with commit id 'fab9d6e1' the formatting of:

{ "command-name", QEMU_CAPS_NAME },

was altered to:

{ "command-name", QEMU_CAPS_NAME},

and then commit id 'e2b05c9a' altered that to:

{ "command-name", QEMU_CAPS_NAME}

So, let's just fix that up to make things consistent with the
rest of the structures.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---
 Although I could say this was trivial, it does impact at least one
 upstream series (query-cpus-fast), so rather than just take that route,
 I figured it'd be better to give ample warning...  I can also wait, but
 that series propagates the middle format with the comma at the end.

 src/qemu/qemu_capabilities.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 3eb5ed6d1a..3b1bc051af 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -1577,9 +1577,9 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = {
     { "migrate-incoming", QEMU_CAPS_INCOMING_DEFER },
     { "query-hotpluggable-cpus", QEMU_CAPS_QUERY_HOTPLUGGABLE_CPUS },
     { "query-qmp-schema", QEMU_CAPS_QUERY_QMP_SCHEMA },
-    { "query-cpu-model-expansion", QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION},
-    { "query-cpu-definitions", QEMU_CAPS_QUERY_CPU_DEFINITIONS},
-    { "query-named-block-nodes", QEMU_CAPS_QUERY_NAMED_BLOCK_NODES}
+    { "query-cpu-model-expansion", QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION },
+    { "query-cpu-definitions", QEMU_CAPS_QUERY_CPU_DEFINITIONS },
+    { "query-named-block-nodes", QEMU_CAPS_QUERY_NAMED_BLOCK_NODES },
 };
 
 struct virQEMUCapsStringFlags virQEMUCapsMigration[] = {
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: Fix virQEMUCapsCommands formatting
Posted by Ján Tomko 6 years ago
On Thu, Mar 22, 2018 at 11:22:10AM -0400, John Ferlan wrote:
>Starting with commit id 'fab9d6e1' the formatting of:
>
>{ "command-name", QEMU_CAPS_NAME },
>
>was altered to:
>
>{ "command-name", QEMU_CAPS_NAME},
>
>and then commit id 'e2b05c9a' altered that to:
>
>{ "command-name", QEMU_CAPS_NAME}
>
>So, let's just fix that up to make things consistent with the
>rest of the structures.
>
>Signed-off-by: John Ferlan <jferlan@redhat.com>
>---
> Although I could say this was trivial, it does impact at least one
> upstream series (query-cpus-fast), so rather than just take that route,
> I figured it'd be better to give ample warning...  I can also wait, but
> that series propagates the middle format with the comma at the end.
>

Worst case is that the committer will have to adjust it when pushing.

> src/qemu/qemu_capabilities.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

ACK

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list