guests: Fix ~/.ccache ownership

[libvirt] [jenkins-ci PATCH] guests: Fix ~/.ccache ownership

Posted by Andrea Bolognani 6 years, 1 month ago

The directory and the files contained within need to be owned
by the user or compilation will fail, either loudly or silently
depending on the OS, due to missing write permissions.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/tasks/users.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/guests/tasks/users.yml b/guests/tasks/users.yml
index 6134228..87693e0 100644
--- a/guests/tasks/users.yml
+++ b/guests/tasks/users.yml
@@ -55,8 +55,12 @@
   file:
     path: /home/{{ flavor }}/.ccache
     state: directory
+    owner: '{{ flavor }}'
+    group: '{{ flavor }}'
 
 - name: '{{ flavor }}: Configure ccache'
   copy:
     src: files/ccache.conf
     dest: /home/{{ flavor }}/.ccache/ccache.conf
+    owner: '{{ flavor }}'
+    group: '{{ flavor }}'
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] guests: Fix ~/.ccache ownership

Posted by Daniel P. Berrangé 6 years, 1 month ago

On Thu, Mar 22, 2018 at 04:03:20PM +0100, Andrea Bolognani wrote:
> The directory and the files contained within need to be owned
> by the user or compilation will fail, either loudly or silently
> depending on the OS, due to missing write permissions.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/tasks/users.yml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/guests/tasks/users.yml b/guests/tasks/users.yml
> index 6134228..87693e0 100644
> --- a/guests/tasks/users.yml
> +++ b/guests/tasks/users.yml
> @@ -55,8 +55,12 @@
>    file:
>      path: /home/{{ flavor }}/.ccache
>      state: directory
> +    owner: '{{ flavor }}'
> +    group: '{{ flavor }}'
>  
>  - name: '{{ flavor }}: Configure ccache'
>    copy:
>      src: files/ccache.conf
>      dest: /home/{{ flavor }}/.ccache/ccache.conf
> +    owner: '{{ flavor }}'
> +    group: '{{ flavor }}'

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list