[libvirt] [PATCH] libvirt: Fix comments for two public APIs.

Han Han posted 1 patch 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180320073226.18223-1-hhan@redhat.com
Test syntax-check passed
src/libvirt-nodedev.c | 2 +-
src/libvirt-secret.c  | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[libvirt] [PATCH] libvirt: Fix comments for two public APIs.
Posted by Han Han 6 years ago
Fix comments for virConnectListAllNodeDevices and
virConnectListAllSecrets.

Signed-off-by: Han Han <hhan@redhat.com>
---
 src/libvirt-nodedev.c | 2 +-
 src/libvirt-secret.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/libvirt-nodedev.c b/src/libvirt-nodedev.c
index 493b21f56..563ce889b 100644
--- a/src/libvirt-nodedev.c
+++ b/src/libvirt-nodedev.c
@@ -72,7 +72,7 @@ virNodeNumOfDevices(virConnectPtr conn, const char *cap, unsigned int flags)
  * @devices: Pointer to a variable to store the array containing the node
  *           device objects or NULL if the list is not required (just returns
  *           number of node devices).
- * @flags: bitwise-OR of virConnectListAllNodeDevices.
+ * @flags: bitwise-OR of virConnectListAllNodeDeviceFlags.
  *
  * Collect the list of node devices, and allocate an array to store those
  * objects.
diff --git a/src/libvirt-secret.c b/src/libvirt-secret.c
index 447d93f33..1e1cd4e65 100644
--- a/src/libvirt-secret.c
+++ b/src/libvirt-secret.c
@@ -90,7 +90,7 @@ virConnectNumOfSecrets(virConnectPtr conn)
  * @secrets: Pointer to a variable to store the array containing the secret
  *           objects or NULL if the list is not required (just returns the
  *           number of secrets).
- * @flags: extra flags; not used yet, so callers should always pass 0
+ * @flags: bitwise-OR of virConnectListAllSecretsFlags.
  *
  * Collect the list of secrets, and allocate an array to store those
  * objects.
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] libvirt: Fix comments for two public APIs.
Posted by John Ferlan 6 years ago

On 03/20/2018 03:32 AM, Han Han wrote:
> Fix comments for virConnectListAllNodeDevices and
> virConnectListAllSecrets.
> 
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  src/libvirt-nodedev.c | 2 +-
>  src/libvirt-secret.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>
(and pushed)

Tks,

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list