[libvirt] [PATCH] gnulib: switch to use https:// instead of git:// protocol

Daniel P. Berrangé posted 1 patch 6 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180316173020.7691-1-berrange@redhat.com
Test syntax-check passed
.gitmodules | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] gnulib: switch to use https:// instead of git:// protocol
Posted by Daniel P. Berrangé 6 years, 1 month ago
Some contributors are behind obnoxious firewalls that block everything
except http(s) traffic, preventing checkout of modules using the git://
protocol. Since git.savannah.gnu.org is using the modern, fast HTTP
transport, there's no real downside to using that by default.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

AFAICT, this change has no effect for anyone with an existing checkout
of gnulib. They'll continue using the git protocol, just new checkouts
will start using http. This is fine so no effort is made to "fix"
existing checkouts.

 .gitmodules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitmodules b/.gitmodules
index cfee24d7b8..0fda887528 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,6 +1,6 @@
 [submodule "gnulib"]
 	path = .gnulib
-	url = git://git.sv.gnu.org/gnulib.git
+	url = https://git.savannah.gnu.org/git/gnulib.git/
 [submodule "keycodemapdb"]
 	path = src/keycodemapdb
 	url = https://gitlab.com/keycodemap/keycodemapdb.git
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] gnulib: switch to use https:// instead of git:// protocol
Posted by Erik Skultety 6 years, 1 month ago
On Fri, Mar 16, 2018 at 05:30:20PM +0000, Daniel P. Berrangé wrote:
> Some contributors are behind obnoxious firewalls that block everything
> except http(s) traffic, preventing checkout of modules using the git://
> protocol. Since git.savannah.gnu.org is using the modern, fast HTTP
> transport, there's no real downside to using that by default.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>
> AFAICT, this change has no effect for anyone with an existing checkout
> of gnulib. They'll continue using the git protocol, just new checkouts

I would assume so as well, since cleaning the repo with -fdx doesn't have an
impact on gnulib, git:// continued to be used. Anyhow, I think this is a move
forward either way.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list