libxl: fix virDomainObj locking and ref counting in migration APIs

[libvirt] [PATCH 0/4] libxl: fix virDomainObj locking and ref counting in migration APIs

Jim Fehlig posted 4 patches 6 years, 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180313172634.27237-1-jfehlig@suse.com

Test syntax-check passed

src/libxl/libxl_driver.c    | 40 ++++++++++++++++++++++------------------
src/libxl/libxl_migration.c | 10 ++--------
2 files changed, 24 insertions(+), 26 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/4] libxl: fix virDomainObj locking and ref counting in migration APIs

Posted by Jim Fehlig 6 years, 1 month ago

While reviewing a patch [0] from John's series to rework
virDomainObjListFindBy{UUID|ID}Ref, I noticed several problems with locking
and ref counting in the libxl migration APIs. This series changes the Begin,
Prepare, Perform, and Confirm APIs to use the standard pattern of get a
locked and ref counted virDomainObj, perform API, virDomainObjEndAPI.

[0] https://www.redhat.com/archives/libvir-list/2018-March/msg00516.html

Jim Fehlig (4):
  libxl: MigrateBegin: Dont call EndAPI in helper function
  libxl: MigrateConfirm: Dont unlock virDomainObj in helper function
  libxl: MigratePrepare: properly cleanup after virDomainObjListAdd
  libxl: MigratePerform: properly cleanup after libxlDomObjFromDomain

 src/libxl/libxl_driver.c    | 40 ++++++++++++++++++++++------------------
 src/libxl/libxl_migration.c | 10 ++--------
 2 files changed, 24 insertions(+), 26 deletions(-)

-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] libxl: fix virDomainObj locking and ref counting in migration APIs

Posted by Michal Privoznik 6 years, 1 month ago

On 03/13/2018 06:26 PM, Jim Fehlig wrote:
> While reviewing a patch [0] from John's series to rework
> virDomainObjListFindBy{UUID|ID}Ref, I noticed several problems with locking
> and ref counting in the libxl migration APIs. This series changes the Begin,
> Prepare, Perform, and Confirm APIs to use the standard pattern of get a
> locked and ref counted virDomainObj, perform API, virDomainObjEndAPI.
> 
> [0] https://www.redhat.com/archives/libvir-list/2018-March/msg00516.html
> 
> Jim Fehlig (4):
>   libxl: MigrateBegin: Dont call EndAPI in helper function
>   libxl: MigrateConfirm: Dont unlock virDomainObj in helper function
>   libxl: MigratePrepare: properly cleanup after virDomainObjListAdd
>   libxl: MigratePerform: properly cleanup after libxlDomObjFromDomain
> 
>  src/libxl/libxl_driver.c    | 40 ++++++++++++++++++++++------------------
>  src/libxl/libxl_migration.c | 10 ++--------
>  2 files changed, 24 insertions(+), 26 deletions(-)
> 

ACK series.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list