From nobody Thu Apr 25 09:39:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520889132993715.0323512585944; Mon, 12 Mar 2018 14:12:12 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7FDB636807; Mon, 12 Mar 2018 21:12:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4238A60BEB; Mon, 12 Mar 2018 21:12:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E6A8B4CA99; Mon, 12 Mar 2018 21:12:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CLC8N2028700 for ; Mon, 12 Mar 2018 17:12:08 -0400 Received: by smtp.corp.redhat.com (Postfix) id C8A5417A70; Mon, 12 Mar 2018 21:12:08 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8671B608EE for ; Mon, 12 Mar 2018 21:12:08 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:11:48 -0400 Message-Id: <20180312211158.28343-2-jferlan@redhat.com> In-Reply-To: <20180312211158.28343-1-jferlan@redhat.com> References: <20180312211158.28343-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 01/11] virsh: Clean up formatting of the vol-create* commands X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 12 Mar 2018 21:12:12 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Clean up the formatting to make the output a bit more readable at least with respect to not having one paragraph of output. Each option will start on its own line. Signed-off-by: John Ferlan --- tools/virsh.pod | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 82de2cc45..52f45d721 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3948,10 +3948,13 @@ before the event. =3Ditem B I I [I<--prealloc-metadata>] =20 Create a volume from an XML . + I is the name or UUID of the storage pool to create the volu= me in. + I is the XML with the volume definition. An easy way to creat= e the XML is to use the B command to obtain the definition o= f a pre-existing volume. + [I<--prealloc-metadata>] preallocate metadata (for qcow2 images which don't support full allocation). This option creates a sparse image file with met= adata, resulting in higher performance compared to images with no preallocation a= nd @@ -3963,53 +3966,66 @@ B vi newvolume.xml (or make changes with your other text editor) virsh vol-create differentstoragepool newvolume.xml =20 -=3Ditem B I I [I<--inputpool> -I] I [I<--prealloc-metadata>] -[I<--reflink>] +=3Ditem B I I I +[I<--inputpool> I] [I<--prealloc-metadata>] [I<--reflink>] =20 Create a volume, using another volume as input. + I is the name or UUID of the storage pool to create the volu= me in. + I is the XML with the volume definition. + +I is the name or key or path of the source volume. + I<--inputpool> I is the name or uuid of the storage pool the source volume is in. -I is the name or key or path of the source volume. + [I<--prealloc-metadata>] preallocate metadata (for qcow2 images which don't support full allocation). This option creates a sparse image file with met= adata, resulting in higher performance compared to images with no preallocation a= nd only slightly higher initial disk space usage. + When I<--reflink> is specified, perform a COW lightweight copy, where the data blocks are copied only when modified. If this is not possible, the copy fails. =20 =3Ditem B I I I -[I<--allocation> I] [I<--format> I] [I<--backing-vol> -I] [I<--backing-vol-format> I] -[I<--prealloc-metadata>] [I<--print-xml>] +[I<--allocation> I] [I<--format> I] +[I<--backing-vol> I] +[I<--backing-vol-format> I] [I<--prealloc-metadata>] [I<--print-xm= l>] =20 Create a volume from a set of arguments unless I<--print-xml> is specified= , in which case just the XML of the volume object is printed out without any ac= tual object creation. + I is the name or UUID of the storage pool to create the volu= me in. + I is the name of the new volume. For a disk pool, this must match the partition name as determined from the pool's source device path and the ne= xt available partition. For example, a source device path of /dev/sdb and the= re are no partitions on the disk, then the name must be sdb1 with the next name being sdb2 and so on. + I is the size of the volume to be created, as a scaled integer (see B above), defaulting to bytes if there is no suffix. + I<--allocation> I is the initial size to be allocated in the volume, also as a scaled integer defaulting to bytes. + I<--format> I is used in file based storage pools to specify the v= olume file format to use; raw, bochs, qcow, qcow2, vmdk, qed. Use extended for d= isk storage pools in order to create an extended partition (other values are validity checked but not preserved when libvirtd is restarted or the pool is refreshed). + I<--backing-vol> I is the source backing volume to be used if taking a snapshot of an existing volume. + I<--backing-vol-format> I is the format of the snapshot backing vo= lume; raw, bochs, qcow, qcow2, qed, vmdk, host_device. These are, however, meant= for file based storage pools. + [I<--prealloc-metadata>] preallocate metadata (for qcow2 images which don't support full allocation). This option creates a sparse image file with met= adata, resulting in higher performance compared to images with no preallocation a= nd --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 09:39:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520889141788421.1692374113943; Mon, 12 Mar 2018 14:12:21 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2A5E428207; Mon, 12 Mar 2018 21:12:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E415217CC2; Mon, 12 Mar 2018 21:12:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9B08F181BA04; Mon, 12 Mar 2018 21:12:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CLC9pa028710 for ; Mon, 12 Mar 2018 17:12:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 40C7E608EE; Mon, 12 Mar 2018 21:12:09 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id F410717A70 for ; Mon, 12 Mar 2018 21:12:08 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:11:49 -0400 Message-Id: <20180312211158.28343-3-jferlan@redhat.com> In-Reply-To: <20180312211158.28343-1-jferlan@redhat.com> References: <20180312211158.28343-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 02/11] virsh: Fix man page argument ordering for vol-clone command X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 12 Mar 2018 21:12:20 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The proper command order is 'virsh vol-clone source-vol target-vol pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the source-vol could be found if the pool name was not provided. Signed-off-by: John Ferlan --- tools/virsh.pod | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 52f45d721..ff3b0729e 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4031,19 +4031,27 @@ support full allocation). This option creates a spa= rse image file with metadata, resulting in higher performance compared to images with no preallocation a= nd only slightly higher initial disk space usage. =20 -=3Ditem B [I<--pool> I] I -I [I<--prealloc-metadata>] [I<--reflink>] +=3Ditem B I I +[I<--pool> I] [I<--prealloc-metadata>] [I<--reflink>] =20 Clone an existing volume within the parent pool. Less powerful, but easier to type, version of B. -I<--pool> I is the name or UUID of the storage pool -that contains the source volume, and will contain the new volume. + I is the name or key or path of the source volume. + I is the name of the new volume. + +I<--pool> I is the name or UUID of the storage pool +that contains the source volume and will contain the new volume. +If the source volume name is provided instead of the key or path, then +providing the pool is necessary to find the volume to be cloned; otherwise, +the first volume found by the key or path will be used. + [I<--prealloc-metadata>] preallocate metadata (for qcow2 images which don't support full allocation). This option creates a sparse image file with met= adata, resulting in higher performance compared to images with no preallocation a= nd only slightly higher initial disk space usage. + When I<--reflink> is specified, perform a COW lightweight copy, where the data blocks are copied only when modified. If this is not possible, the copy fails. --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 09:39:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520889134336594.3028322978545; Mon, 12 Mar 2018 14:12:14 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0AAB9356E6; Mon, 12 Mar 2018 21:12:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D2C5F1712C; Mon, 12 Mar 2018 21:12:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6521F181BA00; Mon, 12 Mar 2018 21:12:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CLC90d028718 for ; Mon, 12 Mar 2018 17:12:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id B1B7317A70; Mon, 12 Mar 2018 21:12:09 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6B6E3608EE for ; Mon, 12 Mar 2018 21:12:09 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:11:50 -0400 Message-Id: <20180312211158.28343-4-jferlan@redhat.com> In-Reply-To: <20180312211158.28343-1-jferlan@redhat.com> References: <20180312211158.28343-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 03/11] virsh: Fix man page argument ordering for vol-delete command X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 12 Mar 2018 21:12:13 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The proper command order is 'virsh vol-delete volume pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan --- tools/virsh.pod | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index ff3b0729e..2d4416b44 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4056,13 +4056,18 @@ When I<--reflink> is specified, perform a COW light= weight copy, where the data blocks are copied only when modified. If this is not possible, the copy fails. =20 -=3Ditem B [I<--pool> I] I +=3Ditem B I [I<--pool> I] [I<--delete-snapshots>] =20 Delete a given volume. -I<--pool> I is the name or UUID of the storage pool the volu= me -is in. -I is the name or key or path of the volume to del= ete. + +I is the volume name or key or path of the volume +to delete. + +[I<--pool> I] is the name or UUID of the storage pool the vo= lume +is in. If the volume name is provided instead of the key or path, then +providing the pool is necessary to find the volume to be deleted; otherwis= e, +the first volume found by the key or path will be used. =20 The I<--delete-snapshots> flag specifies that any snapshots associated with the storage volume should be deleted as well. Not all storage drivers --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 09:39:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520889146506126.73813695400793; Mon, 12 Mar 2018 14:12:26 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 79EF48762F; Mon, 12 Mar 2018 21:12:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 51C1817493; Mon, 12 Mar 2018 21:12:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E0AFE180BAD8; Mon, 12 Mar 2018 21:12:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CLCDJo028745 for ; Mon, 12 Mar 2018 17:12:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2EF0A17AB4; Mon, 12 Mar 2018 21:12:13 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE2DF608EE for ; Mon, 12 Mar 2018 21:12:09 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:11:51 -0400 Message-Id: <20180312211158.28343-5-jferlan@redhat.com> In-Reply-To: <20180312211158.28343-1-jferlan@redhat.com> References: <20180312211158.28343-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 04/11] virsh: Fix man page argument ordering for vol-upload command X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 12 Mar 2018 21:12:25 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The proper command order is 'virsh vol-upload volume file pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan --- tools/virsh.pod | 33 ++++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 2d4416b44..db871db9e 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4073,21 +4073,32 @@ The I<--delete-snapshots> flag specifies that any s= napshots associated with the storage volume should be deleted as well. Not all storage drivers support this option, presently only rbd. =20 -=3Ditem B [I<--pool> I] [I<--offset> I] -[I<--length> I] [I<--sparse>] I I +=3Ditem B I I +[I<--pool> I] [I<--offset> I] +[I<--length> I] [I<--sparse>] =20 Upload the contents of I to a storage volume. -I<--pool> I is the name or UUID of the storage pool the volu= me -is in. + I is the name or key or path of the volume where = the -file will be uploaded. -If I<--sparse> is specified, this command will preserve volume sparseness. +I will be uploaded. + +I<--pool> I is the name or UUID of the storage pool the volu= me +is in. If the volume name is provided instead of the key or path, then +providing the pool is necessary to find the volume to be uploaded into; +otherwise, the first volume found by the key or path will be used. + I<--offset> is the position in the storage volume at which to start writing -the data. The value must be 0 or larger. I<--length> is an upper bound -of the amount of data to be uploaded. A negative value is interpreted -as an unsigned long long value to essentially include everything from -the offset to the end of the volume. -An error will occur if the I is greater than the specified len= gth. +the data. The value must be 0 or larger. + +I<--length> is an upper bound of the amount of data to be uploaded. +A negative value is interpreted as an unsigned long long value to +essentially include everything from the offset to the end of the volume. + +If I<--sparse> is specified, this command will preserve volume sparseness. + +An error will occur if the I is greater than the specified +I. + See the description for the libvirt virStorageVolUpload API for details regarding possible target volume and pool changes as a result of the pool refresh when the upload is attempted. --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 09:39:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520889141461392.15685652743196; Mon, 12 Mar 2018 14:12:21 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 09E3828208; Mon, 12 Mar 2018 21:12:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5B9160F82; Mon, 12 Mar 2018 21:12:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9B3EA4CA9C; Mon, 12 Mar 2018 21:12:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CLCD8i028751 for ; Mon, 12 Mar 2018 17:12:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id 97C9317AB4; Mon, 12 Mar 2018 21:12:13 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 550F1608EE for ; Mon, 12 Mar 2018 21:12:13 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:11:52 -0400 Message-Id: <20180312211158.28343-6-jferlan@redhat.com> In-Reply-To: <20180312211158.28343-1-jferlan@redhat.com> References: <20180312211158.28343-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 05/11] virsh: Fix man page argument ordering for vol-download command X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 12 Mar 2018 21:12:20 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The proper command order is 'virsh vol-download volume file pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan --- tools/virsh.pod | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index db871db9e..d8cc64f36 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4103,19 +4103,28 @@ See the description for the libvirt virStorageVolUp= load API for details regarding possible target volume and pool changes as a result of the pool refresh when the upload is attempted. =20 -=3Ditem B [I<--pool> I] [I<--offset> I] -[I<--length> I] [I<--sparse>] I I +=3Ditem B I I +[I<--pool> I] [I<--offset> I] [I<--length> I] +[I<--sparse>] =20 Download the contents of a storage volume to I. + +I is the name or key or path of the volume to +download into I. + I<--pool> I is the name or UUID of the storage pool the volu= me -is in. -I is the name or key or path of the volume to dow= nload. -If I<--sparse> is specified, this command will preserve volume sparseness. +is in. If the volume name is provided instead of the key or path, then +providing the pool is necessary to find the volume to be uploaded into; +otherwise, the first volume found by the key or path will be used. + I<--offset> is the position in the storage volume at which to start reading -the data. The value must be 0 or larger. I<--length> is an upper bound of -the amount of data to be downloaded. A negative value is interpreted as -an unsigned long long value to essentially include everything from the -offset to the end of the volume. +the data. The value must be 0 or larger. + +I<--length> is an upper bound of the amount of data to be downloaded. +A negative value is interpreted as an unsigned long long value to +essentially include everything from the offset to the end of the volume. + +If I<--sparse> is specified, this command will preserve volume sparseness. =20 =3Ditem B [I<--pool> I] [I<--algorithm> I] I --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 09:39:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520889149349256.1613693774966; Mon, 12 Mar 2018 14:12:29 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D9405C036779; Mon, 12 Mar 2018 21:12:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B272512A59; Mon, 12 Mar 2018 21:12:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7DEA14CAA0; Mon, 12 Mar 2018 21:12:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CLCExB028758 for ; Mon, 12 Mar 2018 17:12:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 147FC608EE; Mon, 12 Mar 2018 21:12:14 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id C035617AB4 for ; Mon, 12 Mar 2018 21:12:13 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:11:53 -0400 Message-Id: <20180312211158.28343-7-jferlan@redhat.com> In-Reply-To: <20180312211158.28343-1-jferlan@redhat.com> References: <20180312211158.28343-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 06/11] virsh: Fix man page argument ordering for vol-wipe command X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 12 Mar 2018 21:12:28 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The proper command order is 'virsh vol-wipe volume pool algorithm'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan --- tools/virsh.pod | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index d8cc64f36..24177e407 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4126,15 +4126,23 @@ essentially include everything from the offset to t= he end of the volume. =20 If I<--sparse> is specified, this command will preserve volume sparseness. =20 -=3Ditem B [I<--pool> I] [I<--algorithm> I] -I +=3Ditem B I [I<--pool> I] +[I<--algorithm> I] =20 Wipe a volume, ensure data previously on the volume is not accessible to -future reads. I<--pool> I is the name or UUID of the storage -pool the volume is in. +future reads. + I is the name or key or path of the volume to wip= e. It is possible to choose different wiping algorithms instead of re-writing -volume with zeroes. This can be done via I<--algorithm> switch. +volume with zeroes. + +I<--pool> I is the name or UUID of the storage pool the +volume is in. If the volume name is provided instead of the key or path, +then providing the pool is necessary to find the volume to be wiped; +otherwise, the first volume found by the key or path will be used. + +Use the I<--algorithm> switch choosing from the list of the following +algorithms in order to define which algorithm to use for the wipe. =20 B zero - 1-pass all zeroes --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 09:39:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520889152760929.2577055210561; Mon, 12 Mar 2018 14:12:32 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4A9E5C0587C1; Mon, 12 Mar 2018 21:12:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14C1C17A9B; Mon, 12 Mar 2018 21:12:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CEB4D4CAAA; Mon, 12 Mar 2018 21:12:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CLCEGt028763 for ; Mon, 12 Mar 2018 17:12:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7F0F2608EE; Mon, 12 Mar 2018 21:12:14 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E64517A9B for ; Mon, 12 Mar 2018 21:12:14 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:11:54 -0400 Message-Id: <20180312211158.28343-8-jferlan@redhat.com> In-Reply-To: <20180312211158.28343-1-jferlan@redhat.com> References: <20180312211158.28343-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 07/11] virsh: Fix man page argument ordering for vol-dumpxml command X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 12 Mar 2018 21:12:31 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The proper command order is 'virsh vol-dumpxml volume pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan --- tools/virsh.pod | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 24177e407..135cce841 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4178,12 +4178,17 @@ it expects the storage driver to be able to discard= all bytes in a volume. It is up to the storage driver to handle how the discarding occurs. Not all storage drivers or volume types can support 'trim'. =20 -=3Ditem B [I<--pool> I] I +=3Ditem B I [I<--pool> I] =20 Output the volume information as an XML dump to stdout. + +I is the name or key or path of the volume +to output the XML. + I<--pool> I is the name or UUID of the storage pool the volu= me -is in. I is the name or key or path of the volume -to output the XML of. +is in. If the volume name is provided instead of the key or path, then +providing the pool is necessary to find the volume to be uploaded into; +otherwise, the first volume found by the key or path will be used. =20 =3Ditem B [I<--pool> I] I [I<--bytes>] [I<--physical>] --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 09:39:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520889145384908.3693192021728; Mon, 12 Mar 2018 14:12:25 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 91A8D80515; Mon, 12 Mar 2018 21:12:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 561E117581; Mon, 12 Mar 2018 21:12:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1DF374CAA1; Mon, 12 Mar 2018 21:12:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CLCENe028769 for ; Mon, 12 Mar 2018 17:12:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id E956717AD6; Mon, 12 Mar 2018 21:12:14 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id A78D6608EE for ; Mon, 12 Mar 2018 21:12:14 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:11:55 -0400 Message-Id: <20180312211158.28343-9-jferlan@redhat.com> In-Reply-To: <20180312211158.28343-1-jferlan@redhat.com> References: <20180312211158.28343-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 08/11] virsh: Fix man page argument ordering for vol-info command X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 12 Mar 2018 21:12:24 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The proper command order is 'virsh vol-info volume pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan --- tools/virsh.pod | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 135cce841..cd1ccc6fa 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4190,17 +4190,26 @@ is in. If the volume name is provided instead of th= e key or path, then providing the pool is necessary to find the volume to be uploaded into; otherwise, the first volume found by the key or path will be used. =20 -=3Ditem B [I<--pool> I] I +=3Ditem B I [I<--pool> I] [I<--bytes>] [I<--physical>] =20 Returns basic information about the given storage volume. + +I is the name or key or path of the volume +to return information for. + I<--pool> I is the name or UUID of the storage pool the volu= me -is in. I is the name or key or path of the volume -to return information for. If I<--bytes> is specified the sizes are not -converted to human friendly units. If I<--physical> is specified, then the= host -physical size is returned and displayed instead of the allocation value. T= he -physical value for some file types, such as qcow2 may have a different (la= rger) -physical value than is shown for allocation. Additionally sparse files will +is in. If the volume name is provided instead of the key or path, then +providing the pool is necessary to find the volume to be uploaded into; +otherwise, the first volume found by the key or path will be used. + +If I<--bytes> is specified the sizes are not converted to human friendly +units. + +If I<--physical> is specified, then the host physical size is returned +and displayed instead of the allocation value. The physical value for +some file types, such as qcow2 may have a different (larger) physical +value than is shown for allocation. Additionally sparse files will have different physical and allocation values. =20 =3Ditem B [I<--pool> I] [I<--details>] --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 09:39:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520889148184141.74582803412602; Mon, 12 Mar 2018 14:12:28 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 019F6C036753; Mon, 12 Mar 2018 21:12:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC35C17572; Mon, 12 Mar 2018 21:12:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8E92D180BAD9; Mon, 12 Mar 2018 21:12:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CLCFRj028778 for ; Mon, 12 Mar 2018 17:12:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5F68317AD6; Mon, 12 Mar 2018 21:12:15 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C5EC608EE for ; Mon, 12 Mar 2018 21:12:15 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:11:56 -0400 Message-Id: <20180312211158.28343-10-jferlan@redhat.com> In-Reply-To: <20180312211158.28343-1-jferlan@redhat.com> References: <20180312211158.28343-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 09/11] virsh: Clean up man page formatting for vol-list and vol-pool X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 12 Mar 2018 21:12:27 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Make the output more readable. Signed-off-by: John Ferlan --- tools/virsh.pod | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index cd1ccc6fa..1b59251bf 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4215,16 +4215,21 @@ have different physical and allocation values. =3Ditem B [I<--pool> I] [I<--details>] =20 Return the list of volumes in the given storage pool. + I<--pool> I is the name or UUID of the storage pool. + The I<--details> option instructs virsh to additionally display volume type and capacity related information where available. =20 -=3Ditem B [I<--uuid>] I +=3Ditem B I [I<--uuid>] =20 Return the pool name or UUID for a given volume. By default, the pool name= is -returned. If the I<--uuid> option is given, the pool UUID is returned inst= ead. +returned. + I is the key or path of the volume to return the pool -information for. +information. + +If the I<--uuid> option is given, the pool UUID is returned instead. =20 =3Ditem B [I<--pool> I] I =20 --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 09:39:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520889142178262.7631553232999; Mon, 12 Mar 2018 14:12:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3BA3E28210; Mon, 12 Mar 2018 21:12:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D8BE17D38; Mon, 12 Mar 2018 21:12:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BF63D4CA9D; Mon, 12 Mar 2018 21:12:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CLCFbY028791 for ; Mon, 12 Mar 2018 17:12:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id EC631608EE; Mon, 12 Mar 2018 21:12:15 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id A69F617AD6 for ; Mon, 12 Mar 2018 21:12:15 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:11:57 -0400 Message-Id: <20180312211158.28343-11-jferlan@redhat.com> In-Reply-To: <20180312211158.28343-1-jferlan@redhat.com> References: <20180312211158.28343-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 10/11] virsh: Fix man page argument ordering for vol-{path|name|key} commands X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 12 Mar 2018 21:12:20 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The proper command order is 'virsh vol-path volume pool', or 'virsh vol-name volume pool', or 'virsh vol-key volume'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan --- tools/virsh.pod | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 1b59251bf..366a628f9 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4231,24 +4231,34 @@ information. =20 If the I<--uuid> option is given, the pool UUID is returned instead. =20 -=3Ditem B [I<--pool> I] I +=3Ditem B I [I<--pool> I] =20 Return the path for a given volume. + +I is the name or key of the volume to return the path. + I<--pool> I is the name or UUID of the storage pool the volu= me -is in. -I is the name or key of the volume to return the path for. +is in. If the volume name is provided instead of the key, then providing +the pool is necessary to find the volume to be uploaded into; otherwise, +the first volume found by the key will be used. =20 =3Ditem B I =20 Return the name for a given volume. -I is the key or path of the volume to return the name for. =20 -=3Ditem B [I<--pool> I] I +I is the key or path of the volume to return the name. + +=3Ditem B I [I<--pool> I] =20 Return the volume key for a given volume. + +I is the name or path of the volume to return the +volume key. + I<--pool> I is the name or UUID of the storage pool the volu= me -is in. I is the name or path of the volume to return the -volume key for. +is in. If the volume name is provided instead of the path, then providing +the pool is necessary to find the volume to be uploaded into; otherwise, +the first volume found by the path will be used. =20 =3Ditem B I I [I<--pool> I] [I<--allocate>] [I<--delta>] [I<--shrink>] --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 09:39:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520889152190356.0549066068879; Mon, 12 Mar 2018 14:12:32 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D43482820C; Mon, 12 Mar 2018 21:12:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AB7E760474; Mon, 12 Mar 2018 21:12:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 44C534CAA6; Mon, 12 Mar 2018 21:12:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CLCGec028800 for ; Mon, 12 Mar 2018 17:12:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 658CE17CC2; Mon, 12 Mar 2018 21:12:16 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 23A9317AD6 for ; Mon, 12 Mar 2018 21:12:16 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:11:58 -0400 Message-Id: <20180312211158.28343-12-jferlan@redhat.com> In-Reply-To: <20180312211158.28343-1-jferlan@redhat.com> References: <20180312211158.28343-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 11/11] tools: Clean up the vol-resize man page X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 12 Mar 2018 21:12:31 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Instead of appearing as one long paragraph, split the output to list each command option on its own line for better readability. Signed-off-by: John Ferlan --- tools/virsh.pod | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 366a628f9..d3ae7bb5d 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4264,17 +4264,29 @@ the first volume found by the path will be used. [I<--allocate>] [I<--delta>] [I<--shrink>] =20 Resize the capacity of the given volume, in bytes. + +I is the name or key or path of the volume +to resize. + +I is a scaled integer (see B above) for the volume, +which defaults to bytes if there is no suffix. + I<--pool> I is the name or UUID of the storage pool the volu= me -is in. I is the name or key or path of the volume -to resize. The new capacity might be sparse unless I<--allocate> is -specified. Normally, I is the new size, but if I<--delta> -is present, then it is added to the existing size. Attempts to shrink -the volume will fail unless I<--shrink> is present; I cannot -be negative unless I<--shrink> is provided, but a negative sign is not -necessary. I is a scaled integer (see B above), which -defaults to bytes if there is no suffix. This command is only safe -for storage volumes not in use by an active guest; see also -B for live resizing. +is in. If the volume name is provided instead of the key or path, then +providing the pool is necessary to find the volume to be uploaded into; +otherwise, the first volume found by the key or path will be used. + +The new I might be sparse unless I<--allocate> is specified. + +Normally, I is the new size, but if I<--delta> +is present, then it is added to the existing size. + +Attempts to shrink the volume will fail unless I<--shrink> is present. +The I cannot be negative unless I<--shrink> is provided, but +a negative sign is not necessary. + +This command is only safe for storage volumes not in use by an active +guest; see also B for live resizing. =20 =3Dback =20 --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list