From nobody Sun Apr 28 12:28:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520264447833931.19642325643; Mon, 5 Mar 2018 07:40:47 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BF92B7ECF1; Mon, 5 Mar 2018 15:40:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAF8C5C57C; Mon, 5 Mar 2018 15:40:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 08A384A46F; Mon, 5 Mar 2018 15:40:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w25Fef1g027572 for ; Mon, 5 Mar 2018 10:40:41 -0500 Received: by smtp.corp.redhat.com (Postfix) id D936118227; Mon, 5 Mar 2018 15:40:41 +0000 (UTC) Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB1934C48E for ; Mon, 5 Mar 2018 15:40:06 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 040955D5F4 for ; Mon, 5 Mar 2018 15:39:55 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 53C502111B; Mon, 5 Mar 2018 10:39:54 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Mon, 05 Mar 2018 10:39:54 -0500 Received: from localhost (afel46.neoplus.adsl.tpnet.pl [95.49.115.46]) by mail.messagingengine.com (Postfix) with ESMTPA id C974C7E539; Mon, 5 Mar 2018 10:39:53 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=JW8HNyMBMwOG0wvfqgWA66P2cCuZCK5l2CkZe0e79RE=; b=OCgJNS0h yR2CUSuQUxpO+5Jd+UMpwYbLt2Y6uUlDPHAIOP3jIZewVMWTw8orEKaZj9aYR+Dh f+JTiTTfsE8c+BDyyl8XbzhotmhTjQQVogPpCCyRAe1VovNU8GMCa2+wlTfnDZpQ 0hhiWInfucD+QfmUqgkxSyMhVngszxG83KsCvneIZ/C/urIf/BjiK6uuKJjEYDFT U5JQ2yBtPygCapPbwzW2ErRBtcaKfcuIGwixHMnh+E/yKg1o6VhWvI0DzgZj4umH BUOrGrFouJHGWp2sIJJ4gnD1FNLkUnAR7NzaErn21m5/H5bh7ue/ev2+bamfjl88 mVx2ejeT/b0vLw== X-ME-Sender: From: Jan Palus To: libvir-list@redhat.com Date: Mon, 5 Mar 2018 16:39:48 +0100 Message-Id: <20180305153948.12230-1-atler@pld-linux.org> In-Reply-To: <20180305152448.GX17368@redhat.com> References: <20180305152448.GX17368@redhat.com> X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 207 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 05 Mar 2018 15:39:55 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 05 Mar 2018 15:39:55 +0000 (UTC) for IP:'66.111.4.29' DOMAIN:'out5-smtp.messagingengine.com' HELO:'out5-smtp.messagingengine.com' FROM:'jpalus@fastmail.com' RCPT:'' X-RedHat-Spam-Score: 0.498 (DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, SPF_HELO_PASS, SPF_PASS) 66.111.4.29 out5-smtp.messagingengine.com 66.111.4.29 out5-smtp.messagingengine.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Jan Palus Subject: [libvirt] [PATCH v3] make sure libvirt is linked first X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 05 Mar 2018 15:40:46 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" so it's not affected by flags that might be passed in $(*_LIBS) like -L/usr/lib which might result in linking against system library and requiring incorrect version of private symbols Signed-off-by: Jan Palus Reviewed-by: Daniel P. Berrang=C3=A9 --- src/Makefile.am | 29 +++++++++++++++-------------- src/lxc/Makefile.inc.am | 2 +- tools/Makefile.am | 2 +- 3 files changed, 17 insertions(+), 16 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 3bf2da5..7f3144b 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1153,6 +1153,9 @@ libvirtd_LDFLAGS =3D \ $(NULL) =20 libvirtd_LDADD =3D \ + libvirt-lxc.la \ + libvirt-qemu.la \ + libvirt.la \ $(LIBXML_LIBS) \ $(GNUTLS_LIBS) \ $(SASL_LIBS) \ @@ -1166,9 +1169,6 @@ endif WITH_DTRACE_PROBES =20 libvirtd_LDADD +=3D \ libvirt_driver_admin.la \ - libvirt-lxc.la \ - libvirt-qemu.la \ - libvirt.la \ ../gnulib/lib/libgnu.la $(LIBSOCKET) \ $(NULL) =20 @@ -1222,7 +1222,7 @@ libvirt_driver_interface_la_CFLAGS =3D \ -I$(srcdir)/conf \ $(AM_CFLAGS) $(LIBNL_CFLAGS) libvirt_driver_interface_la_LDFLAGS =3D $(AM_LDFLAGS_MOD_NOUNDEF) -libvirt_driver_interface_la_LIBADD =3D +libvirt_driver_interface_la_LIBADD =3D libvirt.la if WITH_NETCF libvirt_driver_interface_la_CFLAGS +=3D $(NETCF_CFLAGS) libvirt_driver_interface_la_LIBADD +=3D $(NETCF_LIBS) @@ -1231,7 +1231,7 @@ if WITH_UDEV libvirt_driver_interface_la_CFLAGS +=3D $(UDEV_CFLAGS) libvirt_driver_interface_la_LIBADD +=3D $(UDEV_LIBS) endif WITH_UDEV -libvirt_driver_interface_la_LIBADD +=3D libvirt.la ../gnulib/lib/libgnu.la +libvirt_driver_interface_la_LIBADD +=3D ../gnulib/lib/libgnu.la libvirt_driver_interface_la_SOURCES =3D $(INTERFACE_DRIVER_SOURCES) endif WITH_INTERFACE =20 @@ -1323,7 +1323,7 @@ endif WITH_STORAGE_SCSI if WITH_STORAGE_MPATH libvirt_storage_backend_mpath_la_SOURCES =3D \ $(STORAGE_DRIVER_MPATH_SOURCES) -libvirt_storage_backend_mpath_la_LIBADD =3D $(DEVMAPPER_LIBS) +libvirt_storage_backend_mpath_la_LIBADD =3D libvirt.la $(DEVMAPPER_LIBS) libvirt_storage_backend_mpath_la_CFLAGS =3D \ -I$(srcdir)/conf \ $(DEVMAPPER_CFLAGS) \ @@ -1331,7 +1331,7 @@ libvirt_storage_backend_mpath_la_CFLAGS =3D \ =20 storagebackend_LTLIBRARIES +=3D libvirt_storage_backend_mpath.la libvirt_storage_backend_mpath_la_LDFLAGS =3D $(AM_LDFLAGS_MOD) -libvirt_storage_backend_mpath_la_LIBADD +=3D libvirt.la ../gnulib/lib/libg= nu.la +libvirt_storage_backend_mpath_la_LIBADD +=3D ../gnulib/lib/libgnu.la endif WITH_STORAGE_MPATH =20 if WITH_STORAGE_DISK @@ -1347,7 +1347,7 @@ endif WITH_STORAGE_DISK =20 if WITH_STORAGE_RBD libvirt_storage_backend_rbd_la_SOURCES =3D $(STORAGE_DRIVER_RBD_SOURCES) -libvirt_storage_backend_rbd_la_LIBADD =3D $(LIBRBD_LIBS) +libvirt_storage_backend_rbd_la_LIBADD =3D libvirt.la $(LIBRBD_LIBS) libvirt_storage_backend_rbd_la_CFLAGS =3D \ -I$(srcdir)/conf \ -I$(srcdir)/secret \ @@ -1355,7 +1355,7 @@ libvirt_storage_backend_rbd_la_CFLAGS =3D \ =20 storagebackend_LTLIBRARIES +=3D libvirt_storage_backend_rbd.la libvirt_storage_backend_rbd_la_LDFLAGS =3D $(AM_LDFLAGS_MOD) -libvirt_storage_backend_rbd_la_LIBADD +=3D libvirt.la ../gnulib/lib/libgnu= .la +libvirt_storage_backend_rbd_la_LIBADD +=3D ../gnulib/lib/libgnu.la endif WITH_STORAGE_RBD =20 if WITH_STORAGE_SHEEPDOG @@ -1380,7 +1380,7 @@ endif WITH_STORAGE_SHEEPDOG if WITH_STORAGE_GLUSTER libvirt_storage_backend_gluster_la_SOURCES =3D \ $(STORAGE_DRIVER_GLUSTER_SOURCES) -libvirt_storage_backend_gluster_la_LIBADD =3D $(GLUSTERFS_LIBS) +libvirt_storage_backend_gluster_la_LIBADD =3D libvirt.la $(GLUSTERFS_LIBS) libvirt_storage_backend_gluster_la_CFLAGS =3D \ -I$(srcdir)/conf \ $(GLUSTERFS_CFLAGS) \ @@ -1388,7 +1388,7 @@ libvirt_storage_backend_gluster_la_CFLAGS =3D \ =20 storagebackend_LTLIBRARIES +=3D libvirt_storage_backend_gluster.la libvirt_storage_backend_gluster_la_LDFLAGS =3D $(AM_LDFLAGS_MOD) -libvirt_storage_backend_gluster_la_LIBADD +=3D libvirt.la ../gnulib/lib/li= bgnu.la +libvirt_storage_backend_gluster_la_LIBADD +=3D ../gnulib/lib/libgnu.la endif WITH_STORAGE_GLUSTER =20 if WITH_STORAGE_ZFS @@ -1424,7 +1424,7 @@ libvirt_driver_nodedev_la_CFLAGS =3D \ -I$(srcdir)/conf \ $(AM_CFLAGS) $(LIBNL_CFLAGS) libvirt_driver_nodedev_la_LDFLAGS =3D $(AM_LDFLAGS_MOD_NOUNDEF) -libvirt_driver_nodedev_la_LIBADD =3D +libvirt_driver_nodedev_la_LIBADD =3D libvirt.la =20 if WITH_HAL libvirt_driver_nodedev_la_SOURCES +=3D $(NODE_DEVICE_DRIVER_HAL_SOURCES) @@ -1437,7 +1437,7 @@ libvirt_driver_nodedev_la_CFLAGS +=3D $(UDEV_CFLAGS) = $(PCIACCESS_CFLAGS) libvirt_driver_nodedev_la_LIBADD +=3D $(UDEV_LIBS) $(PCIACCESS_LIBS) endif WITH_UDEV =20 -libvirt_driver_nodedev_la_LIBADD +=3D libvirt.la ../gnulib/lib/libgnu.la +libvirt_driver_nodedev_la_LIBADD +=3D ../gnulib/lib/libgnu.la endif WITH_NODE_DEVICES =20 =20 @@ -1456,10 +1456,11 @@ libvirt_driver_nwfilter_impl_la_CFLAGS =3D \ $(AM_CFLAGS) libvirt_driver_nwfilter_impl_la_LDFLAGS =3D $(AM_LDFLAGS) libvirt_driver_nwfilter_impl_la_LIBADD =3D \ + libvirt.la \ $(LIBPCAP_LIBS) \ $(LIBNL_LIBS) \ $(DBUS_LIBS) -libvirt_driver_nwfilter_impl_la_LIBADD +=3D libvirt.la ../gnulib/lib/libgn= u.la +libvirt_driver_nwfilter_impl_la_LIBADD +=3D ../gnulib/lib/libgnu.la libvirt_driver_nwfilter_impl_la_SOURCES =3D $(NWFILTER_DRIVER_SOURCES) endif WITH_NWFILTER =20 diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am index 8a3d4c4..8dd2e9e 100644 --- a/src/lxc/Makefile.inc.am +++ b/src/lxc/Makefile.inc.am @@ -121,8 +121,8 @@ libvirt_lxc_LDFLAGS =3D \ $(LIBXML_LIBS) \ $(NULL) libvirt_lxc_LDADD =3D \ - $(FUSE_LIBS) \ libvirt.la \ + $(FUSE_LIBS) \ ../gnulib/lib/libgnu.la \ $(NULL) if WITH_DTRACE_PROBES diff --git a/tools/Makefile.am b/tools/Makefile.am index 85e640b..1452d98 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -139,9 +139,9 @@ libvirt_shell_la_LDFLAGS =3D \ $(COVERAGE_LDFLAGS) \ $(NULL) libvirt_shell_la_LIBADD =3D \ + ../src/libvirt.la \ $(LIBXML_LIBS) \ $(READLINE_LIBS) \ - ../src/libvirt.la \ ../gnulib/lib/libgnu.la \ $(NULL) libvirt_shell_la_SOURCES =3D vsh.c vsh.h --=20 2.16.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list