[libvirt] [PATCH v4 00/11] qemu: Validate PCI controller options

Andrea Bolognani posted 11 patches 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180227164618.31590-1-abologna@redhat.com
Test syntax-check passed
There is a newer version of this series
src/qemu/qemu_domain.c                         | 594 ++++++++++++++++++-------
tests/qemuxml2argvdata/pcie-expander-bus.xml   |   3 -
tests/qemuxml2xmloutdata/pcie-expander-bus.xml |   4 +-
3 files changed, 440 insertions(+), 161 deletions(-)
[libvirt] [PATCH v4 00/11] qemu: Validate PCI controller options
Posted by Andrea Bolognani 6 years ago
Applies cleanly on top of e1ab81b339c4d631b704290c26caa0af6882527c.

Changes from [v3]:

  * don't introduce new test cases that won't be able to provide
    full test coverage anyway, as suggested by laine.

Changes from [v2]:

  * replace the old implementation bit by bit using a clever trick
    suggested by pkrempa;
  * don't move QEMU capability validation;
  * add a default: label to all switch statements as recommended
    by danpb.

Changes from [v1]:

  * error out instead of silently accept invalid options;
  * shave quite a lot of yaks.

[v3] https://www.redhat.com/archives/libvir-list/2018-February/msg00996.html
[v2] https://www.redhat.com/archives/libvir-list/2018-February/msg00813.html
[v1] https://www.redhat.com/archives/libvir-list/2018-February/msg00244.html

Andrea Bolognani (11):
  qemu: Create new qemuDomainDeviceDefValidateControllerPCI()
  qemu: Validate PCI controller options (modelName)
  qemu: Validate PCI controller options (index)
  qemu: Validate PCI controller options (targetIndex)
  qemu: Validate PCI controller options (pcihole64)
  qemu: Validate PCI controller options (busNr)
  qemu: Validate PCI controller options (numaNode)
  qemu: Validate PCI controller options (chassisNr)
  qemu: Validate PCI controller options (chassis and port)
  qemu: Validate PCI controllers (QEMU capabilities)
  qemu: Remove old qemuDomainDeviceDefValidateControllerPCI()

 src/qemu/qemu_domain.c                         | 594 ++++++++++++++++++-------
 tests/qemuxml2argvdata/pcie-expander-bus.xml   |   3 -
 tests/qemuxml2xmloutdata/pcie-expander-bus.xml |   4 +-
 3 files changed, 440 insertions(+), 161 deletions(-)

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list