From nobody Thu May 2 03:16:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1518470780267635.2284377132712; Mon, 12 Feb 2018 13:26:20 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 05D97C057875; Mon, 12 Feb 2018 21:26:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C43A2600D1; Mon, 12 Feb 2018 21:26:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7B42C18033E1; Mon, 12 Feb 2018 21:26:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w1CLO9JU024859 for ; Mon, 12 Feb 2018 16:24:09 -0500 Received: by smtp.corp.redhat.com (Postfix) id B10BEDEEDC; Mon, 12 Feb 2018 21:24:09 +0000 (UTC) Received: from cv1.lan (ovpn-120-237.rdu2.redhat.com [10.10.120.237]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D750DA69B; Mon, 12 Feb 2018 21:24:09 +0000 (UTC) From: Chris Venteicher To: libvir-list@redhat.com Date: Mon, 12 Feb 2018 15:24:03 -0600 Message-Id: <20180212212403.22099-2-cventeic@redhat.com> In-Reply-To: <20180212212403.22099-1-cventeic@redhat.com> References: <20180212212403.22099-1-cventeic@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Chris Venteicher Subject: [libvirt] [PATCHv2 1/1] include: function parameter names same in declaration X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 12 Feb 2018 21:26:19 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Headers use same function parameter names as definition code. In some cases in libvirt-domain and libvirt-network an established naming pattern in the header files was more consistent and informative in which case the implementation was modified in the c file. --- include/libvirt/libvirt-domain.h | 18 +++++++------- include/libvirt/libvirt-event.h | 4 ++-- include/libvirt/libvirt-host.h | 4 ++-- include/libvirt/libvirt-network.h | 4 ++-- include/libvirt/libvirt-nwfilter.h | 2 +- include/libvirt/libvirt-qemu.h | 2 +- include/libvirt/libvirt-secret.h | 4 ++-- include/libvirt/libvirt-storage.h | 12 +++++----- include/libvirt/libvirt-stream.h | 22 ++++++++--------- src/libvirt-domain.c | 48 +++++++++++++++++++---------------= ---- src/libvirt-network.c | 10 ++++---- 11 files changed, 65 insertions(+), 65 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-dom= ain.h index 4048acf38..0f905bc24 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1109,7 +1109,7 @@ virDomainPtr virDomainLookupByID (virC= onnectPtr conn, virDomainPtr virDomainLookupByUUID (virConnectPtr conn, const unsigned char *uuid= ); virDomainPtr virDomainLookupByUUIDString (virConnectPtr con= n, - const char *uuid); + const char *uuids= tr); =20 typedef enum { VIR_DOMAIN_SHUTDOWN_DEFAULT =3D 0, /* hypervisor choice = */ @@ -1626,11 +1626,11 @@ int virDomainInterfaceStats (vi= rDomainPtr dom, */ # define VIR_DOMAIN_BANDWIDTH_OUT_BURST "outbound.burst" =20 -int virDomainSetInterfaceParameters (virDomainPtr dom, +int virDomainSetInterfaceParameters (virDomainPtr doma= in, const char *devic= e, virTypedParameter= Ptr params, int nparams, unsi= gned int flags); -int virDomainGetInterfaceParameters (virDomainPtr dom, +int virDomainGetInterfaceParameters (virDomainPtr doma= in, const char *devic= e, virTypedParameter= Ptr params, int *nparams, uns= igned int flags); @@ -1697,7 +1697,7 @@ struct _virDomainBlockInfo { * offset, similar to 'ls')*/ }; =20 -int virDomainGetBlockInfo(virDomainPtr dom, +int virDomainGetBlockInfo(virDomainPtr domain, const char *disk, virDomainBlockInfoPtr info, unsigned int flags); @@ -1869,7 +1869,7 @@ int virDomainPinEmulator (virDo= mainPtr domain, unsigned int flags); =20 int virDomainGetEmulatorPinInfo (virDomainPtr domain, - unsigned char *cpumap= s, + unsigned char *cpumap, int maplen, unsigned int flags); =20 @@ -2298,11 +2298,11 @@ void virDomainStatsRecordListFree(virDomainStatsRec= ordPtr *stats); */ # define VIR_PERF_PARAM_EMULATION_FAULTS "emulation_faults" =20 -int virDomainGetPerfEvents(virDomainPtr dom, +int virDomainGetPerfEvents(virDomainPtr domain, virTypedParameterPtr *params, int *nparams, unsigned int flags); -int virDomainSetPerfEvents(virDomainPtr dom, +int virDomainSetPerfEvents(virDomainPtr domain, virTypedParameterPtr params, int nparams, unsigned int flags); @@ -3130,14 +3130,14 @@ typedef enum { * completed job */ } virDomainGetJobStatsFlags; =20 -int virDomainGetJobInfo(virDomainPtr dom, +int virDomainGetJobInfo(virDomainPtr domain, virDomainJobInfoPtr info); int virDomainGetJobStats(virDomainPtr domain, int *type, virTypedParameterPtr *params, int *nparams, unsigned int flags); -int virDomainAbortJob(virDomainPtr dom); +int virDomainAbortJob(virDomainPtr domain); =20 typedef enum { VIR_DOMAIN_JOB_OPERATION_UNKNOWN =3D 0, diff --git a/include/libvirt/libvirt-event.h b/include/libvirt/libvirt-even= t.h index 23227d090..0293a2841 100644 --- a/include/libvirt/libvirt-event.h +++ b/include/libvirt/libvirt-event.h @@ -179,11 +179,11 @@ int virEventAddHandle(int fd, int events, void virEventUpdateHandle(int watch, int events); int virEventRemoveHandle(int watch); =20 -int virEventAddTimeout(int frequency, +int virEventAddTimeout(int timeout, virEventTimeoutCallback cb, void *opaque, virFreeCallback ff); -void virEventUpdateTimeout(int timer, int frequency); +void virEventUpdateTimeout(int timer, int timeout); int virEventRemoveTimeout(int timer); =20 =20 diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h index 07b5d1594..bd8b7b551 100644 --- a/include/libvirt/libvirt-host.h +++ b/include/libvirt/libvirt-host.h @@ -665,8 +665,8 @@ char *virConnectBaselineCPU(virConnectPtr conn, int virNodeGetFreePages(virConnectPtr conn, unsigned int npages, unsigned int *pages, - int startcell, - unsigned int cellcount, + int startCell, + unsigned int cellCount, unsigned long long *counts, unsigned int flags); =20 diff --git a/include/libvirt/libvirt-network.h b/include/libvirt/libvirt-ne= twork.h index 308f27f64..ef3602c0b 100644 --- a/include/libvirt/libvirt-network.h +++ b/include/libvirt/libvirt-network.h @@ -50,7 +50,7 @@ typedef virNetwork *virNetworkPtr; /* * Get connection from network. */ -virConnectPtr virNetworkGetConnect (virNetworkPtr network); +virConnectPtr virNetworkGetConnect (virNetworkPtr net); =20 /* * List active networks @@ -96,7 +96,7 @@ virNetworkPtr virNetworkLookupByName (= virConnectPtr conn, virNetworkPtr virNetworkLookupByUUID (virConnectPtr con= n, const unsigned ch= ar *uuid); virNetworkPtr virNetworkLookupByUUIDString (virConnectPtr con= n, - const char *uuid); + const char *uuids= tr); =20 /* * Create active transient network diff --git a/include/libvirt/libvirt-nwfilter.h b/include/libvirt/libvirt-n= wfilter.h index 9f01c175a..c72a676ce 100644 --- a/include/libvirt/libvirt-nwfilter.h +++ b/include/libvirt/libvirt-nwfilter.h @@ -62,7 +62,7 @@ virNWFilterPtr virNWFilterLookupByName (vi= rConnectPtr conn, virNWFilterPtr virNWFilterLookupByUUID (virConnectPtr conn, const unsigned char= *uuid); virNWFilterPtr virNWFilterLookupByUUIDString (virConnectPtr conn, - const char *uuid); + const char *uuidstr= ); =20 /* * Define persistent nwfilter diff --git a/include/libvirt/libvirt-qemu.h b/include/libvirt/libvirt-qemu.h index 2bb8ee868..f7db72ef7 100644 --- a/include/libvirt/libvirt-qemu.h +++ b/include/libvirt/libvirt-qemu.h @@ -40,7 +40,7 @@ typedef enum { int virDomainQemuMonitorCommand(virDomainPtr domain, const char *cmd, char **result, unsigned int flags); =20 -virDomainPtr virDomainQemuAttach(virConnectPtr domain, +virDomainPtr virDomainQemuAttach(virConnectPtr conn, unsigned int pid_value, unsigned int flags); =20 diff --git a/include/libvirt/libvirt-secret.h b/include/libvirt/libvirt-sec= ret.h index 5df0b8ff8..bce58d051 100644 --- a/include/libvirt/libvirt-secret.h +++ b/include/libvirt/libvirt-secret.h @@ -84,7 +84,7 @@ int virConnectListAllSecrets(virConne= ctPtr conn, virSecretPtr virSecretLookupByUUID(virConnectPtr conn, const unsigned char *uuid); virSecretPtr virSecretLookupByUUIDString(virConnectPtr conn, - const char *uuid); + const char *uuidstr); virSecretPtr virSecretLookupByUsage(virConnectPtr conn, int usageType, const char *usageID); @@ -92,7 +92,7 @@ virSecretPtr virSecretDefineXML (virConne= ctPtr conn, const char *xml, unsigned int flags); int virSecretGetUUID (virSecretPtr secret, - unsigned char *buf); + unsigned char *uuid); int virSecretGetUUIDString (virSecretPtr secret, char *buf); int virSecretGetUsageType (virSecretPtr secret); diff --git a/include/libvirt/libvirt-storage.h b/include/libvirt/libvirt-st= orage.h index 413d9f6c4..f3209fb8b 100644 --- a/include/libvirt/libvirt-storage.h +++ b/include/libvirt/libvirt-storage.h @@ -262,7 +262,7 @@ virStoragePoolPtr virStoragePoolLookupByName = (virConnectPtr conn, virStoragePoolPtr virStoragePoolLookupByUUID (virConnectPtr con= n, const unsigned ch= ar *uuid); virStoragePoolPtr virStoragePoolLookupByUUIDString(virConnectPtr con= n, - const char *uuid); + const char *uuids= tr); virStoragePoolPtr virStoragePoolLookupByVolume (virStorageVolPtr = vol); virStoragePoolPtr virStoragePoolLookupByTargetPath(virConnectPtr con= n, const char *path); @@ -274,7 +274,7 @@ virStoragePoolPtr virStoragePoolCreateXML = (virConnectPtr conn, const char *xmlDe= sc, unsigned int flag= s); virStoragePoolPtr virStoragePoolDefineXML (virConnectPtr con= n, - const char *xmlDe= sc, + const char *xml, unsigned int flag= s); int virStoragePoolBuild (virStoragePoolPtr= pool, unsigned int flag= s); @@ -298,7 +298,7 @@ int virStoragePoolGetUUID = (virStoragePoolPtr pool, int virStoragePoolGetUUIDString (virStoragePoolPtr= pool, char *buf); =20 -int virStoragePoolGetInfo (virStoragePoolPtr= vol, +int virStoragePoolGetInfo (virStoragePoolPtr= pool, virStoragePoolInf= oPtr info); =20 char * virStoragePoolGetXMLDesc (virStoragePoolPtr= pool, @@ -342,10 +342,10 @@ typedef enum { } virStorageVolCreateFlags; =20 virStorageVolPtr virStorageVolCreateXML (virStoragePoolPtr= pool, - const char *xmlde= sc, + const char *xmlDe= sc, unsigned int flag= s); virStorageVolPtr virStorageVolCreateXMLFrom (virStoragePoolPtr= pool, - const char *xmlde= sc, + const char *xmlDe= sc, virStorageVolPtr = clonevol, unsigned int flag= s); =20 @@ -382,7 +382,7 @@ int virStorageVolGetInfo = (virStorageVolPtr vol, int virStorageVolGetInfoFlags (virStorageVolPtr = vol, virStorageVolInfo= Ptr info, unsigned int flag= s); -char * virStorageVolGetXMLDesc (virStorageVolPtr = pool, +char * virStorageVolGetXMLDesc (virStorageVolPtr = vol, unsigned int flag= s); =20 char * virStorageVolGetPath (virStorageVolPtr = vol); diff --git a/include/libvirt/libvirt-stream.h b/include/libvirt/libvirt-str= eam.h index 86f96b158..c861c5658 100644 --- a/include/libvirt/libvirt-stream.h +++ b/include/libvirt/libvirt-stream.h @@ -35,13 +35,13 @@ typedef enum { =20 virStreamPtr virStreamNew(virConnectPtr conn, unsigned int flags); -int virStreamRef(virStreamPtr st); +int virStreamRef(virStreamPtr stream); =20 -int virStreamSend(virStreamPtr st, +int virStreamSend(virStreamPtr stream, const char *data, size_t nbytes); =20 -int virStreamRecv(virStreamPtr st, +int virStreamRecv(virStreamPtr stream, char *data, size_t nbytes); =20 @@ -49,12 +49,12 @@ typedef enum { VIR_STREAM_RECV_STOP_AT_HOLE =3D (1 << 0), } virStreamRecvFlagsValues; =20 -int virStreamRecvFlags(virStreamPtr st, +int virStreamRecvFlags(virStreamPtr stream, char *data, size_t nbytes, unsigned int flags); =20 -int virStreamSendHole(virStreamPtr st, +int virStreamSendHole(virStreamPtr stream, long long length, unsigned int flags); =20 @@ -95,7 +95,7 @@ typedef int (*virStreamSourceFunc)(virStreamPtr st, size_t nbytes, void *opaque); =20 -int virStreamSendAll(virStreamPtr st, +int virStreamSendAll(virStreamPtr stream, virStreamSourceFunc handler, void *opaque); =20 @@ -158,7 +158,7 @@ typedef int (*virStreamSourceSkipFunc)(virStreamPtr st, long long length, void *opaque); =20 -int virStreamSparseSendAll(virStreamPtr st, +int virStreamSparseSendAll(virStreamPtr stream, virStreamSourceFunc handler, virStreamSourceHoleFunc holeHandler, virStreamSourceSkipFunc skipHandler, @@ -196,7 +196,7 @@ typedef int (*virStreamSinkFunc)(virStreamPtr st, size_t nbytes, void *opaque); =20 -int virStreamRecvAll(virStreamPtr st, +int virStreamRecvAll(virStreamPtr stream, virStreamSinkFunc handler, void *opaque); =20 @@ -262,9 +262,9 @@ int virStreamEventUpdateCallback(virStreamPtr stream, int virStreamEventRemoveCallback(virStreamPtr stream); =20 =20 -int virStreamFinish(virStreamPtr st); -int virStreamAbort(virStreamPtr st); +int virStreamFinish(virStreamPtr stream); +int virStreamAbort(virStreamPtr stream); =20 -int virStreamFree(virStreamPtr st); +int virStreamFree(virStreamPtr stream); =20 #endif /* __VIR_LIBVIRT_STREAM_H__ */ diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index eaec0979a..dd87ea918 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -109,7 +109,7 @@ virConnectNumOfDomains(virConnectPtr conn) =20 /** * virDomainGetConnect: - * @dom: pointer to a domain + * @domain: pointer to a domain * * Provides the connection pointer associated with a domain. The * reference counter on the connection is not increased by this @@ -118,15 +118,15 @@ virConnectNumOfDomains(virConnectPtr conn) * Returns the virConnectPtr or NULL in case of failure. */ virConnectPtr -virDomainGetConnect(virDomainPtr dom) +virDomainGetConnect(virDomainPtr domain) { - VIR_DOMAIN_DEBUG(dom); + VIR_DOMAIN_DEBUG(domain); =20 virResetLastError(); =20 - virCheckDomainReturn(dom, NULL); + virCheckDomainReturn(domain, NULL); =20 - return dom->conn; + return domain->conn; } =20 =20 @@ -688,7 +688,7 @@ virDomainResume(virDomainPtr domain) =20 /** * virDomainPMSuspendForDuration: - * @dom: a domain object + * @domain: a domain object * @target: a value from virNodeSuspendTarget * @duration: duration in seconds to suspend, or 0 for indefinite * @flags: extra flags; not used yet, so callers should always pass 0 @@ -713,26 +713,26 @@ virDomainResume(virDomainPtr domain) * -1 on failure. */ int -virDomainPMSuspendForDuration(virDomainPtr dom, +virDomainPMSuspendForDuration(virDomainPtr domain, unsigned int target, unsigned long long duration, unsigned int flags) { virConnectPtr conn; =20 - VIR_DOMAIN_DEBUG(dom, "target=3D%u duration=3D%llu flags=3D0x%x", + VIR_DOMAIN_DEBUG(domain, "target=3D%u duration=3D%llu flags=3D0x%x", target, duration, flags); =20 virResetLastError(); =20 - virCheckDomainReturn(dom, -1); - conn =3D dom->conn; + virCheckDomainReturn(domain, -1); + conn =3D domain->conn; =20 virCheckReadOnlyGoto(conn->flags, error); =20 if (conn->driver->domainPMSuspendForDuration) { int ret; - ret =3D conn->driver->domainPMSuspendForDuration(dom, target, + ret =3D conn->driver->domainPMSuspendForDuration(domain, target, duration, flags); if (ret < 0) goto error; @@ -749,7 +749,7 @@ virDomainPMSuspendForDuration(virDomainPtr dom, =20 /** * virDomainPMWakeup: - * @dom: a domain object + * @domain: a domain object * @flags: extra flags; not used yet, so callers should always pass 0 * * Inject a wakeup into the guest that previously used @@ -760,23 +760,23 @@ virDomainPMSuspendForDuration(virDomainPtr dom, * -1 on failure. */ int -virDomainPMWakeup(virDomainPtr dom, +virDomainPMWakeup(virDomainPtr domain, unsigned int flags) { virConnectPtr conn; =20 - VIR_DOMAIN_DEBUG(dom, "flags=3D0x%x", flags); + VIR_DOMAIN_DEBUG(domain, "flags=3D0x%x", flags); =20 virResetLastError(); =20 - virCheckDomainReturn(dom, -1); - conn =3D dom->conn; + virCheckDomainReturn(domain, -1); + conn =3D domain->conn; =20 virCheckReadOnlyGoto(conn->flags, error); =20 if (conn->driver->domainPMWakeup) { int ret; - ret =3D conn->driver->domainPMWakeup(dom, flags); + ret =3D conn->driver->domainPMWakeup(domain, flags); if (ret < 0) goto error; return ret; @@ -7557,7 +7557,7 @@ virDomainGetMaxVcpus(virDomainPtr domain) =20 /** * virDomainGetIOThreadInfo: - * @dom: a domain object + * @domain: a domain object * @info: pointer to an array of virDomainIOThreadInfo structures (OUT) * @flags: bitwise-OR of virDomainModificationImpact * Must not be VIR_DOMAIN_AFFECT_LIVE and @@ -7572,15 +7572,15 @@ virDomainGetMaxVcpus(virDomainPtr domain) * then calling free() on @info. On error, @info is set to NULL. */ int -virDomainGetIOThreadInfo(virDomainPtr dom, +virDomainGetIOThreadInfo(virDomainPtr domain, virDomainIOThreadInfoPtr **info, unsigned int flags) { - VIR_DOMAIN_DEBUG(dom, "info=3D%p flags=3D0x%x", info, flags); + VIR_DOMAIN_DEBUG(domain, "info=3D%p flags=3D0x%x", info, flags); =20 virResetLastError(); =20 - virCheckDomainReturn(dom, -1); + virCheckDomainReturn(domain, -1); virCheckNonNullArgGoto(info, error); *info =3D NULL; =20 @@ -7588,9 +7588,9 @@ virDomainGetIOThreadInfo(virDomainPtr dom, VIR_DOMAIN_AFFECT_CONFIG, error); =20 - if (dom->conn->driver->domainGetIOThreadInfo) { + if (domain->conn->driver->domainGetIOThreadInfo) { int ret; - ret =3D dom->conn->driver->domainGetIOThreadInfo(dom, info, flags); + ret =3D domain->conn->driver->domainGetIOThreadInfo(domain, info, = flags); if (ret < 0) goto error; return ret; @@ -7599,7 +7599,7 @@ virDomainGetIOThreadInfo(virDomainPtr dom, virReportUnsupportedError(); =20 error: - virDispatchError(dom->conn); + virDispatchError(domain->conn); return -1; } =20 diff --git a/src/libvirt-network.c b/src/libvirt-network.c index da3354300..6699db61a 100644 --- a/src/libvirt-network.c +++ b/src/libvirt-network.c @@ -427,7 +427,7 @@ virNetworkCreateXML(virConnectPtr conn, const char *xml= Desc) /** * virNetworkDefineXML: * @conn: pointer to the hypervisor connection - * @xml: the XML description for the network, preferably in UTF-8 + * @xmlDesc: an XML description of the network, preferably in UTF-8 * * Define an inactive persistent virtual network or modify an existing * persistent one from the XML description. @@ -438,19 +438,19 @@ virNetworkCreateXML(virConnectPtr conn, const char *x= mlDesc) * Returns NULL in case of error, a pointer to the network otherwise */ virNetworkPtr -virNetworkDefineXML(virConnectPtr conn, const char *xml) +virNetworkDefineXML(virConnectPtr conn, const char *xmlDesc) { - VIR_DEBUG("conn=3D%p, xml=3D%s", conn, NULLSTR(xml)); + VIR_DEBUG("conn=3D%p, xml=3D%s", conn, NULLSTR(xmlDesc)); =20 virResetLastError(); =20 virCheckConnectReturn(conn, NULL); virCheckReadOnlyGoto(conn->flags, error); - virCheckNonNullArgGoto(xml, error); + virCheckNonNullArgGoto(xmlDesc, error); =20 if (conn->networkDriver && conn->networkDriver->networkDefineXML) { virNetworkPtr ret; - ret =3D conn->networkDriver->networkDefineXML(conn, xml); + ret =3D conn->networkDriver->networkDefineXML(conn, xmlDesc); if (!ret) goto error; return ret; --=20 2.14.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list