rpc: export xdr_virNetMessageError for virnetmessagetest on Win32

[libvirt] [PATCH] rpc: export xdr_virNetMessageError for virnetmessagetest on Win32

Daniel P. Berrangé posted 1 patch 6 years, 2 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180209143145.11652-1-berrange@redhat.com

src/libvirt_remote.syms | 6 ++++++
1 file changed, 6 insertions(+)

Expand all Fold all

[libvirt] [PATCH] rpc: export xdr_virNetMessageError for virnetmessagetest on Win32

Posted by Daniel P. Berrangé 6 years, 2 months ago

The Win32 symbol export file format can't do wildcards, so none of
the 'xdr_*' symbols are exported from the libvirt DLL. This doesn't
matter generally since the RPC client is built into the DLL and we
don't build libvirtd on Win32. The virnetmessagetest, however, does
require xdr_virNetMessageError to be exported, so just do a hack for
that.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

Pushed as win32 CI build fix

 src/libvirt_remote.syms | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/libvirt_remote.syms b/src/libvirt_remote.syms
index 736848273a..97e22275b9 100644
--- a/src/libvirt_remote.syms
+++ b/src/libvirt_remote.syms
@@ -7,6 +7,12 @@
 
 # Generated files
 xdr_*;
+# Hack only required for Win32 to make tests link properly,
+# as the wildcard above doesn't work there. Fortunately
+# Win32 builds don't require the other xdr_* syms exported.
+# since there's no libvirtd built.
+xdr_virNetMessageError;
+
 
 # rpc/virnetclient.h
 virNetClientAddProgram;
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list