qemu: qemuDomainNamespaceUnlinkPaths: Return 0 in case of success

[libvirt] [PATCH] qemu: qemuDomainNamespaceUnlinkPaths: Return 0 in case of success

Marc Hartmayer posted 1 patch 6 years, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180117154716.16918-1-mhartmay@linux.vnet.ibm.com

src/qemu/qemu_domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] qemu: qemuDomainNamespaceUnlinkPaths: Return 0 in case of success

Posted by Marc Hartmayer 6 years, 3 months ago

Commit 7a931a4204af refactored the code and probably forgot to add
this line.

Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
---
 src/qemu/qemu_domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 5c171e4cbd6c..441bf5935b14 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -10212,7 +10212,7 @@ qemuDomainNamespaceUnlinkPaths(virDomainObjPtr vm,
             goto cleanup;
     }
 
-
+    ret = 0;
  cleanup:
     virStringListFreeCount(devMountsPath, ndevMountsPath);
     virObjectUnref(cfg);
-- 
2.13.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: qemuDomainNamespaceUnlinkPaths: Return 0 in case of success

Posted by Michal Privoznik 6 years, 3 months ago

On 01/17/2018 04:47 PM, Marc Hartmayer wrote:
> Commit 7a931a4204af refactored the code and probably forgot to add
> this line.
> 
> Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
> Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
> ---
>  src/qemu/qemu_domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 5c171e4cbd6c..441bf5935b14 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -10212,7 +10212,7 @@ qemuDomainNamespaceUnlinkPaths(virDomainObjPtr vm,
>              goto cleanup;
>      }
>  
> -
> +    ret = 0;
>   cleanup:
>      virStringListFreeCount(devMountsPath, ndevMountsPath);
>      virObjectUnref(cfg);
> 

Ooops. Yes. ACKed and pushed. Definitely a release material.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list