[libvirt] [PATCH] util: fix another wrong description

Chen Hanxiao posted 1 patch 6 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180103095635.15525-1-chen_han_xiao@126.com
src/util/virstring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] util: fix another wrong description
Posted by Chen Hanxiao 6 years, 3 months ago
From: Chen Hanxiao <chenhanxiao@gmail.com>

commit 9026d1152c236ac7a7ab25845220a8e14d6bc630
forgot to change the referenced @result variable.
This patch completed this.

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
---
 src/util/virstring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virstring.c b/src/util/virstring.c
index 0cb06bdc9..b6e7e279c 100644
--- a/src/util/virstring.c
+++ b/src/util/virstring.c
@@ -1041,7 +1041,7 @@ int virStringSortRevCompare(const void *a, const void *b)
  * @matches: pointer to an array to be filled with NULL terminated list of matches
  *
  * Performs a POSIX extended regex search against a string and return all matching substrings.
- * The @result value should be freed with virStringListFree() when no longer
+ * The @matches value should be freed with virStringListFree() when no longer
  * required.
  *
  * @code
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] util: fix another wrong description
Posted by Erik Skultety 6 years, 3 months ago
On Wed, Jan 03, 2018 at 05:56:35PM +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao@gmail.com>
>
> commit 9026d1152c236ac7a7ab25845220a8e14d6bc630
> forgot to change the referenced @result variable.
> This patch completed this.
>
> Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>

Sigh, should have payed more attention. To avoid sending more patches which
would be description/commentary oriented, I went through the module and found a
few more issues which I squashed into this patch.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list