A few steps towards eventually fixing

  https://bugzilla.redhat.com/show_bug.cgi?id=1206353

The commit message for patch 6/6 contains most of the rationale,
previous patches are cleanups. If not for the new test case added
with patch 1/6, the overall diffstat would be negative.

Andrea Bolognani (6):
  tests: Add host CPU data for Moonshot (RHEL 7.4)
  util: Introduce virHostCPUGetInfoParseCPUInfo()
  util: Introduce virHostCPUGetInfoParseCPUFrequency()
  util: Tweak virHostCPUGetInfoParseCPUFrequency()
  util: Tweak s390(x) case for CPU frequency
  util: Don't report CPU frequency for ARM hosts

 src/util/virhostcpu.c                              | 151 ++++++++++-----------
 .../linux-aarch64-rhel74-moonshot.cpuinfo          |  72 ++++++++++
 .../linux-aarch64-rhel74-moonshot.expected         |   1 +
 .../linux-armv6l-raspberrypi.expected              |   2 +-
 .../linux-rhel74-moonshot/cpu/cpu0/node0           |   1 +
 .../linux-rhel74-moonshot/cpu/cpu0/online          |   1 +
 .../cpu/cpu0/topology/core_id                      |   1 +
 .../cpu/cpu0/topology/core_siblings                |   1 +
 .../cpu/cpu0/topology/core_siblings_list           |   1 +
 .../cpu/cpu0/topology/physical_package_id          |   1 +
 .../cpu/cpu0/topology/thread_siblings              |   1 +
 .../cpu/cpu0/topology/thread_siblings_list         |   1 +
 .../linux-rhel74-moonshot/cpu/cpu1/node0           |   1 +
 .../linux-rhel74-moonshot/cpu/cpu1/online          |   1 +
 .../cpu/cpu1/topology/core_id                      |   1 +
 .../cpu/cpu1/topology/core_siblings                |   1 +
 .../cpu/cpu1/topology/core_siblings_list           |   1 +
 .../cpu/cpu1/topology/physical_package_id          |   1 +
 .../cpu/cpu1/topology/thread_siblings              |   1 +
 .../cpu/cpu1/topology/thread_siblings_list         |   1 +
 .../linux-rhel74-moonshot/cpu/cpu2/node0           |   1 +
 .../linux-rhel74-moonshot/cpu/cpu2/online          |   1 +
 .../cpu/cpu2/topology/core_id                      |   1 +
 .../cpu/cpu2/topology/core_siblings                |   1 +
 .../cpu/cpu2/topology/core_siblings_list           |   1 +
 .../cpu/cpu2/topology/physical_package_id          |   1 +
 .../cpu/cpu2/topology/thread_siblings              |   1 +
 .../cpu/cpu2/topology/thread_siblings_list         |   1 +
 .../linux-rhel74-moonshot/cpu/cpu3/node0           |   1 +
 .../linux-rhel74-moonshot/cpu/cpu3/online          |   1 +
 .../cpu/cpu3/topology/core_id                      |   1 +
 .../cpu/cpu3/topology/core_siblings                |   1 +
 .../cpu/cpu3/topology/core_siblings_list           |   1 +
 .../cpu/cpu3/topology/physical_package_id          |   1 +
 .../cpu/cpu3/topology/thread_siblings              |   1 +
 .../cpu/cpu3/topology/thread_siblings_list         |   1 +
 .../linux-rhel74-moonshot/cpu/cpu4/node0           |   1 +
 .../linux-rhel74-moonshot/cpu/cpu4/online          |   1 +
 .../cpu/cpu4/topology/core_id                      |   1 +
 .../cpu/cpu4/topology/core_siblings                |   1 +
 .../cpu/cpu4/topology/core_siblings_list           |   1 +
 .../cpu/cpu4/topology/physical_package_id          |   1 +
 .../cpu/cpu4/topology/thread_siblings              |   1 +
 .../cpu/cpu4/topology/thread_siblings_list         |   1 +
 .../linux-rhel74-moonshot/cpu/cpu5/node0           |   1 +
 .../linux-rhel74-moonshot/cpu/cpu5/online          |   1 +
 .../cpu/cpu5/topology/core_id                      |   1 +
 .../cpu/cpu5/topology/core_siblings                |   1 +
 .../cpu/cpu5/topology/core_siblings_list           |   1 +
 .../cpu/cpu5/topology/physical_package_id          |   1 +
 .../cpu/cpu5/topology/thread_siblings              |   1 +
 .../cpu/cpu5/topology/thread_siblings_list         |   1 +
 .../linux-rhel74-moonshot/cpu/cpu6/node0           |   1 +
 .../linux-rhel74-moonshot/cpu/cpu6/online          |   1 +
 .../cpu/cpu6/topology/core_id                      |   1 +
 .../cpu/cpu6/topology/core_siblings                |   1 +
 .../cpu/cpu6/topology/core_siblings_list           |   1 +
 .../cpu/cpu6/topology/physical_package_id          |   1 +
 .../cpu/cpu6/topology/thread_siblings              |   1 +
 .../cpu/cpu6/topology/thread_siblings_list         |   1 +
 .../linux-rhel74-moonshot/cpu/cpu7/node0           |   1 +
 .../linux-rhel74-moonshot/cpu/cpu7/online          |   1 +
 .../cpu/cpu7/topology/core_id                      |   1 +
 .../cpu/cpu7/topology/core_siblings                |   1 +
 .../cpu/cpu7/topology/core_siblings_list           |   1 +
 .../cpu/cpu7/topology/physical_package_id          |   1 +
 .../cpu/cpu7/topology/thread_siblings              |   1 +
 .../cpu/cpu7/topology/thread_siblings_list         |   1 +
 .../linux-rhel74-moonshot/cpu/kernel_max           |   1 +
 .../linux-rhel74-moonshot/cpu/offline              |   1 +
 .../linux-rhel74-moonshot/cpu/online               |   1 +
 .../linux-rhel74-moonshot/cpu/possible             |   1 +
 .../linux-rhel74-moonshot/cpu/present              |   1 +
 .../linux-rhel74-moonshot/node/has_cpu             |   1 +
 .../linux-rhel74-moonshot/node/has_memory          |   1 +
 .../linux-rhel74-moonshot/node/has_normal_memory   |   1 +
 .../linux-rhel74-moonshot/node/node0/cpu0          |   1 +
 .../linux-rhel74-moonshot/node/node0/cpu1          |   1 +
 .../linux-rhel74-moonshot/node/node0/cpu2          |   1 +
 .../linux-rhel74-moonshot/node/node0/cpu3          |   1 +
 .../linux-rhel74-moonshot/node/node0/cpu4          |   1 +
 .../linux-rhel74-moonshot/node/node0/cpu5          |   1 +
 .../linux-rhel74-moonshot/node/node0/cpu6          |   1 +
 .../linux-rhel74-moonshot/node/node0/cpu7          |   1 +
 .../linux-rhel74-moonshot/node/node0/cpulist       |   1 +
 .../linux-rhel74-moonshot/node/node0/cpumap        |   1 +
 .../linux-rhel74-moonshot/node/online              |   1 +
 .../linux-rhel74-moonshot/node/possible            |   1 +
 tests/virhostcputest.c                             |   1 +
 89 files changed, 230 insertions(+), 81 deletions(-)
 create mode 100644 tests/virhostcpudata/linux-aarch64-rhel74-moonshot.cpuinfo
 create mode 100644 tests/virhostcpudata/linux-aarch64-rhel74-moonshot.expected
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/node0
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/online
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/topology/core_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/topology/core_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/topology/core_siblings_list
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/topology/physical_package_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/topology/thread_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/topology/thread_siblings_list
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/node0
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/online
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/topology/core_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/topology/core_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/topology/core_siblings_list
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/topology/physical_package_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/topology/thread_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/topology/thread_siblings_list
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/node0
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/online
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/topology/core_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/topology/core_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/topology/core_siblings_list
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/topology/physical_package_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/topology/thread_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/topology/thread_siblings_list
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/node0
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/online
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/topology/core_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/topology/core_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/topology/core_siblings_list
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/topology/physical_package_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/topology/thread_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/topology/thread_siblings_list
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/node0
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/online
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/topology/core_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/topology/core_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/topology/core_siblings_list
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/topology/physical_package_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/topology/thread_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/topology/thread_siblings_list
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/node0
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/online
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/topology/core_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/topology/core_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/topology/core_siblings_list
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/topology/physical_package_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/topology/thread_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/topology/thread_siblings_list
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/node0
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/online
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/topology/core_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/topology/core_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/topology/core_siblings_list
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/topology/physical_package_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/topology/thread_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/topology/thread_siblings_list
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/node0
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/online
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/topology/core_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/topology/core_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/topology/core_siblings_list
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/topology/physical_package_id
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/topology/thread_siblings
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/topology/thread_siblings_list
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/kernel_max
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/offline
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/online
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/possible
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/present
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/has_cpu
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/has_memory
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/has_normal_memory
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu0
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu1
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu2
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu3
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu4
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu5
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu6
 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu7
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpulist
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpumap
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/online
 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/possible

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Andrea Bolognani <abologna@redhat.com> [2017-12-11, 05:40PM +0100]:
> A few steps towards eventually fixing
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=1206353
> 
> The commit message for patch 6/6 contains most of the rationale,
> previous patches are cleanups. If not for the new test case added
> with patch 1/6, the overall diffstat would be negative.
> 

The timings... I have a similar patch set in my queue that I wanted to
send out today, but, well. I also have fixed frequency reporting on
S390, which I will at least rebase on top of this.

Before you push, I want to review this series and compare it with mine,
but I can't make it today I'm afraid. I will find the time to do it
tomorrow.

Best,
Bjoern

-- 
IBM Systems
Linux on z Systems & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland
Schönaicher Str. 220
71032 Böblingen
Phone: +49 7031 16 1819
E-Mail: bwalk@de.ibm.com
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294 
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, 2017-12-12 at 12:52 +0100, Bjoern Walk wrote:
> Andrea Bolognani <abologna@redhat.com> [2017-12-11, 05:40PM +0100]:
> > A few steps towards eventually fixing
> > 
> >   https://bugzilla.redhat.com/show_bug.cgi?id=1206353
> > 
> > The commit message for patch 6/6 contains most of the rationale,
> > previous patches are cleanups. If not for the new test case added
> > with patch 1/6, the overall diffstat would be negative.
> 
> The timings... I have a similar patch set in my queue that I wanted to
> send out today, but, well. I also have fixed frequency reporting on
> S390, which I will at least rebase on top of this.

I'm sorry! Some amount of duplicated work is kind of unavoidable
in a loosely-organized community project such as libvirt.

Hopefully rebasing on top of my series is not too much work,
considering most of it is just refactoring and cleanups.

> Before you push, I want to review this series and compare it with mine,
> but I can't make it today I'm afraid. I will find the time to do it
> tomorrow.

I'd certainly appreciate that. The series doesn't have any ACKs
yet, so there's no risk I'd push it before you can get to it :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Andrea Bolognani <abologna@redhat.com> [2017-12-12, 04:43PM +0100]:
> On Tue, 2017-12-12 at 12:52 +0100, Bjoern Walk wrote:
> > Andrea Bolognani <abologna@redhat.com> [2017-12-11, 05:40PM +0100]:
> > > A few steps towards eventually fixing
> > > 
> > >   https://bugzilla.redhat.com/show_bug.cgi?id=1206353
> > > 
> > > The commit message for patch 6/6 contains most of the rationale,
> > > previous patches are cleanups. If not for the new test case added
> > > with patch 1/6, the overall diffstat would be negative.
> > 
> > The timings... I have a similar patch set in my queue that I wanted to
> > send out today, but, well. I also have fixed frequency reporting on
> > S390, which I will at least rebase on top of this.
> 
> I'm sorry! Some amount of duplicated work is kind of unavoidable
> in a loosely-organized community project such as libvirt.

No problem at all, I am glad that this code gets fixed by whoever, it
certainly deserved it.

> 
> Hopefully rebasing on top of my series is not too much work,
> considering most of it is just refactoring and cleanups.
> 

Should be no problem. I will wait for you to push this and then send out
the S390 improvements.

> > Before you push, I want to review this series and compare it with mine,
> > but I can't make it today I'm afraid. I will find the time to do it
> > tomorrow.
> 
> I'd certainly appreciate that. The series doesn't have any ACKs
> yet, so there's no risk I'd push it before you can get to it :)

So, both our approached were fairly similar, with some bike-shedding
differences. For patch 2-5:

Reviewed-by: Bjoern Walk <bwalk@linux.vnet.ibm.com>

> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 

-- 
IBM Systems
Linux on z Systems & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland
Schönaicher Str. 220
71032 Böblingen
Phone: +49 7031 16 1819
E-Mail: bwalk@de.ibm.com
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294 
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list