[libvirt] [PATCH] qemu-capabilities: Adjust function header comments of virQEMUCapsInitCPUModel*

Boris Fiuczynski posted 1 patch 6 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20171127121217.3346-1-fiuczy@linux.vnet.ibm.com
src/qemu/qemu_capabilities.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
[libvirt] [PATCH] qemu-capabilities: Adjust function header comments of virQEMUCapsInitCPUModel*
Posted by Boris Fiuczynski 6 years, 4 months ago
Adjust function descriptions of virQEMUCapsInitCPUModelS390 and
virQEMUCapsInitCPUModel to the changes introduced with
commitID 74fc32a955.

Signed-off-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Reviewed-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
---
 src/qemu/qemu_capabilities.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index f2d24a3..e4e25da 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -3308,8 +3308,7 @@ virQEMUCapsCPUFilterFeatures(const char *name,
 /**
  * Returns  0 when host CPU model provided by QEMU was filled in qemuCaps,
  *          1 when the caller should fall back to using virCapsPtr->host.cpu,
- *          2 when cpu model info is not supported for this configuration and
- *            fall back should not be used.
+ *          2 when cpu model info is not supported for this configuration,
  *         -1 on error.
  */
 static int
@@ -3436,9 +3435,8 @@ virQEMUCapsInitCPUModelX86(virQEMUCapsPtr qemuCaps,
 
 /**
  * Returns  0 when host CPU model provided by QEMU was filled in qemuCaps,
- *          1 when the caller should fall back to other methods
- *          2 when cpu model info is not supported for this configuration and
- *            fall back should not be used.
+ *          1 when the caller should fall back to other methods,
+ *          2 when cpu model info is not supported for this configuration,
  *         -1 on error.
  */
 int
-- 
2.9.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu-capabilities: Adjust function header comments of virQEMUCapsInitCPUModel*
Posted by Jiri Denemark 6 years, 3 months ago
On Mon, Nov 27, 2017 at 13:12:17 +0100, Boris Fiuczynski wrote:
> Adjust function descriptions of virQEMUCapsInitCPUModelS390 and
> virQEMUCapsInitCPUModel to the changes introduced with
> commitID 74fc32a955.
> 
> Signed-off-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
> Reviewed-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
> ---
>  src/qemu/qemu_capabilities.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index f2d24a3..e4e25da 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -3308,8 +3308,7 @@ virQEMUCapsCPUFilterFeatures(const char *name,
>  /**
>   * Returns  0 when host CPU model provided by QEMU was filled in qemuCaps,
>   *          1 when the caller should fall back to using virCapsPtr->host.cpu,
> - *          2 when cpu model info is not supported for this configuration and
> - *            fall back should not be used.
> + *          2 when cpu model info is not supported for this configuration,
>   *         -1 on error.
>   */
>  static int
> @@ -3436,9 +3435,8 @@ virQEMUCapsInitCPUModelX86(virQEMUCapsPtr qemuCaps,
>  
>  /**
>   * Returns  0 when host CPU model provided by QEMU was filled in qemuCaps,
> - *          1 when the caller should fall back to other methods
> - *          2 when cpu model info is not supported for this configuration and
> - *            fall back should not be used.
> + *          1 when the caller should fall back to other methods,
> + *          2 when cpu model info is not supported for this configuration,
>   *         -1 on error.
>   */
>  int

ACK and pushed, thanks.

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list