From nobody Sun May 5 05:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1509980960592484.55256555938786; Mon, 6 Nov 2017 07:09:20 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CD01961D20; Mon, 6 Nov 2017 15:09:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7AEF15D753; Mon, 6 Nov 2017 15:09:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5A97C1800BDD; Mon, 6 Nov 2017 15:09:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vA4KIgQk017207 for ; Sat, 4 Nov 2017 16:18:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id 05CF46031B; Sat, 4 Nov 2017 20:18:42 +0000 (UTC) Received: from mx1.redhat.com (ext-mx04.extmail.prod.ext.phx2.redhat.com [10.5.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0110A60317 for ; Sat, 4 Nov 2017 20:18:40 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2EDB07E383 for ; Sat, 4 Nov 2017 20:18:39 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 769D920BB3; Sat, 4 Nov 2017 16:18:38 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Sat, 04 Nov 2017 16:18:38 -0400 Received: from narwhal.east.rtk0.net (unknown [208.107.52.58]) by mail.messagingengine.com (Postfix) with ESMTPA id 111A924E82; Sat, 4 Nov 2017 16:18:38 -0400 (EDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CD01961D20 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=bdragon.rtk0.net Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CD01961D20 Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="bER1TeNt" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2EDB07E383 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=bdragon.rtk0.net Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=none smtp.mailfrom=git@bdragon.rtk0.net DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2EDB07E383 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=2h16Cz1kItoUDU9Wu 99R765aZOlgOC2FqooErE0Fu2k=; b=bER1TeNtQENV7UTrH/f8SA6sYBmzGZ5+S HHZ8KiOPEPv+VXEbKSbZqhsan0whKRysz72asMMcIfUHkvvRegH8y/HsQUC/GOtU uvVvgSekXLaKcVNyRJNlbqkZUxrTAH74BNQxkMAKppdMR6w/sRAmG4UMO0GDKsxU 1luj4NsvL9QUUNO7W1Ckeegb0WgTZvMSu3qAWBgsebQE25/H7t6KNdX2o/rWDH3s q6LnZehLvr8UsxGi3SwyCs+bj9/KL08bXv5kWYAI37SePCDtyEjuTCpkNTTjSgEp iQq+jZej4Nwe0t8gT/tx4pBd6EbfyinBUJSt5jjCT/BY6/wbHTe2w== X-ME-Sender: From: Brandon Bergren To: libvir-list@redhat.com Date: Sat, 4 Nov 2017 15:18:31 -0500 Message-Id: <20171104201831.16605-1-git@bdragon.rtk0.net> X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 205 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sat, 04 Nov 2017 20:18:39 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sat, 04 Nov 2017 20:18:39 +0000 (UTC) for IP:'66.111.4.28' DOMAIN:'out4-smtp.messagingengine.com' HELO:'out4-smtp.messagingengine.com' FROM:'git@bdragon.rtk0.net' RCPT:'' X-RedHat-Spam-Score: -0.341 (DKIM_SIGNED, DKIM_VALID, NO_DNS_FOR_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL) 66.111.4.28 out4-smtp.messagingengine.com 66.111.4.28 out4-smtp.messagingengine.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.28 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-Mailman-Approved-At: Mon, 06 Nov 2017 10:08:54 -0500 Cc: Brandon Bergren Subject: [libvirt] [PATCH go-xml] Improve DomainChardevSource. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 06 Nov 2017 15:09:19 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" * Add missing attributes to DomainChardevSource. * Change Path to be omitempty because several chardev types do not use it. * Document which chardev types use which attributes (for convenience) I was mainly interested in making it possible to define nmdm devices from g= o code, but I figured I would add the other missing attributes while I was here. --- domain.go | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/domain.go b/domain.go index f4ef35c..debc5b2 100644 --- a/domain.go +++ b/domain.go @@ -256,9 +256,15 @@ type DomainInterface struct { } =20 type DomainChardevSource struct { - Mode string `xml:"mode,attr,omitempty"` - Path string `xml:"path,attr"` - Append string `xml:"append,attr,omitempty"` + Mode string `xml:"mode,attr,omitempty"` // tcp,udp,unix + Path string `xml:"path,attr,omitempty"` // file,pty,dev,pipe + Channnel string `xml:"channel,attr,omitempty"` // spiceport + Append string `xml:"append,attr,omitempty"` // file + Host string `xml:"host,attr,omitempty"` // tcp,udp + Service string `xml:"service,attr,omitempty"` // tcp,udp + TLS string `xml:"tls,attr,omitempty"` // tcp(QEMU) + Master string `xml:"master,attr,omitempty"` // nmdm + Slave string `xml:"slave,attr,omitempty"` // nmdm } =20 type DomainChardevTarget struct { --=20 2.14.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list