From nobody Thu May 2 04:10:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1509460285835463.5222887922762; Tue, 31 Oct 2017 07:31:25 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4165A3E81D; Tue, 31 Oct 2017 14:31:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E83E6046E; Tue, 31 Oct 2017 14:31:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CA8536EF21; Tue, 31 Oct 2017 14:31:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9VEVEXp030529 for ; Tue, 31 Oct 2017 10:31:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 12F375D6AE; Tue, 31 Oct 2017 14:31:14 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.219]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6256F5D6A3 for ; Tue, 31 Oct 2017 14:31:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4165A3E81D Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 31 Oct 2017 15:31:03 +0100 Message-Id: <20171031143104.28663-2-abologna@redhat.com> In-Reply-To: <20171031143104.28663-1-abologna@redhat.com> References: <20171031143104.28663-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/2] Remove backslash alignment attempts X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 31 Oct 2017 14:31:24 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Right-aligning backslashes when defining macros or using complex commands in Makefiles looks cute, but as soon as any changes is required to the code you end up with either distractingly broken alignment or unnecessarily big diffs where most of the changes are just pushing all backslashes a few characters to one side. Generated using $ git grep -El '[[:blank:]][[:blank:]]\\$' | \ grep -E '*\.([chx]|am|mk)$$' | \ while read f; do \ sed -Ei 's/[[:blank:]]*[[:blank:]]\\$/ \\/g' "$f"; \ done Signed-off-by: Andrea Bolognani --- I'm only including the first few hunks to avoid running into mailing list size limits; it's all automatically generated anyway. The full patch can be retrieved from https://github.com/andreabolognani/libvirt.git in the 'prohibit-backslash-alignment' branch. Makefile.am | 10 +- cfg.mk | 824 ++++++++-------- config-post.h | 2 +- daemon/Makefile.am | 172 ++-- daemon/remote.c | 46 +- docs/Makefile.am | 56 +- examples/Makefile.am | 2 +- examples/domsuspend/suspend.c | 26 +- examples/domtop/domtop.c | 26 +- examples/object-events/event-test.c | 8 +- src/Makefile.am | 1510 ++++++++++++++-----------= ---- src/access/viraccessdriverpolkit.c | 4 +- src/access/viraccessmanager.c | 4 +- src/conf/cpu_conf.c | 4 +- src/conf/domain_capabilities.c | 32 +- src/conf/domain_capabilities.h | 12 +- src/conf/domain_conf.c | 62 +- src/conf/interface_conf.h | 2 +- src/conf/network_conf.h | 10 +- src/conf/secret_conf.h | 6 +- src/conf/snapshot_conf.h | 10 +- src/conf/storage_conf.h | 12 +- src/conf/virdomainobjlist.h | 14 +- src/cpu/cpu_x86.c | 48 +- src/datatypes.c | 12 +- src/datatypes.h | 590 +++++------ src/driver.h | 4 +- src/esx/esx_driver.c | 8 +- src/esx/esx_vi.c | 258 ++--- src/esx/esx_vi.h | 42 +- src/esx/esx_vi_methods.c | 196 ++-- src/esx/esx_vi_types.c | 1094 ++++++++++----------- src/internal.h | 260 ++--- src/libxl/libxl_domain.h | 4 +- src/libxl/libxl_driver.c | 40 +- src/libxl/libxl_migration.h | 14 +- src/locking/lock_driver.h | 6 +- src/locking/lock_manager.c | 20 +- src/lxc/lxc_driver.c | 30 +- src/node_device/node_device_udev.c | 20 +- src/nwfilter/nwfilter_ebiptables_driver.c | 60 +- src/openvz/openvz_driver.h | 4 +- src/phyp/phyp_driver.c | 8 +- src/qemu/qemu_command.c | 8 +- src/qemu/qemu_conf.c | 84 +- src/qemu/qemu_domain.c | 20 +- src/qemu/qemu_domain.h | 20 +- src/qemu/qemu_driver.c | 226 ++--- src/qemu/qemu_migration.c | 40 +- src/qemu/qemu_migration.h | 66 +- src/qemu/qemu_monitor.c | 44 +- src/qemu/qemu_monitor_json.c | 102 +- src/qemu/qemu_monitor_text.c | 18 +- src/qemu/qemu_parse_command.c | 12 +- src/remote/remote_driver.c | 56 +- src/rpc/virnetclient.c | 8 +- src/security/security_manager.h | 2 +- src/storage/storage_backend.c | 4 +- src/util/viralloc.h | 32 +- src/util/viratomic.h | 114 +-- src/util/viraudit.h | 8 +- src/util/vircommand.c | 4 +- src/util/virconf.c | 8 +- src/util/virdbus.c | 70 +- src/util/virdnsmasq.h | 10 +- src/util/virendian.h | 56 +- src/util/virerror.h | 180 ++-- src/util/virfile.h | 12 +- src/util/virfirewall.c | 38 +- src/util/virhash.c | 8 +- src/util/virlog.c | 10 +- src/util/virlog.h | 30 +- src/util/virnetdev.c | 4 +- src/util/virnetdevopenvswitch.c | 40 +- src/util/virobject.c | 26 +- src/util/virpci.c | 6 +- src/util/virprobe.h | 60 +- src/util/virsocketaddr.h | 6 +- src/util/virstring.h | 2 +- src/util/virsysinfo.c | 14 +- src/util/virsystemd.c | 20 +- src/util/virthread.h | 48 +- src/util/virtypedparam.c | 18 +- src/util/virtypedparam.h | 26 +- src/util/virutil.h | 30 +- src/util/viruuid.h | 18 +- src/util/virxml.c | 4 +- src/util/virxml.h | 12 +- src/vbox/vbox_CAPI_v4_0.h | 6 +- src/vbox/vbox_CAPI_v4_1.h | 6 +- src/vbox/vbox_CAPI_v4_2.h | 6 +- src/vbox/vbox_CAPI_v4_2_20.h | 6 +- src/vbox/vbox_CAPI_v4_3.h | 6 +- src/vbox/vbox_CAPI_v4_3_4.h | 6 +- src/vbox/vbox_CAPI_v5_0.h | 2 +- src/vbox/vbox_CAPI_v5_1.h | 2 +- src/vbox/vbox_common.h | 104 +- src/vbox/vbox_tmpl.c | 36 +- src/vmx/vmx.c | 4 +- src/vz/vz_driver.c | 70 +- src/vz/vz_sdk.c | 80 +- src/vz/vz_utils.h | 22 +- src/xen/xen_driver.c | 4 +- src/xen/xen_driver.h | 8 +- src/xen/xen_hypervisor.c | 398 ++++---- tests/Makefile.am | 78 +- tests/bhyveargv2xmltest.c | 24 +- tests/bhyvexml2argvtest.c | 20 +- tests/bhyvexml2xmltest.c | 12 +- tests/commandtest.c | 6 +- tests/cputest.c | 160 +-- tests/domaincapstest.c | 128 +-- tests/domainconftest.c | 16 +- tests/domainsnapshotxml2xmltest.c | 14 +- tests/esxutilstest.c | 12 +- tests/genericxml2xmltest.c | 14 +- tests/interfacexml2xmltest.c | 6 +- tests/libxlxml2domconfigtest.c | 16 +- tests/lxcconf2xmltest.c | 12 +- tests/lxcxml2xmltest.c | 14 +- tests/metadatatest.c | 18 +- tests/networkxml2conftest.c | 20 +- tests/networkxml2firewalltest.c | 16 +- tests/networkxml2xmltest.c | 12 +- tests/networkxml2xmlupdatetest.c | 32 +- tests/nodedevxml2xmltest.c | 6 +- tests/nsstest.c | 16 +- tests/nwfilterxml2firewalltest.c | 16 +- tests/nwfilterxml2xmltest.c | 18 +- tests/openvzutilstest.c | 12 +- tests/qemuagenttest.c | 4 +- tests/qemuargv2xmltest.c | 14 +- tests/qemucapabilitiestest.c | 18 +- tests/qemucaps2xmltest.c | 8 +- tests/qemucapsprobemock.c | 14 +- tests/qemucommandutiltest.c | 22 +- tests/qemuhelptest.c | 24 +- tests/qemuhotplugtest.c | 94 +- tests/qemumonitorjsontest.c | 346 +++---- tests/qemumonitortest.c | 12 +- tests/qemuxml2argvtest.c | 60 +- tests/qemuxml2xmltest.c | 48 +- tests/secretxml2xmltest.c | 12 +- tests/securityselinuxlabeltest.c | 4 +- tests/securityselinuxtest.c | 24 +- tests/sexpr2xmltest.c | 14 +- tests/sockettest.c | 132 +-- tests/storagebackendsheepdogtest.c | 38 +- tests/storagepoolxml2xmltest.c | 6 +- tests/storagevolxml2argvtest.c | 18 +- tests/storagevolxml2xmltest.c | 14 +- tests/testutils.h | 64 +- tests/utiltest.c | 24 +- tests/vboxsnapshotxmltest.c | 6 +- tests/virauthconfigtest.c | 14 +- tests/virbitmaptest.c | 44 +- tests/virbuftest.c | 72 +- tests/vircaps2xmltest.c | 12 +- tests/vircgroupmock.c | 28 +- tests/vircgrouptest.c | 40 +- tests/virconftest.c | 30 +- tests/vircryptotest.c | 40 +- tests/virdbustest.c | 36 +- tests/virdrivermoduletest.c | 12 +- tests/virfilecachetest.c | 14 +- tests/virfiletest.c | 44 +- tests/virfilewrapper.c | 14 +- tests/virfirewalltest.c | 96 +- tests/virhashtest.c | 22 +- tests/virhostdevtest.c | 28 +- tests/viriscsitest.c | 20 +- tests/virjsontest.c | 14 +- tests/virkeycodetest.c | 32 +- tests/virkmodtest.c | 14 +- tests/virlogtest.c | 26 +- tests/virmacmaptest.c | 66 +- tests/virmock.h | 186 ++-- tests/virnetdaemontest.c | 16 +- tests/virnetdevbandwidthtest.c | 60 +- tests/virnetdevtest.c | 12 +- tests/virnettlscontexttest.c | 52 +- tests/virnettlshelpers.c | 36 +- tests/virnettlssessiontest.c | 90 +- tests/virpcimock.c | 32 +- tests/virpcitest.c | 80 +- tests/virschematest.c | 80 +- tests/virscsitest.c | 10 +- tests/virshtest.c | 14 +- tests/virstoragetest.c | 98 +- tests/virstorageutiltest.c | 30 +- tests/virstringtest.c | 232 ++--- tests/virsystemdtest.c | 72 +- tests/virtimetest.c | 66 +- tests/viruritest.c | 24 +- tests/virusbtest.c | 36 +- tests/vmwarevertest.c | 16 +- tests/vmx2xmltest.c | 16 +- tests/xlconfigtest.c | 40 +- tests/xmconfigtest.c | 32 +- tests/xml2sexprtest.c | 14 +- tests/xml2vmxtest.c | 16 +- tools/Makefile.am | 252 ++--- tools/nss/libvirt_nss.c | 22 +- tools/virsh-domain-monitor.c | 16 +- tools/virsh-domain.c | 144 +-- tools/virsh-interface.c | 22 +- tools/virsh-interface.h | 4 +- tools/virsh-network.c | 26 +- tools/virsh-network.h | 4 +- tools/virsh-nwfilter.c | 14 +- tools/virsh-nwfilter.h | 4 +- tools/virsh-pool.c | 200 ++-- tools/virsh-pool.h | 4 +- tools/virsh-snapshot.c | 40 +- tools/virsh-volume.c | 36 +- tools/virsh-volume.h | 4 +- tools/virsh.h | 76 +- tools/virt-admin.c | 32 +- tools/virt-host-validate-bhyve.c | 18 +- tools/vsh.h | 136 +-- tools/wireshark/src/packet-libvirt.c | 30 +- 221 files changed, 6421 insertions(+), 6421 deletions(-) diff --git a/Makefile.am b/Makefile.am index d042e9a31..5a805b5ee 100644 --- a/Makefile.am +++ b/Makefile.am @@ -97,11 +97,11 @@ dist-hook: gen-ChangeLog gen-AUTHORS gen_start_date =3D 2009-07-04 .PHONY: gen-ChangeLog gen-ChangeLog: - $(AM_V_GEN)if test -d .git; then \ - $(top_srcdir)/build-aux/gitlog-to-changelog \ - --since=3D$(gen_start_date) > $(distdir)/cl-t; \ - rm -f $(distdir)/ChangeLog; \ - mv $(distdir)/cl-t $(distdir)/ChangeLog; \ + $(AM_V_GEN)if test -d .git; then \ + $(top_srcdir)/build-aux/gitlog-to-changelog \ + --since=3D$(gen_start_date) > $(distdir)/cl-t; \ + rm -f $(distdir)/ChangeLog; \ + mv $(distdir)/cl-t $(distdir)/ChangeLog; \ fi =20 .PHONY: gen-AUTHORS diff --git a/cfg.mk b/cfg.mk index 8ad09e7da..d5db05f68 100644 --- a/cfg.mk +++ b/cfg.mk @@ -42,40 +42,40 @@ generated_files =3D \ _test_script_regex =3D \<\(init\|test-lib\)\.sh\> =20 # Tests not to run as part of "make distcheck". -local-checks-to-skip =3D \ - changelog-check \ - makefile-check \ - makefile_path_separator_check \ - patch-check \ - sc_GPL_version \ - sc_always_defined_macros \ - sc_cast_of_alloca_return_value \ - sc_cross_check_PATH_usage_in_tests \ - sc_dd_max_sym_length \ - sc_error_exit_success \ - sc_file_system \ - sc_immutable_NEWS \ - sc_makefile_path_separator_check \ - sc_obsolete_symbols \ - sc_prohibit_S_IS_definition \ - sc_prohibit_atoi_atof \ - sc_prohibit_hash_without_use \ - sc_prohibit_jm_in_m4 \ - sc_prohibit_quote_without_use \ - sc_prohibit_quotearg_without_use \ - sc_prohibit_stat_st_blocks \ - sc_prohibit_undesirable_word_seq \ - sc_root_tests \ - sc_space_tab \ - sc_sun_os_names \ - sc_system_h_headers \ - sc_texinfo_acronym \ - sc_tight_scope \ - sc_two_space_separator_in_usage \ - sc_error_message_uppercase \ - sc_program_name \ - sc_require_test_exit_idiom \ - sc_makefile_check \ +local-checks-to-skip =3D \ + changelog-check \ + makefile-check \ + makefile_path_separator_check \ + patch-check \ + sc_GPL_version \ + sc_always_defined_macros \ + sc_cast_of_alloca_return_value \ + sc_cross_check_PATH_usage_in_tests \ + sc_dd_max_sym_length \ + sc_error_exit_success \ + sc_file_system \ + sc_immutable_NEWS \ + sc_makefile_path_separator_check \ + sc_obsolete_symbols \ + sc_prohibit_S_IS_definition \ + sc_prohibit_atoi_atof \ + sc_prohibit_hash_without_use \ + sc_prohibit_jm_in_m4 \ + sc_prohibit_quote_without_use \ + sc_prohibit_quotearg_without_use \ + sc_prohibit_stat_st_blocks \ + sc_prohibit_undesirable_word_seq \ + sc_root_tests \ + sc_space_tab \ + sc_sun_os_names \ + sc_system_h_headers \ + sc_texinfo_acronym \ + sc_tight_scope \ + sc_two_space_separator_in_usage \ + sc_error_message_uppercase \ + sc_program_name \ + sc_require_test_exit_idiom \ + sc_makefile_check \ sc_useless_cpp_parens =20 # Most developers don't run 'make distcheck'. We want the official @@ -94,91 +94,91 @@ VC_LIST_ALWAYS_EXCLUDE_REGEX =3D \ (^(docs/(news(-[0-9]*)?\.html\.in|.*\.patch))|\.(po|fig|gif|ico|png))$$ =20 # Functions like free() that are no-ops on NULL arguments. -useless_free_options =3D \ - --name=3DVBOX_UTF16_FREE \ - --name=3DVBOX_UTF8_FREE \ - --name=3DVBOX_COM_UNALLOC_MEM \ - --name=3DVIR_FREE \ - --name=3DqemuCapsFree \ - --name=3DqemuMigrationCookieFree \ - --name=3DqemuMigrationCookieGraphicsFree \ - --name=3Dsexpr_free \ - --name=3DusbFreeDevice \ - --name=3DvirBandwidthDefFree \ - --name=3DvirBitmapFree \ - --name=3DvirCPUDefFree \ - --name=3DvirCapabilitiesFree \ - --name=3DvirCapabilitiesFreeGuest \ - --name=3DvirCapabilitiesFreeGuestDomain \ - --name=3DvirCapabilitiesFreeGuestFeature \ - --name=3DvirCapabilitiesFreeGuestMachine \ - --name=3DvirCapabilitiesFreeHostNUMACell \ - --name=3DvirCapabilitiesFreeMachines \ - --name=3DvirCgroupFree \ - --name=3DvirCommandFree \ - --name=3DvirConfFreeList \ - --name=3DvirConfFreeValue \ - --name=3DvirDomainActualNetDefFree \ - --name=3DvirDomainChrDefFree \ - --name=3DvirDomainChrSourceDefFree \ - --name=3DvirDomainControllerDefFree \ - --name=3DvirDomainDefFree \ - --name=3DvirDomainDeviceDefFree \ - --name=3DvirDomainDiskDefFree \ - --name=3DvirDomainEventCallbackListFree \ - --name=3DvirObjectEventQueueFree \ - --name=3DvirDomainFSDefFree \ - --name=3DvirDomainGraphicsDefFree \ - --name=3DvirDomainHostdevDefFree \ - --name=3DvirDomainInputDefFree \ - --name=3DvirDomainNetDefFree \ - --name=3DvirDomainObjFree \ - --name=3DvirDomainSmartcardDefFree \ - --name=3DvirDomainSnapshotDefFree \ - --name=3DvirDomainSnapshotObjFree \ - --name=3DvirDomainSoundDefFree \ - --name=3DvirDomainVideoDefFree \ - --name=3DvirDomainWatchdogDefFree \ - --name=3DvirFileDirectFdFree \ - --name=3DvirHashFree \ - --name=3DvirInterfaceDefFree \ - --name=3DvirInterfaceIpDefFree \ - --name=3DvirInterfaceObjFree \ - --name=3DvirInterfaceProtocolDefFree \ - --name=3DvirJSONValueFree \ - --name=3DvirLastErrFreeData \ - --name=3DvirNetMessageFree \ - --name=3DvirNetServerMDNSFree \ - --name=3DvirNetServerMDNSEntryFree \ - --name=3DvirNetServerMDNSGroupFree \ - --name=3DvirNWFilterDefFree \ - --name=3DvirNWFilterEntryFree \ - --name=3DvirNWFilterHashTableFree \ - --name=3DvirNWFilterIPAddrLearnReqFree \ - --name=3DvirNWFilterIncludeDefFree \ - --name=3DvirNWFilterObjFree \ - --name=3DvirNWFilterRuleDefFree \ - --name=3DvirNWFilterRuleInstFree \ - --name=3DvirNetworkDefFree \ - --name=3DvirNodeDeviceDefFree \ - --name=3DvirNodeDeviceObjFree \ - --name=3DvirObjectUnref \ - --name=3DvirObjectFreeCallback \ - --name=3DvirPCIDeviceFree \ - --name=3DvirSecretDefFree \ - --name=3DvirStorageEncryptionFree \ - --name=3DvirStorageEncryptionSecretFree \ - --name=3DvirStorageFileFreeMetadata \ - --name=3DvirStoragePoolDefFree \ - --name=3DvirStoragePoolObjFree \ - --name=3DvirStoragePoolSourceFree \ - --name=3DvirStorageVolDefFree \ - --name=3DvirThreadPoolFree \ - --name=3DxmlBufferFree \ - --name=3DxmlFree \ - --name=3DxmlFreeDoc \ - --name=3DxmlFreeNode \ - --name=3DxmlXPathFreeContext \ +useless_free_options =3D \ + --name=3DVBOX_UTF16_FREE \ + --name=3DVBOX_UTF8_FREE \ + --name=3DVBOX_COM_UNALLOC_MEM \ + --name=3DVIR_FREE \ + --name=3DqemuCapsFree \ + --name=3DqemuMigrationCookieFree \ + --name=3DqemuMigrationCookieGraphicsFree \ + --name=3Dsexpr_free \ + --name=3DusbFreeDevice \ + --name=3DvirBandwidthDefFree \ + --name=3DvirBitmapFree \ + --name=3DvirCPUDefFree \ + --name=3DvirCapabilitiesFree \ + --name=3DvirCapabilitiesFreeGuest \ + --name=3DvirCapabilitiesFreeGuestDomain \ + --name=3DvirCapabilitiesFreeGuestFeature \ + --name=3DvirCapabilitiesFreeGuestMachine \ + --name=3DvirCapabilitiesFreeHostNUMACell \ + --name=3DvirCapabilitiesFreeMachines \ + --name=3DvirCgroupFree \ + --name=3DvirCommandFree \ + --name=3DvirConfFreeList \ + --name=3DvirConfFreeValue \ + --name=3DvirDomainActualNetDefFree \ + --name=3DvirDomainChrDefFree \ + --name=3DvirDomainChrSourceDefFree \ + --name=3DvirDomainControllerDefFree \ + --name=3DvirDomainDefFree \ + --name=3DvirDomainDeviceDefFree \ + --name=3DvirDomainDiskDefFree \ + --name=3DvirDomainEventCallbackListFree \ + --name=3DvirObjectEventQueueFree \ + --name=3DvirDomainFSDefFree \ + --name=3DvirDomainGraphicsDefFree \ + --name=3DvirDomainHostdevDefFree \ + --name=3DvirDomainInputDefFree \ + --name=3DvirDomainNetDefFree \ + --name=3DvirDomainObjFree \ + --name=3DvirDomainSmartcardDefFree \ + --name=3DvirDomainSnapshotDefFree \ + --name=3DvirDomainSnapshotObjFree \ + --name=3DvirDomainSoundDefFree \ + --name=3DvirDomainVideoDefFree \ + --name=3DvirDomainWatchdogDefFree \ + --name=3DvirFileDirectFdFree \ + --name=3DvirHashFree \ + --name=3DvirInterfaceDefFree \ + --name=3DvirInterfaceIpDefFree \ + --name=3DvirInterfaceObjFree \ + --name=3DvirInterfaceProtocolDefFree \ + --name=3DvirJSONValueFree \ + --name=3DvirLastErrFreeData \ + --name=3DvirNetMessageFree \ + --name=3DvirNetServerMDNSFree \ + --name=3DvirNetServerMDNSEntryFree \ + --name=3DvirNetServerMDNSGroupFree \ + --name=3DvirNWFilterDefFree \ + --name=3DvirNWFilterEntryFree \ + --name=3DvirNWFilterHashTableFree \ + --name=3DvirNWFilterIPAddrLearnReqFree \ + --name=3DvirNWFilterIncludeDefFree \ + --name=3DvirNWFilterObjFree \ + --name=3DvirNWFilterRuleDefFree \ + --name=3DvirNWFilterRuleInstFree \ + --name=3DvirNetworkDefFree \ + --name=3DvirNodeDeviceDefFree \ + --name=3DvirNodeDeviceObjFree \ + --name=3DvirObjectUnref \ + --name=3DvirObjectFreeCallback \ + --name=3DvirPCIDeviceFree \ + --name=3DvirSecretDefFree \ + --name=3DvirStorageEncryptionFree \ + --name=3DvirStorageEncryptionSecretFree \ + --name=3DvirStorageFileFreeMetadata \ + --name=3DvirStoragePoolDefFree \ + --name=3DvirStoragePoolObjFree \ + --name=3DvirStoragePoolSourceFree \ + --name=3DvirStorageVolDefFree \ + --name=3DvirThreadPoolFree \ + --name=3DxmlBufferFree \ + --name=3DxmlFree \ + --name=3DxmlFreeDoc \ + --name=3DxmlFreeNode \ + --name=3DxmlXPathFreeContext \ --name=3DxmlXPathFreeObject =20 # The following template was generated by this command: -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu May 2 04:10:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1509460279852876.8922806167174; Tue, 31 Oct 2017 07:31:19 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D9CC27EAB0; Tue, 31 Oct 2017 14:31:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE84A5C54B; Tue, 31 Oct 2017 14:31:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 487051804486; Tue, 31 Oct 2017 14:31:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9VEVETE030537 for ; Tue, 31 Oct 2017 10:31:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id E0DA65D6AE; Tue, 31 Oct 2017 14:31:14 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.219]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 639815D6A3 for ; Tue, 31 Oct 2017 14:31:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D9CC27EAB0 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 31 Oct 2017 15:31:04 +0100 Message-Id: <20171031143104.28663-3-abologna@redhat.com> In-Reply-To: <20171031143104.28663-1-abologna@redhat.com> References: <20171031143104.28663-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/2] cfg.mk: Prohibit backspace alignment attempts X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 31 Oct 2017 14:31:18 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Now that our codebase is clean, we can add a syntax-check rule to ensure it will remain so. Signed-off-by: Andrea Bolognani --- cfg.mk | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cfg.mk b/cfg.mk index d5db05f68..5321a52b7 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1037,6 +1037,12 @@ sc_prohibit_http_urls: halt=3D'Links must use https:// protocol' \ $(_sc_search_regexp) =20 +sc_prohibit_backslash_alignment: + @prohibit=3D'[[:blank:]][[:blank:]]\\$$' \ + in_vc_files=3D'*\.([chx]|am|mk)$$' \ + halt=3D'Do not attempt to right-align backslashes' \ + $(_sc_search_regexp) + # We don't use this feature of maint.mk. prev_version_file =3D /dev/null =20 --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list