[v5] daemon: fix termination/reload issues

[libvirt] [PATCH v5 0/3] daemon: fix termination/reload issues

John Ferlan posted 3 patches 6 years, 5 months ago

Diff against v2 v3 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20171030111439.26749-1-jferlan@redhat.com

src/locking/lock_daemon.c | 4 ++++
src/rpc/virnetdaemon.c    | 2 ++
2 files changed, 6 insertions(+)

Expand all Fold all

[libvirt] [PATCH v5 0/3] daemon: fix termination/reload issues

Posted by John Ferlan 6 years, 5 months ago

v4: https://www.redhat.com/archives/libvir-list/2017-October/msg01249.html

Difference to v4 - inserted a patch to handle the Unref possibilities
in virLockDaemonNew when either the @srv is placed into the daemon
net server hash table or if virNetDaemonNew fails.

Patch 3 has a minor change (from previous review) to not set
dmn->servers = NULL allowing the virHashFree in virNetDaemonDispose.

John Ferlan (1):
  lockd: Need to Unref @srv when done with it.

Nikolay Shirokovskiy (2):
  virtlogd: add missing netserver refcount increment on reload
  libvirtd: fix crash on termination

 src/locking/lock_daemon.c | 4 ++++
 src/rpc/virnetdaemon.c    | 2 ++
 2 files changed, 6 insertions(+)

-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v5 0/3] daemon: fix termination/reload issues

Posted by Nikolay Shirokovskiy 6 years, 5 months ago

On 30.10.2017 14:14, John Ferlan wrote:
> v4: https://www.redhat.com/archives/libvir-list/2017-October/msg01249.html
> 
> Difference to v4 - inserted a patch to handle the Unref possibilities
> in virLockDaemonNew when either the @srv is placed into the daemon
> net server hash table or if virNetDaemonNew fails.
> 
> Patch 3 has a minor change (from previous review) to not set
> dmn->servers = NULL allowing the virHashFree in virNetDaemonDispose.
> 
> John Ferlan (1):
>   lockd: Need to Unref @srv when done with it.
> 
> Nikolay Shirokovskiy (2):
>   virtlogd: add missing netserver refcount increment on reload
>   libvirtd: fix crash on termination
> 
>  src/locking/lock_daemon.c | 4 ++++
>  src/rpc/virnetdaemon.c    | 2 ++
>  2 files changed, 6 insertions(+)
> 

I'm OK with this series.

Nikolay

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list