[v4] daemon: fix termination/reload issues

[libvirt] [PATCH v4 0/2] daemon: fix termination/reload issues

John Ferlan posted 2 patches 6 years, 6 months ago

Diff against v2 v3 v5
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20171027052612.6720-1-jferlan@redhat.com

There is a newer version of this series

src/locking/lock_daemon.c | 19 ++++++++++++++-----
src/rpc/virnetdaemon.c    |  4 ++++
2 files changed, 18 insertions(+), 5 deletions(-)

Expand all Fold all

[libvirt] [PATCH v4 0/2] daemon: fix termination/reload issues

Posted by John Ferlan 6 years, 6 months ago

This is a repost/fixup of Nikolay's v3:

https://www.redhat.com/archives/libvir-list/2017-October/msg01089.html

The primary difference here is a reorder of the patches to perform
the proper refcnt operations before reordering the shutdown path in
order to clean up servers out of the hash table sooner than later.
In particular, the lock_manager sequencing in order to make sure that
the virObjectUnref is done "orderly".

Nikolay - if you're fine with these changes let me know and I can
then push them (unless of course someone else ACK's before that).
Hopefully the change to lock_daemon makes sense.

Theoretically spaking the virHashFree in virNetDaemonDispose is
probably now superfluous since patch 2/2 will remove all the servers
much sooner, but let's keep it there just to be safe!

Nikolay Shirokovskiy (2):
  rpc: When adding srv to dmn servers, need to add ref
  libvirtd: fix crash on termination

 src/locking/lock_daemon.c | 19 ++++++++++++++-----
 src/rpc/virnetdaemon.c    |  4 ++++
 2 files changed, 18 insertions(+), 5 deletions(-)

-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list