From nobody Fri May 3 12:16:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 150813869859933.45997503581032; Mon, 16 Oct 2017 00:24:58 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0BA354E4CA; Mon, 16 Oct 2017 07:24:57 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3A6917187; Mon, 16 Oct 2017 07:24:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4DBA418355DA; Mon, 16 Oct 2017 07:24:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9G7Oo5i009671 for ; Mon, 16 Oct 2017 03:24:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id A5CF55EE02; Mon, 16 Oct 2017 07:24:50 +0000 (UTC) Received: from mx1.redhat.com (ext-mx02.extmail.prod.ext.phx2.redhat.com [10.5.110.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A0A0A5D6A9 for ; Mon, 16 Oct 2017 07:24:48 +0000 (UTC) Received: from m15-111.126.com (m15-111.126.com [220.181.15.111]) by mx1.redhat.com (Postfix) with ESMTP id 05661883A5 for ; Mon, 16 Oct 2017 07:24:44 +0000 (UTC) Received: from localhost.localdomain (unknown [58.213.111.46]) by smtp1 (Coremail) with SMTP id C8mowACnmzJwV+RZZF6VAg--.59253S2; Mon, 16 Oct 2017 14:53:43 +0800 (CST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0BA354E4CA Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=126.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0BA354E4CA Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (1024-bit key) header.d=126.com header.i=@126.com header.b="Eipo9AfV" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 05661883A5 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=chen_han_xiao@126.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 05661883A5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=Xc4XQEzKBS51PXBhnH IY5fNn/ZMB2UhuiggGEVHYTPk=; b=Eipo9AfVbkPKyoRB3lHyfdN8V0FCa0UnKv YQ8mEvMqJxYg8cTb1rMUdXRYXJZir8qzot0nLQ4F2NyOOINIzmta0HDEHV9ty8Ke A5J7OTxgEv032DDRNyeHMd5/MYeBC1gXIzeRMfgTkId4jm4/UnOe7g6PmK8v/Dsj Jvk4hCJjQ= From: Chen Hanxiao To: libvir-list@redhat.com Date: Mon, 16 Oct 2017 14:53:22 +0800 Message-Id: <20171016065322.23287-1-chen_han_xiao@126.com> X-CM-TRANSID: C8mowACnmzJwV+RZZF6VAg--.59253S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7CF1DXw1kZrWfCr1Uur1xXwb_yoW8Zw4DpF Z5GFW5J3Z7XFnYqwn3Aw15uFyUu3y7uF109Fs5Zw12vF15Za92gw12kFy29F97Zr18Z3ZY vF4a9w4UXaykAwUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07USPfdUUUUU= X-Originating-IP: [58.213.111.46] X-CM-SenderInfo: xfkh0spkdqs5xldrqiyswou0bp/1tbikRNzrlP7L2wDAQAAs2 X-Greylist: Delayed for 00:30:57 by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 16 Oct 2017 07:24:46 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 16 Oct 2017 07:24:46 +0000 (UTC) for IP:'220.181.15.111' DOMAIN:'m15-111.126.com' HELO:'m15-111.126.com' FROM:'chen_han_xiao@126.com' RCPT:'' X-RedHat-Spam-Score: 2.499 ** (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_PSBL, RCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD, SPF_PASS) 220.181.15.111 m15-111.126.com 220.181.15.111 m15-111.126.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.26 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Chen Hanxiao Subject: [libvirt] [PATCH] virsh: domifaddr: clarify description of --full option X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 16 Oct 2017 07:24:57 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: Chen Hanxiao Option --full will always display the name and MAC address of the interface. Both virsh help and virsh man page didn't mention that. Signed-off-by: Chen Hanxiao Reviewed-by: John Ferlan --- tools/virsh-domain-monitor.c | 2 +- tools/virsh.pod | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 4c50155e1..35d04b22a 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -2153,7 +2153,7 @@ static const vshCmdOptDef opts_domifaddr[] =3D { {.name =3D "full", .type =3D VSH_OT_BOOL, .flags =3D VSH_OFLAG_NONE, - .help =3D N_("display full fields")}, + .help =3D N_("always display names and MACs of interfaces")}, {.name =3D "source", .type =3D VSH_OT_STRING, .flags =3D VSH_OFLAG_NONE, diff --git a/tools/virsh.pod b/tools/virsh.pod index 9304ca525..db1ede880 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -766,9 +766,9 @@ addresses, or limited output just for one interface if = I is specified. Note that I can be driver dependent, it can be the n= ame within guest OS or the name you would see in domain XML. Moreover, the who= le command may require a guest agent to be configured for the queried domain = under -some drivers, notably qemu. If I<--full> is specified, the interface name = is -always displayed when the interface has multiple addresses or alias, other= wise -it only displays the interface name for the first address, and "-" for the +some drivers, notably qemu. If I<--full> is specified, the interface name = and MAC +address is always displayed when the interface has multiple addresses or a= lias, +otherwise it only displays the interface name for the first address, and "= -" for the others. The I<--source> argument specifies what data source to use for the addresses, currently one of 'lease' to read DHCP leases, or 'agent' to que= ry the guest OS via an agent. If unspecified, 'lease' is the default. --=20 2.13.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list