[libvirt] [PATCH v3 0/5] nwfilter common object adjustments

John Ferlan posted 5 patches 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20171005233231.3278-1-jferlan@redhat.com
There is a newer version of this series
src/conf/virnwfilterobj.c              | 555 +++++++++++++++++++++++----------
src/conf/virnwfilterobj.h              |  11 +-
src/libvirt_private.syms               |   3 +-
src/nwfilter/nwfilter_driver.c         |  77 +++--
src/nwfilter/nwfilter_gentech_driver.c |  11 +-
5 files changed, 433 insertions(+), 224 deletions(-)
[libvirt] [PATCH v3 0/5] nwfilter common object adjustments
Posted by John Ferlan 6 years, 6 months ago
v2: https://www.redhat.com/archives/libvir-list/2017-July/msg00673.html
(and a few pings along the way)

Don't think much survived from v2 - this is a fresh start anyway.
Perhaps old patch 2 the same, but beyond that a different approach
to remove recursive read/write locks and replace with using rwlock
read/write where the write's are in very tight confines.

I've run the changes through avocado with success. There were some
really strange deadlocks along the way - even causing libvirtd to
go defunct. There's a lot of strange ways to use/access the nwfilters.

John Ferlan (5):
  nwfilter: Add update locking to Initialization
  nwfilter: Remove unnecessary UUID comparison bypass
  nwfilter: Convert _virNWFilterObj to use virObjectRWLockable
  nwfilter: Convert _virNWFilterObjList to use virObjectRWLockable
  nwfilter: Remove need for nwfilterDriverLock in some API's

 src/conf/virnwfilterobj.c              | 555 +++++++++++++++++++++++----------
 src/conf/virnwfilterobj.h              |  11 +-
 src/libvirt_private.syms               |   3 +-
 src/nwfilter/nwfilter_driver.c         |  77 +++--
 src/nwfilter/nwfilter_gentech_driver.c |  11 +-
 5 files changed, 433 insertions(+), 224 deletions(-)

-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 0/5] nwfilter common object adjustments
Posted by John Ferlan 6 years, 5 months ago
Ping?

Any brave souls out there?

Tks,

John

On 10/05/2017 07:32 PM, John Ferlan wrote:
> v2: https://www.redhat.com/archives/libvir-list/2017-July/msg00673.html
> (and a few pings along the way)
> 
> Don't think much survived from v2 - this is a fresh start anyway.
> Perhaps old patch 2 the same, but beyond that a different approach
> to remove recursive read/write locks and replace with using rwlock
> read/write where the write's are in very tight confines.
> 
> I've run the changes through avocado with success. There were some
> really strange deadlocks along the way - even causing libvirtd to
> go defunct. There's a lot of strange ways to use/access the nwfilters.
> 
> John Ferlan (5):
>   nwfilter: Add update locking to Initialization
>   nwfilter: Remove unnecessary UUID comparison bypass
>   nwfilter: Convert _virNWFilterObj to use virObjectRWLockable
>   nwfilter: Convert _virNWFilterObjList to use virObjectRWLockable
>   nwfilter: Remove need for nwfilterDriverLock in some API's
> 
>  src/conf/virnwfilterobj.c              | 555 +++++++++++++++++++++++----------
>  src/conf/virnwfilterobj.h              |  11 +-
>  src/libvirt_private.syms               |   3 +-
>  src/nwfilter/nwfilter_driver.c         |  77 +++--
>  src/nwfilter/nwfilter_gentech_driver.c |  11 +-
>  5 files changed, 433 insertions(+), 224 deletions(-)
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list