From nobody Mon Apr 29 05:47:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 150642218134647.49499189987523; Tue, 26 Sep 2017 03:36:21 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 00BDC7E425; Tue, 26 Sep 2017 10:36:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D158B6F947; Tue, 26 Sep 2017 10:36:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8ACF11808874; Tue, 26 Sep 2017 10:36:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v8QAGAXg016791 for ; Tue, 26 Sep 2017 06:16:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4F79077D46; Tue, 26 Sep 2017 10:16:10 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.42.22.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F73E77D42; Tue, 26 Sep 2017 10:16:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 00BDC7E425 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: "Daniel P. Berrange" To: libvir-list@redhat.com Date: Tue, 26 Sep 2017 11:16:05 +0100 Message-Id: <20170926101605.28730-1-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH python] Fix comparisons between signed & unsigned integers X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 26 Sep 2017 10:36:20 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" When python3 builds C modules, it adds the -Wsign-compare flag to GCC. This creates lots of warnings where we compare a 'size_t' value against an 'int' value due to signed/unsigned difference. Change all the size_t types to ssize_t to address this. Signed-off-by: Daniel P. Berrange --- libvirt-lxc-override.c | 2 +- libvirt-override.c | 108 ++++++++++++++++++++++++---------------------= ---- libvirt-utils.c | 8 ++-- typewrappers.c | 2 +- 4 files changed, 60 insertions(+), 60 deletions(-) diff --git a/libvirt-lxc-override.c b/libvirt-lxc-override.c index 316a500..60c2e48 100644 --- a/libvirt-lxc-override.c +++ b/libvirt-lxc-override.c @@ -63,7 +63,7 @@ libvirt_lxc_virDomainLxcOpenNamespace(PyObject *self ATTR= IBUTE_UNUSED, unsigned int flags; int c_retval; int *fdlist =3D NULL; - size_t i; + ssize_t i; =20 if (!PyArg_ParseTuple(args, (char *)"OI:virDomainLxcOpenNamespace", &pyobj_domain, &flags)) diff --git a/libvirt-override.c b/libvirt-override.c index 9eba4ed..bde7f4b 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -187,7 +187,7 @@ libvirt_virDomainGetCPUStats(PyObject *self ATTRIBUTE_U= NUSED, PyObject *error =3D NULL; int ncpus =3D -1, start_cpu =3D 0; int sumparams =3D 0, nparams =3D -1; - size_t i; + ssize_t i; int i_retval; unsigned int flags; bool totalflag; @@ -354,7 +354,7 @@ libvirt_virDomainMemoryStats(PyObject *self ATTRIBUTE_U= NUSED, virDomainPtr domain; PyObject *pyobj_domain; unsigned int nr_stats; - size_t i; + ssize_t i; virDomainMemoryStatStruct stats[VIR_DOMAIN_MEMORY_STAT_NR]; PyObject *info; PyObject *key =3D NULL, *val =3D NULL; @@ -365,7 +365,7 @@ libvirt_virDomainMemoryStats(PyObject *self ATTRIBUTE_U= NUSED, =20 nr_stats =3D virDomainMemoryStats(domain, stats, VIR_DOMAIN_MEMORY_STAT_NR, 0); - if (nr_stats =3D=3D -1) + if (nr_stats =3D=3D (unsigned int)-1) return VIR_PY_NONE; =20 /* convert to a Python dictionary */ @@ -1204,7 +1204,7 @@ libvirt_virDomainGetVcpus(PyObject *self ATTRIBUTE_UN= USED, virDomainInfo dominfo; virVcpuInfoPtr cpuinfo =3D NULL; unsigned char *cpumap =3D NULL; - size_t cpumaplen, i; + ssize_t cpumaplen, i; int i_retval, cpunum; =20 if (!PyArg_ParseTuple(args, (char *)"O:virDomainGetVcpus", @@ -1274,7 +1274,7 @@ libvirt_virDomainGetVcpus(PyObject *self ATTRIBUTE_UN= USED, } for (i =3D 0; i < dominfo.nrVirtCpu; i++) { PyObject *info =3D PyTuple_New(cpunum); - size_t j; + ssize_t j; if (info =3D=3D NULL) goto cleanup; =20 @@ -1384,7 +1384,7 @@ libvirt_virDomainGetVcpuPinInfo(PyObject *self ATTRIB= UTE_UNUSED, PyObject *pyobj_domain, *pycpumaps =3D NULL, *error =3D NULL; virDomainInfo dominfo; unsigned char *cpumaps =3D NULL; - size_t cpumaplen, vcpu, pcpu; + ssize_t cpumaplen, vcpu, pcpu; unsigned int flags; int i_retval, cpunum; =20 @@ -1496,8 +1496,8 @@ libvirt_virDomainGetEmulatorPinInfo(PyObject *self AT= TRIBUTE_UNUSED, PyObject *pyobj_domain; PyObject *pycpumap; unsigned char *cpumap; - size_t cpumaplen; - size_t pcpu; + ssize_t cpumaplen; + ssize_t pcpu; unsigned int flags; int ret; int cpunum; @@ -1560,7 +1560,7 @@ libvirt_virDomainGetIOThreadInfo(PyObject *self ATTRI= BUTE_UNUSED, PyObject *py_iothrinfo =3D NULL; virDomainIOThreadInfoPtr *iothrinfo =3D NULL; unsigned int flags; - size_t pcpu, i; + ssize_t pcpu, i; int niothreads, cpunum; =20 if (!PyArg_ParseTuple(args, (char *)"OI:virDomainGetIOThreadInfo", @@ -1846,7 +1846,7 @@ virConnectCredCallbackWrapper(virConnectCredentialPtr= cred, PyObject *pycb; PyObject *pyret =3D NULL; int ret =3D -1; - size_t i; + ssize_t i; =20 LIBVIRT_ENSURE_THREAD_STATE; =20 @@ -1953,7 +1953,7 @@ libvirt_virConnectOpenAuth(PyObject *self ATTRIBUTE_U= NUSED, =20 auth.ncredtype =3D PyList_Size(pycredtype); if (auth.ncredtype) { - size_t i; + ssize_t i; if (VIR_ALLOC_N(auth.credtype, auth.ncredtype) < 0) return PyErr_NoMemory(); for (i =3D 0; i < auth.ncredtype; i++) { @@ -2046,7 +2046,7 @@ libvirt_virConnectGetCPUModelNames(PyObject *self ATT= RIBUTE_UNUSED, virConnectPtr conn; PyObject *rv =3D NULL, *pyobj_conn; char **models =3D NULL; - size_t i; + ssize_t i; unsigned int flags =3D 0; const char *arch =3D NULL; =20 @@ -2117,7 +2117,7 @@ libvirt_virConnectListDomainsID(PyObject *self ATTRIB= UTE_UNUSED, { PyObject *py_retval; int *ids =3D NULL, c_retval; - size_t i; + ssize_t i; virConnectPtr conn; PyObject *pyobj_conn; =20 @@ -2172,7 +2172,7 @@ libvirt_virConnectListAllDomains(PyObject *self ATTRI= BUTE_UNUSED, virConnectPtr conn; virDomainPtr *doms =3D NULL; int c_retval =3D 0; - size_t i; + ssize_t i; unsigned int flags; =20 if (!PyArg_ParseTuple(args, (char *)"OI:virConnectListAllDomains", @@ -2215,7 +2215,7 @@ libvirt_virConnectListDefinedDomains(PyObject *self A= TTRIBUTE_UNUSED, PyObject *py_retval; char **names =3D NULL; int c_retval; - size_t i; + ssize_t i; virConnectPtr conn; PyObject *pyobj_conn; =20 @@ -2271,7 +2271,7 @@ libvirt_virDomainSnapshotListNames(PyObject *self ATT= RIBUTE_UNUSED, PyObject *py_retval; char **names =3D NULL; int c_retval; - size_t i; + ssize_t i; virDomainPtr dom; PyObject *pyobj_dom; unsigned int flags; @@ -2325,7 +2325,7 @@ libvirt_virDomainListAllSnapshots(PyObject *self ATTR= IBUTE_UNUSED, PyObject *py_retval =3D NULL; virDomainSnapshotPtr *snaps =3D NULL; int c_retval; - size_t i; + ssize_t i; virDomainPtr dom; PyObject *pyobj_dom; unsigned int flags; @@ -2370,7 +2370,7 @@ libvirt_virDomainSnapshotListChildrenNames(PyObject *= self ATTRIBUTE_UNUSED, PyObject *py_retval; char **names =3D NULL; int c_retval; - size_t i; + ssize_t i; virDomainSnapshotPtr snap; PyObject *pyobj_snap; unsigned int flags; @@ -2425,7 +2425,7 @@ libvirt_virDomainSnapshotListAllChildren(PyObject *se= lf ATTRIBUTE_UNUSED, PyObject *py_retval =3D NULL; virDomainSnapshotPtr *snaps =3D NULL; int c_retval; - size_t i; + ssize_t i; virDomainSnapshotPtr parent; PyObject *pyobj_parent; unsigned int flags; @@ -2762,7 +2762,7 @@ libvirt_virDomainGetSecurityLabelList(PyObject *self = ATTRIBUTE_UNUSED, virDomainPtr dom; PyObject *pyobj_dom; virSecurityLabel *labels =3D NULL; - size_t i; + ssize_t i; =20 if (!PyArg_ParseTuple(args, (char *)"O:virDomainGetSecurityLabelList", &pyobj_dom)) @@ -2889,7 +2889,7 @@ libvirt_virConnectListNetworks(PyObject *self ATTRIBU= TE_UNUSED, PyObject *py_retval; char **names =3D NULL; int c_retval; - size_t i; + ssize_t i; virConnectPtr conn; PyObject *pyobj_conn; =20 @@ -2945,7 +2945,7 @@ libvirt_virConnectListDefinedNetworks(PyObject *self = ATTRIBUTE_UNUSED, PyObject *py_retval; char **names =3D NULL; int c_retval; - size_t i; + ssize_t i; virConnectPtr conn; PyObject *pyobj_conn; =20 @@ -3002,7 +3002,7 @@ libvirt_virConnectListAllNetworks(PyObject *self ATTR= IBUTE_UNUSED, virConnectPtr conn; virNetworkPtr *nets =3D NULL; int c_retval =3D 0; - size_t i; + ssize_t i; unsigned int flags; =20 if (!PyArg_ParseTuple(args, (char *)"OI:virConnectListAllNetworks", @@ -3172,7 +3172,7 @@ libvirt_virNodeGetCellsFreeMemory(PyObject *self ATTR= IBUTE_UNUSED, PyObject *py_retval; PyObject *pyobj_conn; int startCell, maxCells, c_retval; - size_t i; + ssize_t i; virConnectPtr conn; unsigned long long *freeMems; =20 @@ -3223,7 +3223,7 @@ libvirt_virNodeGetCPUStats(PyObject *self ATTRIBUTE_U= NUSED, virConnectPtr conn; unsigned int flags; int cpuNum, c_retval; - size_t i; + ssize_t i; int nparams =3D 0; virNodeCPUStatsPtr stats =3D NULL; =20 @@ -3281,7 +3281,7 @@ libvirt_virNodeGetMemoryStats(PyObject *self ATTRIBUT= E_UNUSED, virConnectPtr conn; unsigned int flags; int cellNum, c_retval; - size_t i; + ssize_t i; int nparams =3D 0; virNodeMemoryStatsPtr stats =3D NULL; =20 @@ -3335,7 +3335,7 @@ libvirt_virConnectListStoragePools(PyObject *self ATT= RIBUTE_UNUSED, PyObject *py_retval; char **names =3D NULL; int c_retval; - size_t i; + ssize_t i; virConnectPtr conn; PyObject *pyobj_conn; =20 @@ -3389,7 +3389,7 @@ libvirt_virConnectListDefinedStoragePools(PyObject *s= elf ATTRIBUTE_UNUSED, PyObject *py_retval; char **names =3D NULL; int c_retval; - size_t i; + ssize_t i; virConnectPtr conn; PyObject *pyobj_conn; =20 @@ -3447,7 +3447,7 @@ libvirt_virConnectListAllStoragePools(PyObject *self = ATTRIBUTE_UNUSED, virConnectPtr conn; virStoragePoolPtr *pools =3D NULL; int c_retval =3D 0; - size_t i; + ssize_t i; unsigned int flags; =20 if (!PyArg_ParseTuple(args, (char *)"OI:virConnectListAllStoragePools", @@ -3491,7 +3491,7 @@ libvirt_virStoragePoolListVolumes(PyObject *self ATTR= IBUTE_UNUSED, PyObject *py_retval; char **names =3D NULL; int c_retval; - size_t i; + ssize_t i; virStoragePoolPtr pool; PyObject *pyobj_pool; =20 @@ -3548,7 +3548,7 @@ libvirt_virStoragePoolListAllVolumes(PyObject *self A= TTRIBUTE_UNUSED, virStoragePoolPtr pool; virStorageVolPtr *vols =3D NULL; int c_retval =3D 0; - size_t i; + ssize_t i; unsigned int flags; PyObject *pyobj_pool; =20 @@ -3812,7 +3812,7 @@ libvirt_virNodeListDevices(PyObject *self ATTRIBUTE_U= NUSED, PyObject *py_retval; char **names =3D NULL; int c_retval; - size_t i; + ssize_t i; virConnectPtr conn; PyObject *pyobj_conn; char *cap; @@ -3873,7 +3873,7 @@ libvirt_virConnectListAllNodeDevices(PyObject *self A= TTRIBUTE_UNUSED, virConnectPtr conn; virNodeDevicePtr *devices =3D NULL; int c_retval =3D 0; - size_t i; + ssize_t i; unsigned int flags; =20 if (!PyArg_ParseTuple(args, (char *)"OI:virConnectListAllNodeDevices", @@ -3917,7 +3917,7 @@ libvirt_virNodeDeviceListCaps(PyObject *self ATTRIBUT= E_UNUSED, PyObject *py_retval; char **names =3D NULL; int c_retval; - size_t i; + ssize_t i; virNodeDevicePtr dev; PyObject *pyobj_dev; =20 @@ -4048,7 +4048,7 @@ libvirt_virConnectListSecrets(PyObject *self ATTRIBUT= E_UNUSED, char **uuids =3D NULL; virConnectPtr conn; int c_retval; - size_t i; + ssize_t i; PyObject *pyobj_conn; =20 if (!PyArg_ParseTuple(args, (char *)"O:virConnectListSecrets", &pyobj_= conn)) @@ -4104,7 +4104,7 @@ libvirt_virConnectListAllSecrets(PyObject *self ATTRI= BUTE_UNUSED, virConnectPtr conn; virSecretPtr *secrets =3D NULL; int c_retval =3D 0; - size_t i; + ssize_t i; unsigned int flags; =20 if (!PyArg_ParseTuple(args, (char *)"OI:virConnectListAllSecrets", @@ -4280,7 +4280,7 @@ libvirt_virConnectListNWFilters(PyObject *self ATTRIB= UTE_UNUSED, char **uuids =3D NULL; virConnectPtr conn; int c_retval; - size_t i; + ssize_t i; PyObject *pyobj_conn; =20 if (!PyArg_ParseTuple(args, (char *)"O:virConnectListNWFilters", @@ -4337,7 +4337,7 @@ libvirt_virConnectListAllNWFilters(PyObject *self ATT= RIBUTE_UNUSED, virConnectPtr conn; virNWFilterPtr *filters =3D NULL; int c_retval =3D 0; - size_t i; + ssize_t i; unsigned int flags; =20 if (!PyArg_ParseTuple(args, (char *)"OI:virConnectListAllNWFilters", @@ -4381,7 +4381,7 @@ libvirt_virConnectListInterfaces(PyObject *self ATTRI= BUTE_UNUSED, PyObject *py_retval; char **names =3D NULL; int c_retval; - size_t i; + ssize_t i; virConnectPtr conn; PyObject *pyobj_conn; =20 @@ -4438,7 +4438,7 @@ libvirt_virConnectListDefinedInterfaces(PyObject *sel= f ATTRIBUTE_UNUSED, PyObject *py_retval; char **names =3D NULL; int c_retval; - size_t i; + ssize_t i; virConnectPtr conn; PyObject *pyobj_conn; =20 @@ -4499,7 +4499,7 @@ libvirt_virConnectListAllInterfaces(PyObject *self AT= TRIBUTE_UNUSED, virConnectPtr conn; virInterfacePtr *ifaces =3D NULL; int c_retval =3D 0; - size_t i; + ssize_t i; unsigned int flags; =20 if (!PyArg_ParseTuple(args, (char *)"OI:virConnectListAllInterfaces", @@ -4548,7 +4548,7 @@ libvirt_virConnectBaselineCPU(PyObject *self ATTRIBUT= E_UNUSED, int ncpus =3D 0; char *base_cpu; PyObject *pybase_cpu; - size_t i, j; + ssize_t i, j; =20 if (!PyArg_ParseTuple(args, (char *)"OOI:virConnectBaselineCPU", &pyobj_conn, &list, &flags)) @@ -4864,7 +4864,7 @@ libvirt_virDomainGetDiskErrors(PyObject *self ATTRIBU= TE_UNUSED, virDomainDiskErrorPtr disks =3D NULL; unsigned int ndisks; int count; - size_t i; + ssize_t i; =20 if (!PyArg_ParseTuple(args, (char *) "OI:virDomainGetDiskErrors", &pyobj_domain, &flags)) @@ -4925,7 +4925,7 @@ libvirt_virDomainInterfaceAddresses(PyObject *self AT= TRIBUTE_UNUSED, unsigned int source; unsigned int flags; int ifaces_count =3D 0; - size_t i, j; + ssize_t i, j; =20 if (!PyArg_ParseTuple(args, (char *) "OII:virDomainInterfaceAddresses", &pyobj_domain, &source, &flags)) @@ -6020,7 +6020,7 @@ libvirt_virConnectDomainEventGraphicsCallback(virConn= ectPtr conn ATTRIBUTE_UNUSE PyObject *pyobj_remote =3D NULL; PyObject *pyobj_subject =3D NULL; int ret =3D -1; - size_t i; + ssize_t i; =20 LIBVIRT_ENSURE_THREAD_STATE; =20 @@ -7551,7 +7551,7 @@ libvirt_virDomainSendKey(PyObject *self ATTRIBUTE_UNU= SED, int holdtime; unsigned int flags; int ret; - size_t i; + ssize_t i; unsigned int keycodes[VIR_DOMAIN_SEND_KEY_MAX_KEYS]; unsigned int nkeycodes; =20 @@ -7945,7 +7945,7 @@ libvirt_virNodeGetCPUMap(PyObject *self ATTRIBUTE_UNU= SED, unsigned char *cpumap =3D NULL; unsigned int online =3D 0; unsigned int flags; - size_t i; + ssize_t i; =20 if (!PyArg_ParseTuple(args, (char *)"OI:virNodeGetCPUMap", &pyobj_conn, &flags)) @@ -8002,7 +8002,7 @@ libvirt_virDomainCreateWithFiles(PyObject *self ATTRI= BUTE_UNUSED, unsigned int flags; unsigned int nfiles; int *files =3D NULL; - size_t i; + ssize_t i; =20 if (!PyArg_ParseTuple(args, (char *)"OOI:virDomainCreateWithFiles", &pyobj_domain, &pyobj_files, &flags)) @@ -8050,7 +8050,7 @@ libvirt_virDomainCreateXMLWithFiles(PyObject *self AT= TRIBUTE_UNUSED, unsigned int flags; unsigned int nfiles; int *files =3D NULL; - size_t i; + ssize_t i; =20 if (!PyArg_ParseTuple(args, (char *)"OzOI:virDomainCreateXMLWithFiles", &pyobj_conn, &xmlDesc, &pyobj_files, &flags)) @@ -8099,7 +8099,7 @@ libvirt_virDomainFSFreeze(PyObject *self ATTRIBUTE_UN= USED, unsigned int flags; unsigned int nmountpoints =3D 0; char **mountpoints =3D NULL; - size_t i =3D 0, j; + ssize_t i =3D 0, j; =20 if (!PyArg_ParseTuple(args, (char *)"OOI:virDomainFSFreeze", &pyobj_domain, &pyobj_list, &flags)) @@ -8147,7 +8147,7 @@ libvirt_virDomainFSThaw(PyObject *self ATTRIBUTE_UNUS= ED, unsigned int flags; unsigned int nmountpoints =3D 0; char **mountpoints =3D NULL; - size_t i =3D 0, j; + ssize_t i =3D 0, j; =20 if (!PyArg_ParseTuple(args, (char *)"OOI:virDomainFSThaw", &pyobj_domain, &pyobj_list, &flags)) @@ -8380,7 +8380,7 @@ libvirt_virNetworkGetDHCPLeases(PyObject *self ATTRIB= UTE_UNUSED, virNetworkDHCPLeasePtr *leases =3D NULL; int leases_count; char *mac =3D NULL; - size_t i; + ssize_t i; =20 if (!PyArg_ParseTuple(args, (char *) "OzI:virNetworkGetDHCPLeases", &pyobj_network, &mac, &flags)) @@ -8453,7 +8453,7 @@ convertDomainStatsRecord(virDomainStatsRecordPtr *rec= ords, PyObject *py_record; PyObject *py_record_stats =3D NULL; virDomainPtr dom =3D NULL; - size_t i; + ssize_t i; =20 if (!(py_retval =3D PyList_New(nrecords))) return NULL; @@ -8531,7 +8531,7 @@ libvirt_virDomainListGetStats(PyObject *self ATTRIBUT= E_UNUSED, virDomainPtr *doms =3D NULL; int nrecords; int ndoms; - size_t i; + ssize_t i; unsigned int flags; unsigned int stats; =20 diff --git a/libvirt-utils.c b/libvirt-utils.c index 727397d..b8ac5e9 100644 --- a/libvirt-utils.c +++ b/libvirt-utils.c @@ -221,7 +221,7 @@ getPyVirTypedParameter(const virTypedParameter *params, int nparams) { PyObject *key, *val, *info; - size_t i; + ssize_t i; =20 if ((info =3D PyDict_New()) =3D=3D NULL) return NULL; @@ -295,7 +295,7 @@ setPyVirTypedParameter(PyObject *info, #endif virTypedParameterPtr temp =3D NULL, ret =3D NULL; Py_ssize_t size; - size_t i; + ssize_t i; =20 if ((size =3D PyDict_Size(info)) < 0) return NULL; @@ -412,7 +412,7 @@ virPyDictToTypedParamOne(virTypedParameterPtr *params, PyObject *value) { int rv =3D -1, type =3D -1; - size_t i; + ssize_t i; =20 for (i =3D 0; i < nhints; i++) { if (STREQ(hints[i].name, keystr)) { @@ -605,7 +605,7 @@ virPyCpumapConvert(int cpunum, int *cpumaplen) { int tuple_size; - size_t i; + ssize_t i; *cpumapptr =3D NULL; =20 if (!PyTuple_Check(pycpumap)) { diff --git a/typewrappers.c b/typewrappers.c index a9561dd..01ee310 100644 --- a/typewrappers.c +++ b/typewrappers.c @@ -319,7 +319,7 @@ libvirt_ulonglongUnwrap(PyObject *obj, PyErr_SetString(PyExc_TypeError, "an integer is required"); } =20 - if ((ullong_val =3D=3D -1) && PyErr_Occurred()) + if ((ullong_val =3D=3D (unsigned long long)-1) && PyErr_Occurred()) return -1; =20 *val =3D ullong_val; --=20 2.13.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list