[libvirt] [PATCH v7 06.5/11] merge with previous...

John Ferlan posted 1 patch 6 years, 6 months ago
Failed in applying to current master (apply log)
src/qemu/qemu_block.c                                            | 2 +-
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[libvirt] [PATCH v7 06.5/11] merge with previous...
Posted by John Ferlan 6 years, 6 months ago
This patch would be merged with the existing 06/11 patch for the
following changes:

   1. Use qemuBlockStorageSourceBuildJSONSocketAddress to build a single
      server address
   2. Alter the output file to remove the server index "0." values
   3. Alter the commit message appropriately as well.

NB: If it's really desired I could resend the series, but I do ask that
someone else officially ACK's patch 1 since it's so large. I believe it
has to be moderated in... Although I could take Ashish's 1-6 testing as
as "good enough".

Thanks -

John

---
 src/qemu/qemu_block.c                                            | 2 +-
 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index a1867aa8f..ca6e213b4 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -529,7 +529,7 @@ qemuBlockStorageSourceGetVxHSProps(virStorageSourcePtr src)
         return NULL;
     }
 
-    if (!(server = qemuBlockStorageSourceBuildHostsJSONSocketAddress(src, true)))
+    if (!(server = qemuBlockStorageSourceBuildJSONSocketAddress(src->hosts, true)))
         return NULL;
 
     /* VxHS disk specification example:
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args
index 86da1af47..b62ace3de 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args
@@ -21,7 +21,7 @@ server,nowait \
 -boot c \
 -usb \
 -drive file.driver=vxhs,file.vdisk-id=eb90327c-8302-4725-9e1b-4e85ed4dc251,\
-file.server.0.type=tcp,file.server.0.host=192.168.0.1,file.server.0.port=9999,\
+file.server.type=tcp,file.server.host=192.168.0.1,file.server.port=9999,\
 format=raw,if=none,id=drive-virtio-disk0,cache=none \
 -device virtio-blk-pci,bus=pci.0,addr=0x4,drive=drive-virtio-disk0,\
 id=virtio-disk0
-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v7 06.5/11] merge with previous...
Posted by Peter Krempa 6 years, 6 months ago
On Tue, Sep 12, 2017 at 14:39:58 -0400, John Ferlan wrote:
> This patch would be merged with the existing 06/11 patch for the
> following changes:
> 
>    1. Use qemuBlockStorageSourceBuildJSONSocketAddress to build a single
>       server address
>    2. Alter the output file to remove the server index "0." values
>    3. Alter the commit message appropriately as well.
> 
> NB: If it's really desired I could resend the series, but I do ask that
> someone else officially ACK's patch 1 since it's so large. I believe it
> has to be moderated in... Although I could take Ashish's 1-6 testing as
> as "good enough".

With all the squash-ins and .5 patches this got messy. Please repost.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v7 06.5/11] merge with previous...
Posted by John Ferlan 6 years, 6 months ago

On 09/14/2017 04:13 AM, Peter Krempa wrote:
> On Tue, Sep 12, 2017 at 14:39:58 -0400, John Ferlan wrote:
>> This patch would be merged with the existing 06/11 patch for the
>> following changes:
>>
>>    1. Use qemuBlockStorageSourceBuildJSONSocketAddress to build a single
>>       server address
>>    2. Alter the output file to remove the server index "0." values
>>    3. Alter the commit message appropriately as well.
>>
>> NB: If it's really desired I could resend the series, but I do ask that
>> someone else officially ACK's patch 1 since it's so large. I believe it
>> has to be moderated in... Although I could take Ashish's 1-6 testing as
>> as "good enough".
> 
> With all the squash-ins and .5 patches this got messy. Please repost.
> 

Sure, not problem. Any issue w/ me pushing patch 1 first?  The
2.10.replies and 2.10.xml? I think it's large enough that it needs
moderation...

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v7 06.5/11] merge with previous...
Posted by Peter Krempa 6 years, 6 months ago
On Thu, Sep 14, 2017 at 06:53:10 -0400, John Ferlan wrote:
> On 09/14/2017 04:13 AM, Peter Krempa wrote:
> > On Tue, Sep 12, 2017 at 14:39:58 -0400, John Ferlan wrote:

[...]

> > With all the squash-ins and .5 patches this got messy. Please repost.
> > 
> 
> Sure, not problem. Any issue w/ me pushing patch 1 first?  The
> 2.10.replies and 2.10.xml? I think it's large enough that it needs
> moderation...

I asked Pavel to have a look. It's fine from my point of view
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list